-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap TGMPA version 3.0 #394
Comments
You might have problems with this. Since TGMPA can install plugins from outside of the repo it may not be allowed. You can always use GitHub Updater. |
Yes, we've already received feedback that it probably won't be accepted, and utilising the code from GitHub Updater was one of the alternatives. |
If you plan on using code from GitHub Updater, is there anything I can add to make integration easier? |
+1 |
Ideally, we wouldn't need it, but I guess we just need to be able to install just our plugin (no themes, no other plugins) from a GH tag, so it would only need to be a subset of GU, which is why we may just incorporate the credited code we need instead of the whole GU codebase. |
It does come along with install code for GitHub, Bitbucket and soon GitLab. However works best for you Gary. |
Just saw this from WPTavern. This is a great news! Thanks for the improvements! By the way, Chip Bennett from WP.org commented on the article at WPTavern that you should suggest this plugin as a Featured Plugin which then can be integrated into WP core. If it's done, it will be a great outcome for all developers. Hope you consider this. Thanks for amazing script! |
@GaryJones just an FYI. PHP >= 5.3 is required for GHU. You may need/want to consider increasing the PHP requirements for TGMPA 3.0. |
@afragen That's good to know. We don't currently intend to raise the minimum PHP version in favour of staying in line with WP core. If TGMPA's minimum would be upped, it would also mean that all themes and plugins using TGMPA would need to up their minimum PHP version and for now, I think that would be a bridge too far. If it would turn out that we'd need to go down the GHU road, would you be open to a PR making GHU compatible with PHP 5.2 ? |
@jrfnl for TGMPA I will create a branch that is PHP 5.2.x compatible if you would require it. GHU has a built-in branch switcher so if a PHP5.2 compatible branch is made, switching back to Though I understand wanting to maintain core compatibility, core isn't planning to update the requirements until more and more hosts update their versions. By incrementally requiring more current versions of PHP we can encourage hosting companies to upgrade. I can understand existing plugins like Yoast or EDD that have a paid ecosystem not wanting to raise their requirements but TGMPA isn't a premium product or is it. The fact that it is widely used by premium products is a bonus for pushing hosting companies to upgrade their PHP versions. Honestly, as GHU is primarily used by and for developers, I really didn't think twice about moving to PHP 5.3 so I could add namespacing and autoloading. I did previously use I actually upped the PHP requirement of my The Events Calendar Category Colors plugin in the .org repo. This plugin has more than 5000+ active installs and over 50,000 downloads and is an add-on for The Events Calendar. After, creating an error message that was more descriptive of why it may not work, only a couple of users reported issues and did get their hosting companies to upgrade. As TGMPA 3.0 is an entirely new shift, from adding a class to a plugin, it really is the best time to up the requirements. Please reconsider but if not I will make a branch that is PHP 5.2 compatible. |
@afragen Thanks for your offer. Will let you know if we'll need it. 😃 |
WP.org won't allow "frameworks" in the repo anymore. That ship has sailed I fear. What about integrating updating as well. ;) IE, check for updates from a repo. :) |
@dovy Thanks for your input.
They will if it's proposed as a feature plugin which is the path we are currently exploring ;-)
Updating bundled plugins and updating from the wp.org repo already works (included in v2.5 which was just released). Checking for updates from an external repo is a difficult one, but is being considered (#380). The issue with that is that there is no uniform response format for indicating that there is an update available (unless the external repo spoofs a wp.org type response like the https://github.com/YahnisElsts/wp-update-server/ library in combination with https://github.com/YahnisElsts/plugin-update-checker does). |
@jrfnl It's been 4 years already. Is this being worked on? I'm just curious. |
Looks like abandoned |
There's no active development on this. |
Any alternative that does the same but is up to date? |
Any update? Can the authors tell us if the project is dead? Any alternative? |
No active development, and it's highly unlikely to restart. WP core now contains a similar (though currently less mature) implementation that I suspect will improve over time that developers can start moving towards instead. |
Thank you so much |
Please archive this project on GitHub, this will send a signal that the plugin is no longer maintained. Something I also did for a WP plugin I'm no longer maintaining. |
Main aims:
Basic architectural choices:
Tentative indication of OOP direction this list is still liable to change without notice and is in addition to the existing classes:
TGMPA_Plugin
class which holds the properties passed for one individual plugin, can do property negotiation is both a theme as well as a plugin require/recommend the same plugin, will contain methods such asis_active()
,has_update()
,requires_update()
etcTGMPA_Plugins
class which holds the instances of all plugins and methods such asis_complete()
TGMPA_Config
class which holds the config properties passed and can do property negotiation for conflicting properties from different sources.TGMPA_Notices
class which will generate the admin_notices if needed.TGMPA_Execute
class which will act as a controller for requested (bulk-)actions (install/update/activate).TGMPA_Option
class which will manage the tgmpa option which will hold the information registered on theme/plugin activate.Action list:
debug_backtrace()
to find the calling parent if TGMPA is not yet called using v3 codeOther open issues which may or may not be included in v3:
Actions once 3.0 is finished:
Post-3.0 roadmap:
The text was updated successfully, but these errors were encountered: