Check if tgmpa_load_bulk_installer is declared. #207

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@SmashBrando

Adds in a check to see if the tgmpa_load_bulk_installer function has been declared already. Typically it is redeclared when multiple instances are running.

@SmashBrando SmashBrando Check if tgmpa_load_bulk_installer is declared.
Adds in a check to see if the tgmpa_load_bulk_installer function has been declared already. Typically it is redeclared when multiple instances are running.
a4f00d5

This is going to be an issue for anybody that has a site using tgmpa in other plugins or themes .... is a major bug

Yup, needs to happen!

Contributor

Ok - I will look into this and try to get it merged in this week.

hi, i purchase "WooCommerce Product Configurator", use in theme "One" from ThemeForest, when i install the plugin i have this error:
Fatal error: Cannot redeclare tgmpa_load_bulk_installer() in /customers/0/1/6/maiorcasunglasses.com/httpd.www/wp-content/themes/one/framework/lib/class.tgm_plugin_activation.php on line 1692
what is the problem?
thank you

@maiorcasunglasses exactly what this pull request is all about.

Open that file, and add/change this:

function tgmpa_load_bulk_installer(){
...
}

to this:

if ( ! function_exists ('tgmpa_load_bulk_installer') ) {
    function tgmpa_load_bulk_installer(){
        ...
    }
}

But basically it means you have multiple plugin/theme using TGMPA and this bug affects both, so you may need to modify both files.

@maiorcasunglasses Hey. You misunderstood what I said. You need to direct the Author of your theme to this thread, as they need to make the update. I've already done so in the plugin.

Hi @thomasgriffin - Any chance we can get this sorted? I'm getting a lot of complaints, even though I have the fix implemented. It's now plugins that aren't aware of the issue conflicting with mine, and nothing I can do about it unless TGM is updated!

Appreciated

tripflex commented Aug 6, 2014

Still an issue getting people submitting bug reports daily about this ...

Why don't you ping Thomas on Skype, Twitter etc its obvious he doesn't read GitHub messages.

https://twitter.com/jthomasgriffin

tripflex commented Aug 6, 2014

For me it's only on older version of my plugin, since those versions I just renamed the function in my plugin so there isn't any issues.

I recommend everyone else who is having issues just change the function name to something else to prevent compatibility issues

And not gonna try that because last time I did with an issue I had with Soliloquy I never received a response, email or twitter, so not worth it :)

@thomasgriffin thomasgriffin added a commit that referenced this pull request Aug 7, 2014
@thomasgriffin thomasgriffin Fixes #206 and #207.
Prevents clashing if multiple TGM libraries are active at one time with
a proper function check.
3435b07
Contributor

I'm sorry guys - I don't receive notification emails for any of my Github repos. I've just pushed the fix for this and confirmed that it fixes the bug. So sorry for the delay.

@tripflex - I apologize if I haven't gotten back to you on any support request with a product. You can ping me on twitter @jthomasgriffin and I will make sure to get you taken care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment