Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix in vegan CRAN release 2.5-6 breaks reduce.matrix #85

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@jarioksa
Copy link
Contributor

@jarioksa jarioksa commented Sep 1, 2019

reduce.matrix() assumes that NA values are passed to vegdist,
but documented behaviour is that they are not accepted. Vegan
accepted these from version 2.5-1, and this bug was fixed in
2.5-6, but reduce.matrix() assumed the buggy behaviour. This
commit re-instates the old behaviour of reduce.matrix.

reduce.matrix() assumes that NA values are passed to vegdist,
but documented behaviour is that they are not accepted. Vegan
accepted these from version 2.5-1, and this bug was fixed in
2.5-6, but reduce.matrix() assumed the buggy behaviour. This
commit re-instates the old behaviour of reduce.matrix.
@codecov
Copy link

@codecov codecov bot commented Sep 1, 2019

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          62       62           
  Lines        3807     3807           
=======================================
  Hits         3678     3678           
  Misses        129      129
Impacted Files Coverage Δ
R/reduce.matrix.R 92.15% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94452e...7ac537d. Read the comment docs.

@TGuillerme
Copy link
Owner

@TGuillerme TGuillerme commented Sep 2, 2019

Hi Jari,

Thanks a lot for the fix! I've merged the pull request and will keep the updated vegdist na behavior in mind for next developments!

Cheers,
Thomas

@TGuillerme TGuillerme merged commit 5101b90 into TGuillerme:master Sep 2, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 96.61%)
Details
codecov/project 96.61% (+0%) compared to c94452e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.