Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbugfix in vegan CRAN release 2.5-6 breaks reduce.matrix #85
Conversation
reduce.matrix() assumes that NA values are passed to vegdist, but documented behaviour is that they are not accepted. Vegan accepted these from version 2.5-1, and this bug was fixed in 2.5-6, but reduce.matrix() assumed the buggy behaviour. This commit re-instates the old behaviour of reduce.matrix.
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 62 62
Lines 3807 3807
=======================================
Hits 3678 3678
Misses 129 129
Continue to review full report at Codecov.
|
|
Hi Jari, Thanks a lot for the fix! I've merged the pull request and will keep the updated Cheers, |
reduce.matrix() assumes that NA values are passed to vegdist,
but documented behaviour is that they are not accepted. Vegan
accepted these from version 2.5-1, and this bug was fixed in
2.5-6, but reduce.matrix() assumed the buggy behaviour. This
commit re-instates the old behaviour of reduce.matrix.