Revert "rename rollout_ids to group_ids"#2013
Merged
Merged
Conversation
This reverts commit a3c5462.
jingshenghang
pushed a commit
to jingshenghang/slime
that referenced
this pull request
Jun 9, 2026
Upstream THUDM#2013 reverted the group_id rename, so Sample no longer carries group_id (the field is rollout_id again) and the loss reducer plus the compact-rollout assertion in rollout.py key on rollout_id. Set rollout_id on the snapshot and main leaves so siblings from one trajectory aggregate as a single rollout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1984 as there is conflict to internal tools.