Addition of gflags #24

Closed
thinxer opened this Issue Mar 29, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@thinxer
Contributor

thinxer commented Mar 29, 2013

Hi all,

I have added gflags as a git submodule. I have tested it under Linux and it's okay. But I'm not sure if it's convenient for developers on other platforms. Should we keep it a submodule, or add the sources to our repo, or use CMake's ExternalProject_Add?

Anyway, please try to compile it on your platform: https://github.com/thinxer/saedb/tree/gflags

@wweic

This comment has been minimized.

Show comment Hide comment
@wweic

wweic Mar 29, 2013

Contributor

When I build this project, It says /Users/ChenWei/Documents/github/saedb/thirdparty/gflags, does not contain a CMakeLists.txt file..

Contributor

wweic commented Mar 29, 2013

When I build this project, It says /Users/ChenWei/Documents/github/saedb/thirdparty/gflags, does not contain a CMakeLists.txt file..

@thinxer

This comment has been minimized.

Show comment Hide comment
@thinxer

thinxer Mar 29, 2013

Contributor

git submodule update --init
On Mar 29, 2013 8:39 PM, "Wei Chen" notifications@github.com wrote:

When I build this project, It says /Users/ChenWei/Documents/github/saedb/thirdparty/gflags,
does not contain a CMakeLists.txt file..


Reply to this email directly or view it on GitHubhttps://github.com/THUKEG/saedb/issues/24#issuecomment-15639104
.

Contributor

thinxer commented Mar 29, 2013

git submodule update --init
On Mar 29, 2013 8:39 PM, "Wei Chen" notifications@github.com wrote:

When I build this project, It says /Users/ChenWei/Documents/github/saedb/thirdparty/gflags,
does not contain a CMakeLists.txt file..


Reply to this email directly or view it on GitHubhttps://github.com/THUKEG/saedb/issues/24#issuecomment-15639104
.

@wweic

This comment has been minimized.

Show comment Hide comment
@wweic

wweic Mar 29, 2013

Contributor

It's ok on Mac.

Contributor

wweic commented Mar 29, 2013

It's ok on Mac.

@thinxer thinxer closed this Jul 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment