Skip to content
This repository
Browse code

scsi: Silence unnecessary warnings about ioctl to partition

Sometimes, warnings about ioctls to partition happen often enough that they
form majority of the warnings in the kernel log and users complain. In some
cases warnings are about ioctls such as SG_IO so it's not good to get rid of
the warnings completely as they can ease debugging of userspace problems
when ioctl is refused.

Since I have seen warnings from lots of commands, including some proprietary
userspace applications, I don't think disallowing the ioctls for processes
with CAP_SYS_RAWIO will happen in the near future if ever. So lets just
stop warning for processes with CAP_SYS_RAWIO for which ioctl is allowed.

CC: Paolo Bonzini <pbonzini@redhat.com>
CC: James Bottomley <JBottomley@parallels.com>
CC: linux-scsi@vger.kernel.org
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information...
commit 6d9359280753d2955f86d6411047516a9431eb51 1 parent 76aaa51
Jan Kara authored June 15, 2012 axboe committed June 15, 2012

Showing 1 changed file with 4 additions and 1 deletion. Show diff stats Hide diff stats

  1. 5  block/scsi_ioctl.c
5  block/scsi_ioctl.c
@@ -721,11 +721,14 @@ int scsi_verify_blk_ioctl(struct block_device *bd, unsigned int cmd)
721 721
 		break;
722 722
 	}
723 723
 
  724
+	if (capable(CAP_SYS_RAWIO))
  725
+		return 0;
  726
+
724 727
 	/* In particular, rule out all resets and host-specific ioctls.  */
725 728
 	printk_ratelimited(KERN_WARNING
726 729
 			   "%s: sending ioctl %x to a partition!\n", current->comm, cmd);
727 730
 
728  
-	return capable(CAP_SYS_RAWIO) ? 0 : -ENOIOCTLCMD;
  731
+	return -ENOIOCTLCMD;
729 732
 }
730 733
 EXPORT_SYMBOL(scsi_verify_blk_ioctl);
731 734
 

0 notes on commit 6d93592

Please sign in to comment.
Something went wrong with that request. Please try again.