Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
tag: internal-2012-…
Commits on Jul 12, 2012
  1. @ariknem

    wl18xx: enable MIMO rates when connected as a MIMO STA

    ariknem authored
    Use this opportunity to consolidate the check for MIMO support into a
    separate function.
    
    Signed-off-by: Arik Nemtsov <arik@wizery.com>
Commits on Jul 11, 2012
  1. @yairs534 @ariknem

    wlcore: make usage of nla_put clearer

    yairs534 authored ariknem committed
    handle errors of nla_put() inside the if(nla_put...) {}
    
    This makes the code simpler and clearer because:
    we take advantage from the fact that we have only one nla_put
    in our routines (so no real need for goto label).
    this avoids ugly goto forward followed by goto backward.
    
    Signed-off-by: Yair Shapira <yair.shapira@ti.com>
  2. @yairs534 @ariknem

    wlcore/wl12xx: calibrator fem detect implementation

    yairs534 authored ariknem committed
    this completes the calibrator based fem detect logic in driver:
    driver starts (by calibrator) in plt_mode PLT_FEM_DETECT
    wlcore inits and starts plt on wl12xx
    wl12xx fetches fem number from firmware and stores it in wl->fem_manuf
    wl12xx immediatly returns (doesn't start radio, etc...)
    wlcore returns the fem_manuf to calibrator using WL1271_TM_ATTR_DATA
    plt_mode is stopped
    
    Signed-off-by: Yair Shapira <yair.shapira@ti.com>
  3. @yairs534 @ariknem

    wl18xx: disable calibrator based fem detect

    yairs534 authored ariknem committed
    bip calibration is not required in wl18xx. Therefore we
    disable also auto fem (using calibrator fem detect) mode.
    
    Signed-off-by: Yair Shapira <yair.shapira@ti.com>
  4. @yairs534 @ariknem

    wlcore: add plt_mode including new PLT_FEM_DETECT

    yairs534 authored ariknem committed
    add wl->plt_mode that is used to indicate different plt
    working modes: this will be used to implement calibrator side
    auto fem detection where driver asks firmware to detect
    the wlan fem radio type and returns it to calibrator.
    
    this is not implemented yet and plt_modes: PLT_ON and
    PLT_FEM_DETECT currently behave the same.
    
    Signed-off-by: Yair Shapira <yair.shapira@ti.com>
  5. @elp @ariknem

    wlcore: use basic rates for non-data packets

    elp authored ariknem committed
    After the latest mac80211 changes, the sta has
    the ap's sta pointer even before association.
    
    This cause the auth and assoc frames to be sent
    with the standard ap's rates, rather than the
    basic rates.
    
    Change the tx rate policy logic to use the regular
    ap rates only for data packets (so control and mgmt
    packets will be sent with basic rates)
    
    Signed-off-by: Eliad Peller <eliad@wizery.com>
  6. @jmberg @ariknem

    cfg80211: fix locking and lockdep complaints

    jmberg authored ariknem committed
    To call cfg80211_get_chan_state() we need to lock
    the wdev, so we need to lock the wdev_iter mutex
    in cfg80211_can_use_iftype_chan(). This needs to
    use nested locking for lockdep.
    
    Also, cfg80211_get_chan_state() doesn't actually
    use the rdev, so remove that completely including
    the lock assertion that isn't needed.
    
    Reported-by: Eliad Peller <eliad@wizery.com>
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Commits on Jul 10, 2012
  1. @ariknem

    wlcore: don't issue SLEEP_AUTH command during recovery

    ariknem authored
    During interface removal, don't adjust sleep_auth if we are during
    recovery. Since the FW is potentially dead we shouldn't talk to it.
    
    Reported-by: Yossi Wortzel <yossiw@ti.com>
    Signed-off-by: Arik Nemtsov <arik@wizery.com>
Commits on Jul 9, 2012
  1. @ariknem

    mac80211: fix invalid band deref building preq IEs

    ariknem authored
    The function building probe-request IEs does not validate the band is
    supported before dereferencing it. This can result in a panic when
    all bands are traversed, as done during sched-scan start.
    
    Warn when this happens and return an empty probe request. Also fix
    sched-scan to not waste memory on unsupported bands.
    
    Signed-off-by: Arik Nemtsov <arik@wizery.com>
Commits on Jul 8, 2012
  1. @ariknem

    wl18xx: fix bogus compile warning on cc config option

    ariknem authored
    Initialize val to 0, to remove the following warning with
    CONFIG_CC_OPTIMIZE_FOR_SIZE. The compiler used was gcc 4.4.1
    (Sourcery G++ Lite 2010q1-202).
    
    drivers/net/wireless/ti/wl18xx/io.c: In function 'wl18xx_top_reg_read':
    drivers/net/wireless/ti/wl18xx/io.c:57: warning: 'val' may be used uninitialized in this function
    
    Signed-off-by: Arik Nemtsov <arik@wizery.com>
  2. @igalc @ariknem

    wlcore: send EAPOLs using minimum basic rate for all roles

    igalc authored ariknem committed
    Send EAPOLs using minimum basic rate for AP, STA, p2p GO and Client.
    The patch fixes p2p connection issue with Realtek device in p2p
    certification test 5.1.13 (DEVUT reinvokes Persistent Group).
    
    Signed-off-by: Igal Chernobelsky <igalc@ti.com>
  3. @yairs534 @ariknem

    wl18xx: add support for ht_mode in conf.h

    yairs534 authored ariknem committed
    ht_mode added to wl18xx conf struct in order to support different modes
    from the configuration file, as well as module params, and by default
    (working without a conf file and/or no module params).
    the hack regarding conf.phy.low_band_component_type for each board
    is now explicitly handled after parsing module params.
    missing default values to wl18xx config added.
    fix string module params not to have defaults (so if empty, param
    can be taken from conf file).
    update conf version to 3.
    
    Signed-off-by: Yair Shapira <yair.shapira@ti.com>
    Signed-off-by: Ido Reis <idor@ti.com>
  4. @eyalsh @ariknem

    wlcore: don't re-configure wakeup conditions if not needed

    eyalsh authored ariknem committed
    suspend and resume callbacks configure wakeup conditions to the FW
    which may be different between suspend and resume.
    This feature is currently not utilized as both in suspend and resume
    FW wakeup every 1 DTIM. Avoid waking up the chip and doing the FW command
    unless there's an actual difference in the wakeup conditions.
    
    Signed-off-by: Eyal Shapira <eyal@wizery.com>
  5. @ariknem

    wl18xx: alloc conf.phy memory to ensure alignemnt

    ariknem authored
    We get DMA alignment trouble if the beginning of the conf.phy struct is
    not aligned to 4 bytes. Use kmemdup to ensure alignment.
    
    Signed-off-by: Arik Nemtsov <arik@wizery.com>
  6. @eyalsh

    mac80211: use legacy mode for all ACs

    eyalsh authored Luciano Coelho committed
    AVM FritzBox 7390 has a weird behaviour where once we enable
    U-APSD only on the VO AC it limits the rate of the packets
    it sends to 39Mbps and doesn't do AMPDU aggregation.
    This causes a big degradation in throughput obviously.
    It's important to note that this isn't related to PS and happens
    also when ACTIVE is forced. The traffic affected is sent in BE AC.
    Once legacy mode for all ACs is used the AP begins using higher rates
    as well as AMPDU aggregation which improves throughput significantly.
    
    In order to deal with this AP and potentially others switch to
    using legacy mode for all ACs by default.
    
    Signed-off-by: Eyal Shapira <eyal@wizery.com>
    Signed-off-by: Luciano Coelho <coelho@ti.com>
  7. @eyalsh

    mac80211: handle auth failure returned with unmatching auth algo

    eyalsh authored Luciano Coelho committed
    Some Netgear APs like WNAP210 have a quirk behavior when
    configured for WEP Shared. They send an auth response with algo
    SHARED and status code NOT_SUPPORTED_AUTH_ALG (13) when being
    sent a request made with auth algo OPEN. Enable such response to
    propagate to userspace instead of discarding it so wpa_s can
    reattempt to auth with SHARED.
    
    Reported-by: Noam Shaked <noams@ti.com>
    Signed-off-by: Eyal Shapira <eyal@wizery.com>
  8. Merge branch 'wl12xx-next'

    Luciano Coelho authored
  9. wlcore: fix a couple small memory leaks

    Dan Carpenter authored Luciano Coelho committed
    We should free "chunk" here before returning the error code.
    
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Luciano Coelho <coelho@ti.com>
  10. @ariknem

    wlcore: determine AP extra rates correctly

    ariknem authored Luciano Coelho committed
    Don't use the ht_mode module parameter for determining AP supported
    rates. We can rely on channel type, since HT40 won't be enabled if our
    HT cap doesn't support it.
    
    Enable MIMO only if there enough antennas, and rely on per-peer rate
    limitation to prevent IOPs.
    
    Signed-off-by: Arik Nemtsov <arik@wizery.com>
  11. @elp

    wlcore: check ssid length against the correct element

    elp authored Luciano Coelho committed
    commit 587cc28 ("wlcore: compare ssid_len before comparing
    ssids") introduced a new bug - the ssid length from the
    request struct was compared against the ssid length of
    another request, instead the one of the cmd.
    
    This might cause the sched scan request to fail
    (with -EINVAL) in many cases.
    
    Signed-off-by: Eliad Peller <eliad@wizery.com>
  12. @ariknem

    wl12xx/wl18xx: use a dynamic PS timeout of 1.5sec

    ariknem authored Luciano Coelho committed
    It seems some parties have bad user experience when smaller values
    are used. This should have little implications for power consumption,
    since traffic is bursty in nature.
    
    Signed-off-by: Arik Nemtsov <arik@wizery.com>
  13. @ariknem

    wlcore: define number of supported bands internally

    ariknem authored Luciano Coelho committed
    Avoid using the IEEE80211_NUM_BANDS constant for arrays sizes etc, as
    this can contain bands unsupported by the driver (e.g. 60Ghz). Use an
    internal constant to determine the number of bands.
    
    Signed-off-by: Arik Nemtsov <arik@wizery.com>
  14. @ariknem

    wlcore: don't set SDIO_FAILED flag when driver state is off

    ariknem authored Luciano Coelho committed
    If some IO read/write fails while the FW is not loaded, a recovery
    will not take place. This means the SDIO_FAILED flag will stay in place
    forever and prevent further read/writes.
    
    This can happen if a check for STATE_OFF was forgotten in some routine.
    
    Take this opportunity to rename the flag to IO_FAILED, since we support
    other buses as well.
    
    Reported-by: Ido Yariv <ido@wizery.com>
    Signed-off-by: Arik Nemtsov <arik@wizery.com>
  15. @yonid

    wlcore: change the wait for event mechanism

    yonid authored Luciano Coelho committed
    wlcore needs to wait for certain events for example
    for roc complete event. Usually the events are received
    from the FW very fast, therefore wlcore can poll with
    a short delay and if after a second the event was
    not received yet poll with a long (1-5 msec) delay.
    
    This implementation is similar to the sending of
    commands to the FW.
    
    Empirically the change reduced the wait for roc event
    from ~10-40msec to 100s of usecs.
    
    [replace udelay/msleep with usleep_range - Arik]
    
    Signed-off-by: Yoni Divinsky <yoni.divinsky@ti.com>
    Signed-off-by: Arik Nemtsov <arik@wizery.com>
  16. @gitido

    wlcore: Prevent processing of work items during op_stop

    gitido authored Luciano Coelho committed
    The interrupt line is disabled in op_stop using disable_irq. Since
    pending interrupts are synchronized, the mutex has to be released before
    disabling the interrupt to avoid a deadlock with the interrupt handler.
    
    In addition, the internal state of the driver is only set to 'off'
    after the interrupt is disabled. Otherwise, if an interrupt fires after
    the state is set but before the interrupt line is disabled, the
    interrupt handler will not be able to acknowledge the interrupt
    resulting in an interrupt storm.
    
    The driver's operations might be called during recovery. If these
    acquire the mutex after it was released by op_stop, but before the
    driver's state is changed, they may queue new work items instead of just
    failing. This is especially problematic in the case of scans, in which a
    new scan may be scheduled after all scan requests were cancelled.
    
    Signed-off-by: Ido Yariv <ido@wizery.com>
    Signed-off-by: Arik Nemtsov <arik@wizery.com>
  17. Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/gi…

    Luciano Coelho authored
    …t/linville/wireless-testing
Commits on Jul 6, 2012
  1. @linvjw
  2. @linvjw
  3. @linvjw

    Merge tag 'nfc-next-3.6-2' of git://git.kernel.org/pub/scm/linux/kern…

    linvjw authored
    …el/git/sameo/nfc-3.0
    
    2nd NFC 3.6 pull request
  4. @linvjw

    ath9k: Stop the BTCOEX timers before disabling BTCOEX

    Mohammed Shafi Shajakhan authored linvjw committed
    Its safe to stop the BTCOEX timers 'period_timer' and
    'no_stomp_timer' before disabling BTCOEX. These timers
    can call ath9k_hw_btcoex_enable (or) change the BT
    stomp type if they seem to be running after we had
    called ath9k_hw_btcoex_disable, which is obviously
    not correct.
    
    Cc: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
    Cc: Bala Shanmugam <bkamatch@qca.qualcomm.com>
    Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
  5. @linvjw

    ath9k: Fix MCI cleanup

    Mohammed Shafi Shajakhan authored linvjw committed
    We are doing MCI cleanup eventhough BTCOEX is not enabled
    via module parameter. This means we do ath_mci_cleanup
    though we skipped calling ath_mci_setup. Yet it does not
    causes any issues now  as we free the DMA buffer allocated
    only when it is allocated during ath_mci_setup.
    
    Reviewed-by: Bala Shanmugam <bkamatch@qca.qualcomm.com>
    Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
  6. @Zajec @linvjw

    bcma: use custom printing functions

    Zajec authored linvjw committed
    Having bus number printed makes it much easier to anaylze logs on
    systems with more buses. For example Netgear WNDR4500 has 3 AMBA buses
    in total, which makes standard log really messy.
    
    Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
  7. @Zajec @linvjw

    b43: N-PHY: fix RSSI calibration

    Zajec authored linvjw committed
    Specs were updated, change code to match it.
    
    Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
  8. @arend @linvjw

    brcmsmac: fix brcms_c_regd_init() which crashed after 11ad patch

    arend authored linvjw committed
    This patch fixes an OOPS in brcmsmac driver, which was introduced
    by the 11ad patch 'cfg80211: add 802.11ad (60gHz band) support'.
    The value IEEE80211_NUM_BANDS increased, which was used in the
    brcms_c_regd_init() function.
    
    Cc: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
    Cc: Johannes Berg <johannes.berg@intel.com>
    Acked-by: Seth Forshee <seth.forshee@canonical.com>
    Signed-off-by: Arend van Spriel <arend@broadcom.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
  9. @linvjw

    ath9k: enable support for AR9550

    Gabor Juhos authored linvjw committed
    Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
    Acked-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
Something went wrong with that request. Please try again.