Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Sep 28, 2011
  1. @davem330

    connector: add comm change event report to proc connector

    Vladimir Zapolskiy authored davem330 committed
    Add an event to monitor comm value changes of tasks.  Such an event
    becomes vital, if someone desires to control threads of a process in
    different manner.
    
    A natural characteristic of threads is its comm value, and helpfully
    application developers have an opportunity to change it in runtime.
    Reporting about such events via proc connector allows to fine-grain
    monitoring and control potentials, for instance a process control daemon
    listening to proc connector and following comm value policies can place
    specific threads to assigned cgroup partitions.
    
    It might be possible to achieve a pale partial one-shot likeness without
    this update, if an application changes comm value of a thread generator
    task beforehand, then a new thread is cloned, and after that proc
    connector listener gets the fork event and reads new thread's comm value
    from procfs stat file, but this change visibly simplifies and extends the
    matter.
    
    Signed-off-by: Vladimir Zapolskiy <vzapolskiy@gmail.com>
    Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
    Cc: David Miller <davem@davemloft.net>
    Signed-off-by: Andrew Morton <akpm@google.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Jul 29, 2011
  1. @utrace @davem330

    proc_fork_connector: a lockless ->real_parent usage is not safe

    utrace authored davem330 committed
    proc_fork_connector() uses ->real_parent lockless.  This is not safe if
    copy_process() was called with CLONE_THREAD or CLONE_PARENT, in this case
    the parent != current can go away at any moment.
    
    Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    Cc: Vladimir Zapolskiy <vzapolskiy@gmail.com>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Evgeniy Polyakov <zbr@ioremap.net>
    Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Jul 26, 2011
  1. @torvalds

    atomic: use <linux/atomic.h>

    Arun Sharma authored torvalds committed
    This allows us to move duplicated code in <asm/atomic.h>
    (atomic_inc_not_zero() for now) to <linux/atomic.h>
    
    Signed-off-by: Arun Sharma <asharma@fb.com>
    Reviewed-by: Eric Dumazet <eric.dumazet@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: David Miller <davem@davemloft.net>
    Cc: Eric Dumazet <eric.dumazet@gmail.com>
    Acked-by: Mike Frysinger <vapier@gentoo.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  2. @torvalds

    drivers/connector/cn_proc.c: remove unused local

    Andrew Morton authored torvalds committed
    Fix the warning
    
      drivers/connector/cn_proc.c: In function 'proc_ptrace_connector':
      drivers/connector/cn_proc.c:176: warning: unused variable 'tracer'
    
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Commits on Jul 22, 2011
  1. @torvalds

    Merge branch 'ptrace' of git://git.kernel.org/pub/scm/linux/kernel/gi…

    torvalds authored
    …t/oleg/misc
    
    * 'ptrace' of git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc: (39 commits)
      ptrace: do_wait(traced_leader_killed_by_mt_exec) can block forever
      ptrace: fix ptrace_signal() && STOP_DEQUEUED interaction
      connector: add an event for monitoring process tracers
      ptrace: dont send SIGSTOP on auto-attach if PT_SEIZED
      ptrace: mv send-SIGSTOP from do_fork() to ptrace_init_task()
      ptrace_init_task: initialize child->jobctl explicitly
      has_stopped_jobs: s/task_is_stopped/SIGNAL_STOP_STOPPED/
      ptrace: make former thread ID available via PTRACE_GETEVENTMSG after PTRACE_EVENT_EXEC stop
      ptrace: wait_consider_task: s/same_thread_group/ptrace_reparented/
      ptrace: kill real_parent_is_ptracer() in in favor of ptrace_reparented()
      ptrace: ptrace_reparented() should check same_thread_group()
      redefine thread_group_leader() as exit_signal >= 0
      do not change dead_task->exit_signal
      kill task_detached()
      reparent_leader: check EXIT_DEAD instead of task_detached()
      make do_notify_parent() __must_check, update the callers
      __ptrace_detach: avoid task_detached(), check do_notify_parent()
      kill tracehook_notify_death()
      make do_notify_parent() return bool
      ptrace: s/tracehook_tracer_task()/ptrace_parent()/
      ...
Commits on Jul 18, 2011
  1. @utrace

    connector: add an event for monitoring process tracers

    Vladimir Zapolskiy authored utrace committed
    This change adds a procfs connector event, which is emitted on every
    successful process tracer attach or detach.
    
    If some process connects to other one, kernelspace connector reports
    process id and thread group id of both these involved processes. On
    disconnection null process id is returned.
    
    Such an event allows to create a simple automated userspace mechanism
    to be aware about processes connecting to others, therefore predefined
    process policies can be applied to them if needed.
    
    Note, a detach signal is emitted only in case, if a tracer process
    explicitly executes PTRACE_DETACH request. In other cases like tracee
    or tracer exit detach event from proc connector is not reported.
    
    Signed-off-by: Vladimir Zapolskiy <vzapolskiy@gmail.com>
    Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
    Cc: David S. Miller <davem@davemloft.net>
    Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Commits on Jun 7, 2011
  1. @kattisrinivasan @gregkh

    Connector: Correctly set the error code in case of success when dispa…

    kattisrinivasan authored gregkh committed
    …tching receive callbacks
    
    The recent changes to the connector code introduced this bug where even
    when a callback was invoked, we would return an error resulting in
    double freeing of the skb. This patch fixes this bug.
    
    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
    Cc: stable <stable@kernel.org>  [.39]
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Commits on Apr 12, 2011
  1. @kaber @davem330

    connector: fix skb double free in cn_rx_skb()

    kaber authored davem330 committed
    When a skb is delivered to a registered callback, cn_call_callback()
    incorrectly returns -ENODEV after freeing the skb, causing cn_rx_skb()
    to free the skb a second time.
    
    Reported-by: Eric B Munson <emunson@mgebm.net>
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Tested-by: Eric B Munson <emunson@mgebm.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Mar 31, 2011
  1. @kaber @davem330

    connector: convert to synchronous netlink message processing

    kaber authored davem330 committed
    Commits 01a16b2 (netlink: kill eff_cap from struct netlink_skb_parms)
    and c53fa1e (netlink: kill loginuid/sessionid/sid members from struct
    netlink_skb_parms) removed some members from struct netlink_skb_parms
    that depend on the current context, all netlink users are now required
    to do synchronous message processing.
    
    connector however queues received messages and processes them in a work
    queue, which is not valid anymore. This patch converts connector to do
    synchronous message processing by invoking the registered callback handler
    directly from the netlink receive function.
    
    In order to avoid invoking the callback with connector locks held, a
    reference count is added to struct cn_callback_entry, the reference
    is taken when finding a matching callback entry on the device's queue_list
    and released after the callback handler has been invoked.
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Feb 23, 2011
  1. @JoePerches @gregkh

    connector: Convert char *name to const char *name

    JoePerches authored gregkh committed
    Allow more const declarations.
    
    Signed-off-by: Joe Perches <joe@perches.com>
    Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Commits on Dec 17, 2010
  1. connector: Use this_cpu operations

    Christoph Lameter authored Tejun Heo committed
    The patch was originally in the use cpuops patchset but it needs an
    inc_return and is therefore dependent on an extension of the cpu ops.
    Fixed up and verified that it compiles.
    
    get_seq can benefit from this_cpu_operations.  Address calculation is
    avoided and the increment is done using an xadd.
    
    Cc: Scott James Remnant <scott@ubuntu.com>
    Cc: Mike Frysinger <vapier@gentoo.org>
    Acked-by: H. Peter Anvin <hpa@zytor.com>
    Signed-off-by: Christoph Lameter <cl@linux.com>
    Signed-off-by: Tejun Heo <tj@kernel.org>
Commits on Dec 10, 2010
  1. @davem330

    connector: add module alias

    Stephen Hemminger authored davem330 committed
    Since connector can be built as a module and uses netlink socket
    to communicate. The module should have an alias to autoload when socket
    of NETLINK_CONNECTOR type is requested.
    
    Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
    Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Oct 24, 2010
  1. @davem330

    connector: remove lazy workqueue creation

    Tejun Heo authored davem330 committed
    Commit 1a5645b (connector: create connector workqueue only while
    needed once) implements lazy workqueue creation for connector
    workqueue.  With cmwq now in place, lazy workqueue creation doesn't
    make much sense while adding a lot of complexity.  Remove it and
    allocate an ordered workqueue during initialization.
    
    This also removes a call to flush_scheduled_work() which is deprecated
    and scheduled to be removed.
    
    Signed-off-by: Tejun Heo <tj@kernel.org>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Mar 30, 2010
  1. include cleanup: Update gfp.h and slab.h includes to prepare for brea…

    Tejun Heo authored
    …king implicit slab.h inclusion from percpu.h
    
    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files.  percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.
    
    percpu.h -> slab.h dependency is about to be removed.  Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability.  As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.
    
      http://userweb.kernel.org/~tj/misc/slabh-sweep.py
    
    The script does the followings.
    
    * Scan files for gfp and slab usages and update includes such that
      only the necessary includes are there.  ie. if only gfp is used,
      gfp.h, if slab is used, slab.h.
    
    * When the script inserts a new include, it looks at the include
      blocks and try to put the new include such that its order conforms
      to its surrounding.  It's put in the include block which contains
      core kernel includes, in the same order that the rest are ordered -
      alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
      doesn't seem to be any matching order.
    
    * If the script can't find a place to put a new include (mostly
      because the file doesn't have fitting include block), it prints out
      an error message indicating which .h file needs to be added to the
      file.
    
    The conversion was done in the following steps.
    
    1. The initial automatic conversion of all .c files updated slightly
       over 4000 files, deleting around 700 includes and adding ~480 gfp.h
       and ~3000 slab.h inclusions.  The script emitted errors for ~400
       files.
    
    2. Each error was manually checked.  Some didn't need the inclusion,
       some needed manual addition while adding it to implementation .h or
       embedding .c file was more appropriate for others.  This step added
       inclusions to around 150 files.
    
    3. The script was run again and the output was compared to the edits
       from #2 to make sure no file was left behind.
    
    4. Several build tests were done and a couple of problems were fixed.
       e.g. lib/decompress_*.c used malloc/free() wrappers around slab
       APIs requiring slab.h to be added manually.
    
    5. The script was run on all .h files but without automatically
       editing them as sprinkling gfp.h and slab.h inclusions around .h
       files could easily lead to inclusion dependency hell.  Most gfp.h
       inclusion directives were ignored as stuff from gfp.h was usually
       wildly available and often used in preprocessor macros.  Each
       slab.h inclusion directive was examined and added manually as
       necessary.
    
    6. percpu.h was updated not to include slab.h.
    
    7. Build test were done on the following configurations and failures
       were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
       distributed build env didn't work with gcov compiles) and a few
       more options had to be turned off depending on archs to make things
       build (like ipr on powerpc/64 which failed due to missing writeq).
    
       * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
       * powerpc and powerpc64 SMP allmodconfig
       * sparc and sparc64 SMP allmodconfig
       * ia64 SMP allmodconfig
       * s390 SMP allmodconfig
       * alpha SMP allmodconfig
       * um on x86_64 SMP allmodconfig
    
    8. percpu.h modifications were reverted so that it could be applied as
       a separate patch and serve as bisection point.
    
    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.
    
    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Commits on Feb 2, 2010
  1. @davem330

    connector: Delete buggy notification code.

    Evgeniy Polyakov authored davem330 committed
    On Tue, Feb 02, 2010 at 02:57:14PM -0800, Greg KH (gregkh@suse.de) wrote:
    > > There are at least two ways to fix it: using a big cannon and a small
    > > one. The former way is to disable notification registration, since it is
    > > not used by anyone at all. Second way is to check whether calling
    > > process is root and its destination group is -1 (kind of priveledged
    > > one) before command is dispatched to workqueue.
    > 
    > Well if no one is using it, removing it makes the most sense, right?
    > 
    > No objection from me, care to make up a patch either way for this?
    
    Getting it is not used, let's drop support for notifications about
    (un)registered events from connector.
    Another option was to check credentials on receiving, but we can always
    restore it without bugs if needed, but genetlink has a wider code base
    and none complained, that userspace can not get notification when some
    other clients were (un)registered.
    
    Kudos for Sebastian Krahmer <krahmer@suse.de>, who found a bug in the
    code.
    
    Signed-off-by: Evgeniy Polyakov <zbr@ioremap.net>
    Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Oct 6, 2009
  1. @bebarino @davem330

    connector: Fix incompatible pointer type warning

    bebarino authored davem330 committed
    Commit 7069331 (connector: Provide the sender's credentials to the
    callback, 2009-10-02) changed callbacks to take two arguments but missed
    this one.
    
    drivers/connector/cn_proc.c: In function ‘cn_proc_init’:
    drivers/connector/cn_proc.c:263: warning: passing argument 3 of
    ‘cn_add_callback’ from incompatible pointer type
    
    Signed-off-by: Stephen Boyd <bebarino@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Oct 2, 2009
  1. @davem330

    connector: Removed the destruct_data callback since it is always kfre…

    Philipp Reisner authored davem330 committed
    …e_skb()
    
    Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
    Acked-by: Lars Ellenberg <lars.ellenberg@linbit.com>
    Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  2. @davem330

    connector: Provide the sender's credentials to the callback

    Philipp Reisner authored davem330 committed
    Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
    Acked-by: Lars Ellenberg <lars.ellenberg@linbit.com>
    Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  3. @davem330

    connector: Keep the skb in cn_callback_data

    Philipp Reisner authored davem330 committed
    Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
    Acked-by: Lars Ellenberg <lars.ellenberg@linbit.com>
    Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Sep 23, 2009
  1. @torvalds

    proc connector: add event for process becoming session leader

    Scott James Remnant authored torvalds committed
    The act of a process becoming a session leader is a useful signal to a
    supervising init daemon such as Upstart.
    
    While a daemon will normally do this as part of the process of becoming a
    daemon, it is rare for its children to do so.  When the children do, it is
    nearly always a sign that the child should be considered detached from the
    parent and not supervised along with it.
    
    The poster-child example is OpenSSH; the per-login children call setsid()
    so that they may control the pty connected to them.  If the primary daemon
    dies or is restarted, we do not want to consider the per-login children
    and want to respawn the primary daemon without killing the children.
    
    This patch adds a new PROC_SID_EVENT and associated structure to the
    proc_event event_data union, it arranges for this to be emitted when the
    special PIDTYPE_SID pid is set.
    
    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: Scott James Remnant <scott@ubuntu.com>
    Acked-by: Matt Helsley <matthltc@us.ibm.com>
    Cc: Oleg Nesterov <oleg@tv-sign.ru>
    Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
    Acked-by: "David S. Miller" <davem@davemloft.net>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Commits on Jul 24, 2009
  1. @davem330

    Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/…

    davem330 authored
    …davem/net-2.6
    
    Conflicts:
    	drivers/net/wireless/iwmc3200wifi/netdev.c
    	net/wireless/scan.c
Commits on Jul 21, 2009
  1. @davem330

    connector: maintainer/mail update.

    Evgeniy Polyakov authored davem330 committed
    Signed-off-by: Evgeniy Polyakov <zbr@ioremap.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Jul 17, 2009
  1. @vapier @davem330

    connector: make callback argument type explicit

    vapier authored davem330 committed
    The connector documentation states that the argument to the callback
    function is always a pointer to a struct cn_msg, but rather than encode it
    in the API itself, it uses a void pointer everywhere.  This doesn't make
    much sense to encode the pointer in documentation as it prevents proper C
    type checking from occurring and can easily allow people to use the wrong
    pointer type.  So convert the argument type to an explicit struct cn_msg
    pointer.
    
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Jun 12, 2009
  1. @pavelmachek

    trivial: Kconfig: .ko is normally not included in module names

    pavelmachek authored Jiri Kosina committed
    .ko is normally not included in Kconfig help, make it consistent.
    
    Signed-off-by: Pavel Machek <pavel@ucw.cz>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Commits on Feb 3, 2009
  1. @fweisbec @davem330

    connector: create connector workqueue only while needed once

    fweisbec authored davem330 committed
    The netlink connector uses its own workqueue to relay the datas sent
    from userspace to the appropriate callback.  If you launch the test
    from Documentation/connector and change it a bit to send a high flow
    of data, you will see thousands of events coming to the "cqueue"
    workqueue by looking at the workqueue tracer.
    
    This flow of events can be sent very quickly. So, to not encumber the
    kevent workqueue and delay other jobs, the "cqueue" workqueue should
    remain.
    
    But this workqueue is pointless most of the time, it will always be
    created (assuming you have built it of course) although only
    developpers with specific needs will use it.
    
    So avoid this "most of the time useless task", this patch proposes to
    create this workqueue only when needed once.  The first jobs to be
    sent to connector callbacks will be sent to kevent while the "cqueue"
    thread creation will be scheduled to kevent too.
    
    The following jobs will continue to be scheduled to keventd until the
    cqueue workqueue is created, and then the rest of the jobs will
    continue to perform as usual, through this dedicated workqueue.
    
    Each time I tested this patch, only the first event was sent to
    keventd, the rest has been sent to cqueue which have been created
    quickly.
    
    Also, this patch fixes some trailing whitespaces on the connector files.
    
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Nov 13, 2008
  1. CRED: Use RCU to access another task's creds and to release a task's …

    David Howells authored James Morris committed
    …own creds
    
    Use RCU to access another task's creds and to release a task's own creds.
    This means that it will be possible for the credentials of a task to be
    replaced without another task (a) requiring a full lock to read them, and (b)
    seeing deallocated memory.
    
    Signed-off-by: David Howells <dhowells@redhat.com>
    Acked-by: James Morris <jmorris@namei.org>
    Acked-by: Serge Hallyn <serue@us.ibm.com>
    Signed-off-by: James Morris <jmorris@namei.org>
  2. CRED: Separate task security context from task_struct

    David Howells authored James Morris committed
    Separate the task security context from task_struct.  At this point, the
    security data is temporarily embedded in the task_struct with two pointers
    pointing to it.
    
    Note that the Alpha arch is altered as it refers to (E)UID and (E)GID in
    entry.S via asm-offsets.
    
    With comment fixes Signed-off-by: Marc Dionne <marc.c.dionne@gmail.com>
    
    Signed-off-by: David Howells <dhowells@redhat.com>
    Acked-by: James Morris <jmorris@namei.org>
    Acked-by: Serge Hallyn <serue@us.ibm.com>
    Signed-off-by: James Morris <jmorris@namei.org>
Commits on Jun 28, 2008
  1. @davem330

    CONNECTOR: add a proc entry to list connectors

    Li Zefan authored davem330 committed
    I got a problem when I wanted to check if the kernel supports process
    event connector, and It seems there's no way to do this check.
    
    At best I can check if the kernel supports connector or not, by looking
    into /proc/net/netlink, or maybe checking the return value of bind() to
    see if it's ENOENT.
    
    So it would be useful to add /proc/net/connector to list all supported
    connectors:
     # cat /proc/net/connector
     Name            ID
     connector       4294967295:4294967295
     cn_proc         1:1
     w1              3:1
    
    Changelog:
    - fix memory leak: s/seq_release/single_release
    - use spin_lock_bh instead of spin_lock_irqsave
    
    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    Acked-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Mar 24, 2008
  1. @davem330

    connector: convert to single-threaded workqueue

    Evgeniy Polyakov authored davem330 committed
    From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
    
    We don't need one cqueue thread for each CPU.  cqueue is used for
    receiving userspace datagrams, which are very rare and thus will
    happily live with a single queue.
    
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Feb 27, 2008
  1. @davem330

    CONNECTOR: make cn_already_initialized static

    Li Zefan authored davem330 committed
    It is used in connector.c only, so make it static.
    
    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Jan 28, 2008
  1. @davem330

    [NETNS]: Consolidate kernel netlink socket destruction.

    Denis V. Lunev authored davem330 committed
    Create a specific helper for netlink kernel socket disposal. This just
    let the code look better and provides a ground for proper disposal
    inside a namespace.
    
    Signed-off-by: Denis V. Lunev <den@openvz.org>
    Tested-by: Alexey Dobriyan <adobriyan@openvz.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  2. @davem330

    [CONNECTOR]: Cleanup struct cn_callback_entry

    Li Zefan authored davem330 committed
    - 'cb' is a fake struct member. In a previous patch struct cn_callback
    was renamed to cn_callback_id, so 'cb' should have been deleted at that
    time.
    
    - 'nls' isn't used and is redundant, we can retrieve this data through
    cn_callback_entry.pdev->nls.
    
    - 'seq' and 'group' should be u32, as they are declared to be u32 in
    other places.
    
    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  3. @davem330

    [CONNECTOR]: Cleanup struct cn_queue_dev

    Li Zefan authored davem330 committed
    Struct member netlink_groups is never used, and I don't see how it can
    be useful.
    
    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  4. @davem330

    [CONNECTOR]: clean up {,__}cn_rx_skb()

    Li Zefan authored davem330 committed
    - __cn_rx_skb() does nothing but calls cn_call_callback(), it doesn't
    check skb and msg sizes as the comment suggests, but cn_rx_skb() checks
    those sizes.
    
    - In cn_rx_skb() Local variable 'len' is not used. 'len' is probably
    intended to be passed to skb_pull(), but here skb_pull() is not needed,
    instead skb_free() is called.
    
    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  5. @davem330

    [CONNECTOR]: add a missing break in cn_netlink_send()

    Li Zefan authored davem330 committed
    Each entry in the list has a unique id, so just break out of the
    loop if the matched id is found.
    
    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Something went wrong with that request. Please try again.