feat: add required-workflows drift check (VERSION 1.9.5 -> 1.10.0)#62
Merged
Conversation
Adds RequiredWorkflowsCheck to the drift checker. The check reads required_workflows lists from drift-checker.config.json per repo type (cursor-plugin, mcp-server) and emits an error finding for each absent workflow. Policy is additive across config tiers (globals -> type -> repo); extra workflows are never flagged; skip_checks suppresses the check entirely. New files: - scripts/drift_check/checks/required_workflows.py - tests/test_required_workflows.py (9 tests, all pass) Changed files: - types.py: adds required_workflows to RepoConfig, present_workflows to RepoSnapshot, and tier-union logic in DriftConfig.resolve() - snapshot.py: discovers .github/workflows/ filenames into present_workflows - cli.py: wires RequiredWorkflowsCheck into the check pipeline - checks/__init__.py: exports RequiredWorkflowsCheck - standards/drift-checker.config.json: adds required_workflows arrays for cursor-plugin and mcp-server types On first run the check correctly flags two real gaps: - steam-mcp: missing stale.yml (known from the prior manual audit) - Mobile-App-Developer-Tools: missing stale.yml (caught by the check; missed by the manual audit) Both are follow-up fix: PRs in their respective repos. They are not suppressed here; the check is working as intended. file=None findings render cleanly in both markdown and gh-summary renderers (both use `if f.file else "-"`). Signed-off-by: fOuttaMyPaint <tmhospitalitystrategies@gmail.com> Signed-off-by: fOuttaMyPaint <154358121+TMHSDigital@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequiredWorkflowsCheckto the drift checker. For each repo type, the check reads therequired_workflowslist fromstandards/drift-checker.config.jsonand emits anerrorfinding for every absent workflow.skip_checkssuppresses the check entirely.New files
scripts/drift_check/checks/required_workflows.pytests/test_required_workflows.pyChanged files
scripts/drift_check/types.pyrequired_workflowsonRepoConfig;present_workflowsonRepoSnapshot; tier-union inDriftConfig.resolve()scripts/drift_check/snapshot.py.github/workflows/filenames intopresent_workflowsscripts/drift_check/cli.pyRequiredWorkflowsCheckinto the check pipelinescripts/drift_check/checks/__init__.pyRequiredWorkflowsCheckstandards/drift-checker.config.jsonrequired_workflowsarrays forcursor-pluginandmcp-servertypesKnown findings on first run
The check is shipped live (no suppression). On first run against the local fleet it correctly flags two real gaps:
steam-mcpstale.ymlMobile-App-Developer-Toolsstale.ymlThese are not suppressed. The check is working as designed; the findings are correct. The two fix: PRs (one per repo, each adding
stale.ymlfrom the scaffold template) will land after this PR merges so the detector ships before the fixes.Pre-merge checklist
python tests/test_required_workflows.py)python scripts/sync_from_registry.py --checkexits 0drift-checker.config.jsondiff shows only the newrequired_workflowskeys, no line-ending churnfile=Nonefindings render cleanly in markdown ("-") and gh-summary ("-") renderersstandards/ci-cd.mdchanges leaked into this branch (that is PR docs: clarify core vs optional workflows and add MCP-server variations to ci-cd.md #61)Test plan
steam-mcpandMobile-App-Developer-Toolsforstale.yml