Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQueryUI 1.12.1 incompatible with jQuery 3.1.1? #1

Open
cmb69 opened this issue Apr 22, 2017 · 2 comments
Open

jQueryUI 1.12.1 incompatible with jQuery 3.1.1? #1

cmb69 opened this issue Apr 22, 2017 · 2 comments

Comments

@cmb69
Copy link
Collaborator

@cmb69 cmb69 commented Apr 22, 2017

I'm using this configuration:

$plugin_cf['jquery']['version_core']="3.1.1";
$plugin_cf['jquery']['version_ui']="1.12.1";
$plugin_cf['jquery']['version_migrate']="jquery-migrate-3.0.0.js";
$plugin_cf['jquery']['load_migrate']="true";
$plugin_cf['jquery']['autoload']="true";
$plugin_cf['jquery']['autoload_libraries']="jQuery";

In jQuery4CMSimple_XH's back-end Chrome's (but not Firefox') error console reports:

JQMIGRATE: jQuery.expr[":"] is now jQuery.expr.pseudos
JQMIGRATE: jQuery.expr.filters is now jQuery.expr.pseudos

We probably can't do much about this, but we should document this potential incompatibility.

Maybe we should deprecate jQueryUI altogether? At least I'm switching away from it (already dropped it in Pagemanager 3: cmb69/pagemanager_xh#7).

@TN03
Copy link
Owner

@TN03 TN03 commented Apr 22, 2017

Hmm, for now we should document it. But where?

Maybe we should deprecate jQueryUI altogether?

Yes, maybe. And it seems to me that it's not really used in other plugins anyway.

@cmb69
Copy link
Collaborator Author

@cmb69 cmb69 commented Apr 22, 2017

Hmm, for now we should document it. But where?

The release announcement of XH 1.7.0beta1 would be a start (I've just made a note). Not sure which documentation users might consult – an extreme measure would be to add a note to the configuration help texts, which might be overkill, though.

Yes, maybe. And it seems to me that it's not really used in other plugins anyway.

Advancedform_XH is still using jQueryUI; I'm not sure whether Jerry also uses it in some plugins.

@cmb69 cmb69 mentioned this issue Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.