read empty list of frozen violations correctly (resolves #456)

Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
TNG · Oct 22, 2020 · c474630 · c474630
1 parent 8fdb631
commit c474630
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/archunit/src/main/java/com/tngtech/archunit/library/freeze/ViolationStoreFactory.java b/archunit/src/main/java/com/tngtech/archunit/library/freeze/ViolationStoreFactory.java
@@ -40,6 +40,7 @@
 import static com.google.common.io.Files.toByteArray;
 import static com.tngtech.archunit.base.ReflectionUtils.newInstanceOf;
 import static java.nio.charset.StandardCharsets.UTF_8;
+import static java.util.Collections.emptyList;
 
 class ViolationStoreFactory {
     static final String FREEZE_STORE_PROPERTY_NAME = "freeze.store";
@@ -183,6 +184,9 @@ public List<String> getViolations(ArchRule rule) {
 
         private List<String> readLines(String ruleDetailsFileName) {
             String violationsText = readStoreFile(ruleDetailsFileName);
+            if (violationsText.isEmpty()) {
+                return emptyList();
+            }
             List<String> lines = Splitter.on(UNESCAPED_LINE_BREAK_PATTERN).splitToList(violationsText);
             return unescape(lines);
         }

diff --git a/...it/src/test/java/com/tngtech/archunit/library/freeze/TextFileBasedViolationStoreTest.java b/...it/src/test/java/com/tngtech/archunit/library/freeze/TextFileBasedViolationStoreTest.java
@@ -79,6 +79,15 @@ public void reads_violations_of_single_rule_from_configured_folder() {
         assertThat(storedViolations).containsOnly("first violation", "second violation");
     }
 
+    @Test
+    public void reads_empty_list_of_violations() {
+        store.save(defaultRule(), ImmutableList.<String>of());
+
+        List<String> storedViolations = store.getViolations(defaultRule());
+
+        assertThat(storedViolations).isEmpty();
+    }
+
     @Test
     public void stores_violations_of_multiple_rules() {
         ArchRule firstRule = rule("first rule");