Allow regex matching on name and full name when providing a string pattern #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttern Signed-off-by: Thomas De Craemer <1496708+thomasdc@users.noreply.github.com>
Signed-off-by: Thomas De Craemer <1496708+thomasdc@users.noreply.github.com>
Contributor
Author
|
@fgather did you have time to review this PR? It's a rather trivial extension that would come in handy in our case. Implementation is similar to other places in the code base where you do regex matching. |
fgather
approved these changes
Aug 30, 2021
Contributor
|
Hi, I did, and I released it :) Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only extended the public interface a bit by adding an optional parameter
useRegularExpressionsto allow regex matching instead of onlycontains.Internals of the library remain unchanged.
Signed-off-by: Thomas De Craemer 1496708+thomasdc@users.noreply.github.com