Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support confidential clients in password grant flow #88

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

ostrya
Copy link
Collaborator

@ostrya ostrya commented Aug 2, 2021

Fixes the password grant part of #87.

Signed-off-by: Kai Helbig <kai.helbig@tngtech.com>

#87
if (authorization != null) {
try {
String usernamePassword =
new String(Base64.getDecoder().decode(authorization.replace("Basic ", "")));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default encoding?

Signed-off-by: Kai Helbig <kai.helbig@tngtech.com>
Signed-off-by: Kai Helbig <kai.helbig@tngtech.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.4% 84.4% Coverage
0.0% 0.0% Duplication

@ostrya ostrya merged commit 53f1fef into master Aug 4, 2021
@ostrya ostrya deleted the password-flow-with-confidential-client branch August 4, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants