Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver does not initialize indices of G0_iw properly #108

Closed
mravlje opened this issue Jul 24, 2014 · 6 comments
Closed

Solver does not initialize indices of G0_iw properly #108

mravlje opened this issue Jul 24, 2014 · 6 comments
Assignees

Comments

@mravlje
Copy link

mravlje commented Jul 24, 2014

Solver initialization creates Green's function indices as an empty list, which then prevents e.g. fit_tail acting on the GF to work properly.

@mravlje
Copy link
Author

mravlje commented Jul 24, 2014

The issue is related to branch 1.2dev.

@pseth
Copy link
Member

pseth commented Jul 24, 2014

See here for a minimal example: https://gist.github.com/pseth/168fed2220bb6b49c898

@tayral
Copy link
Member

tayral commented Jul 24, 2014

Hi Jernej,
which solver are you referring to? cthyb or cthyb_segment ? each of them
have their dedicated issue lists.

Thomas

Le 24/07/14 11:43, mravlje a écrit :

The issue is related to branch 1.2dev.


Reply to this email directly or view it on GitHub
#108 (comment).

@pseth
Copy link
Member

pseth commented Jul 24, 2014

This is for cthyb, but the problem is related to the indicesR that Michel looked at some time ago.

@pseth
Copy link
Member

pseth commented Jul 24, 2014

I should also add that the problem is resolved by defining a new gf explicitly with indices as follows:

g_w = GfImFreq(indices = [0], beta=beta)
for name, gblock in S.G_tau:
      g_w <<= g_w + 0.5 * (1.0/num_orbitals) * Fourier(gblock)
g_w.fit_tail([[[0.0,0.0,1.0]]],5,0.8*(2*1025)*3.14/beta,0.95*(2*1025)*3.14/beta)

@parcollet
Copy link
Member

The issue is that C++ created gf have by default an empty list of indices,
which is sort of strange indeed.
@mferrero : Why did we do this ?

parcollet pushed a commit that referenced this issue Jul 24, 2014
- Pb was that indices for gf where empty when constructed
  with default args from C++.
- changed into : make indices from the shape in the default
  case.
- also added more, simpler construction, for the indices
  to easy C++ construction.
@pseth pseth closed this as completed Oct 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants