New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking fix in Linux #200

Merged
merged 1 commit into from Jul 8, 2013

Conversation

Projects
None yet
2 participants
@zeehio
Copy link
Contributor

zeehio commented Jul 7, 2013

There is an undefined reference error in Linux (ubuntu raring, gcc-4.7, ld 2.23.2), due to a bad argument order.

Libraries should be in the right order in the command line in order to be able to link them properly [1].

In our case, libxml was appended to LINKFLAGS instead of parsed like the rest of the libraries (and therefore appended after the compiled objects), causing multiple "undefined reference to" errors.

On the other hand, I could not find FinishBuild method due to bad indentation (it was nested too much). I have fixed this error, although I don't understand why libpng and libjpeg should be bundled.

Any comment or suggestion will be appreciated.

[1] http://stackoverflow.com/questions/45135/linker-order-gcc

Linking fix: -lxml2 should be appended after the .o objects when link…
…ing to prevent undefined references (and not in LINKFLAGS). Also, FinishBuild was badly indented.
@TTimo

This comment has been minimized.

Copy link
Owner

TTimo commented Jul 8, 2013

They are bundled because a lot of linux systems don't package it, or package a newer version with a different ABI. Good fix though, thanks. Pulling in.

TTimo added a commit that referenced this pull request Jul 8, 2013

@TTimo TTimo merged commit aa185ce into TTimo:master Jul 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment