Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Faked TSFE does not set applicationType in request #2932

Closed
sascha-egerer opened this issue May 19, 2021 · 1 comment · Fixed by #2933
Closed

[BUG] Faked TSFE does not set applicationType in request #2932

sascha-egerer opened this issue May 19, 2021 · 1 comment · Fixed by #2933
Labels
BACKPORTABLE The changes SHOULD be backported

Comments

@sascha-egerer
Copy link
Collaborator

Describe the bug
When initializing the TSFE a TYPO3_REQUEST is also initialized.
A request must always have a applicationType attribute.
If no applicationType is given ApplicationType::fromRequest($GLOBALS['TYPO3_REQUEST'])
can't bee used and throws an exception.

To Reproduce
Call ApplicationType::fromRequest($GLOBALS['TYPO3_REQUEST']) on the
$GLOBALS['TYPO3_REQUEST'] that is initialized in
Classes/FrontendEnvironment/Tsfe.php

This happens for example in https://github.com/networkteam/sentry_client/blob/master/Classes/Client.php#L78

Expected behavior
A valid TYPO3_REQUEST should be initialized

Screenshots
If applicable, add screenshots to help explain your problem.

Used versions (please complete the following information):

  • TYPO3 Version: 10.4.16
  • EXT:solr Version: 11.0.3
@sascha-egerer sascha-egerer mentioned this issue May 19, 2021
Merged
@dkd-kaehm dkd-kaehm added the BACKPORTABLE The changes SHOULD be backported label May 27, 2021
@dkd-kaehm
Copy link
Collaborator

@sascha-egerer
Thanks for fixing that issue, we want a back port on release-11.0.x.

dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Jun 29, 2021
@dkd-kaehm
[BUGFIX:BP:11] Add missing applicationType to faked request
c3c71c0 
When initializing the TSFE a TYPO3_REQUEST is also initialized.
A request must always have a applicationType attribute.
If no applicationType is given `ApplicationType::fromRequest($GLOBALS['TYPO3_REQUEST'])`
can't bee used and throws an exception.

Fixes: TYPO3-Solr#2932
Ported from: TYPO3-Solr#2933
@dkd-kaehm dkd-kaehm mentioned this issue Jun 29, 2021
Merged
dkd-kaehm added a commit that referenced this issue Jul 2, 2021
@dkd-kaehm
[BUGFIX:BP:11] Add missing applicationType to faked request
19baedc 
When initializing the TSFE a TYPO3_REQUEST is also initialized.
A request must always have a applicationType attribute.
If no applicationType is given `ApplicationType::fromRequest($GLOBALS['TYPO3_REQUEST'])`
can't bee used and throws an exception.

Fixes: #2932
Ported from: #2933
@dkd-kaehm dkd-kaehm mentioned this issue Aug 18, 2021
Merged
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Aug 18, 2021
@dkd-kaehm
# Apache Solr for TYPO3 11.0.5 (TYPO3-Solr#2945)
8ba28e4 
This is a bugfix-only release that contains only a bugfixes

## New in this release:

* [BUGFIX] Delete documents for valid connections only [b99d7ad](TYPO3-Solr@b99d7ad) (TYPO3-Solr#2940)
* [TASK] Make Apache Solr v8.6+ compatible [12b9483](TYPO3-Solr@12b9483) (TYPO3-Solr#2938)
* [TASK] Bump Chart.js to v2.9.4 [4eacf89](TYPO3-Solr@4eacf89) (TYPO3-Solr#2946)
* [BUGFIX] use pages configuration as default #issue-2742 [d05f77e](TYPO3-Solr@d05f77e) (TYPO3-Solr#2742)
* [BUGFIX] ENV vars not handled correctly in site management module [d83c7d1](TYPO3-Solr@d83c7d1) (TYPO3-Solr#2576)
* [BUGFIX] Delete synonyms with URL special chars [5905fdb](TYPO3-Solr@5905fdb) (TYPO3-Solr#2336)
* [BUGFIX] Fix typo in CoreOptimizationModule/Index.html [3163d25](TYPO3-Solr@3163d25)
* [BUGFIX] Use correct html tags in templates [31e2d2c](TYPO3-Solr@31e2d2c) (TYPO3-Solr#2970)
* [BUGFIX] Add missing applicationType to faked request [19baedc](TYPO3-Solr@19baedc) (TYPO3-Solr#2932)
* [TASK] Add language cache to SiteUtility [6f7e4d1](TYPO3-Solr@6f7e4d1) (TYPO3-Solr#2908)
* [BUGFIX] writing errorHandling of site configuration [1ff6ca3](TYPO3-Solr@1ff6ca3) (TYPO3-Solr#2913)
* [TASK] Make language cache work with multi site setups  [b7a39c1](TYPO3-Solr@b7a39c1) (TYPO3-Solr#2986)
* [BUGFIX] set base uri to face frontend request [2c34ae9](TYPO3-Solr@2c34ae9) (TYPO3-Solr#2914)
* [BUGFIX] getRangeString(): check type before format() - call [a99275a](TYPO3-Solr@a99275a) (TYPO3-Solr#2942)
* [BUGFIX] Fix type error in UrlHelper [17f1653](TYPO3-Solr@17f1653) (TYPO3-Solr#2756)

Alternatively check following [link with all changes from 11.0.4 to 11.0.5](TYPO3-Solr/ext-solr@11.0.4...11.0.5).

# Contributors

* Achim Fritz
* Christoph Lehmann
* Daniel Koether
* Dmitry Dulepov
* Georg Ringer
* Markus Friedrich
* Markus Kobligk
* Peter, CyberForum e.V
* Rafael Kähm
* Sascha Egerer
* Sebastian Hofer
* Stefano Kowalke

---

How to Get Involved
===================

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on [GitHub](https://github.com/TYPO3-Solr/ext-solr)
* Ask or help or answer questions in our [Slack channel](https://typo3.slack.com/messages/ext-solr/)
* Provide patches through Pull Request or review and comment on existing [Pull Requests](https://github.com/TYPO3-Solr/ext-solr/pulls)
* Go to [www.typo3-solr.com](http://www.typo3-solr.com) or call [dkd](http://www.dkd.de) to sponsor the ongoing development of Apache Solr for TYPO3

Support us by becoming an EB partner:

https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:

+49 (0)69 - 2475218 0
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Aug 20, 2021
@dkd-kaehm
# Apache Solr for TYPO3 11.0.5 (TYPO3-Solr#2945)
44cb502 
This is a bugfix-only release that contains only a bugfixes

## New in this release:

* [BUGFIX] Delete documents for valid connections only [b99d7ad](TYPO3-Solr@b99d7ad) (TYPO3-Solr#2940)
* [TASK] Make Apache Solr v8.6+ compatible [12b9483](TYPO3-Solr@12b9483) (TYPO3-Solr#2938)
* [TASK] Bump Chart.js to v2.9.4 [4eacf89](TYPO3-Solr@4eacf89) (TYPO3-Solr#2946)
* [BUGFIX] use pages configuration as default #issue-2742 [d05f77e](TYPO3-Solr@d05f77e) (TYPO3-Solr#2742)
* [BUGFIX] ENV vars not handled correctly in site management module [d83c7d1](TYPO3-Solr@d83c7d1) (TYPO3-Solr#2576)
* [BUGFIX] Delete synonyms with URL special chars [5905fdb](TYPO3-Solr@5905fdb) (TYPO3-Solr#2336)
* [BUGFIX] Fix typo in CoreOptimizationModule/Index.html [3163d25](TYPO3-Solr@3163d25) (TYPO3-Solr#2965)
* [BUGFIX] Use correct html tags in templates [31e2d2c](TYPO3-Solr@31e2d2c) (TYPO3-Solr#2970)
* [BUGFIX] Add missing applicationType to faked request [19baedc](TYPO3-Solr@19baedc) (TYPO3-Solr#2932)
* [TASK] Add language cache to SiteUtility [6f7e4d1](TYPO3-Solr@6f7e4d1) (TYPO3-Solr#2908)
* [BUGFIX] writing errorHandling of site configuration [1ff6ca3](TYPO3-Solr@1ff6ca3) (TYPO3-Solr#2913)
* [TASK] Make language cache work with multi site setups  [b7a39c1](TYPO3-Solr@b7a39c1) (TYPO3-Solr#2986)
* [BUGFIX] set base uri to face frontend request [2c34ae9](TYPO3-Solr@2c34ae9) (TYPO3-Solr#2914)
* [BUGFIX] getRangeString(): check type before format() - call [a99275a](TYPO3-Solr@a99275a) (TYPO3-Solr#2942)
* [BUGFIX] Fix type error in UrlHelper [17f1653](TYPO3-Solr@17f1653) (TYPO3-Solr#2756)

Alternatively check following [link with all changes from 11.0.4 to 11.0.5](TYPO3-Solr/ext-solr@11.0.4...11.0.5).

# Contributors

* Achim Fritz
* Christoph Lehmann
* Daniel Koether
* Dmitry Dulepov
* Georg Ringer
* Markus Friedrich
* Markus Kobligk
* Peter, CyberForum e.V
* Rafael Kähm
* Sascha Egerer
* Sebastian Hofer
* Stefano Kowalke

---

How to Get Involved
===================

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on [GitHub](https://github.com/TYPO3-Solr/ext-solr)
* Ask or help or answer questions in our [Slack channel](https://typo3.slack.com/messages/ext-solr/)
* Provide patches through Pull Request or review and comment on existing [Pull Requests](https://github.com/TYPO3-Solr/ext-solr/pulls)
* Go to [www.typo3-solr.com](http://www.typo3-solr.com) or call [dkd](http://www.dkd.de) to sponsor the ongoing development of Apache Solr for TYPO3

Support us by becoming an EB partner:

https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:

+49 (0)69 - 2475218 0
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Aug 20, 2021
@dkd-kaehm
[TASK] Release 11.0.5 (TYPO3-Solr#2945)
cda57d5 
# Apache Solr for TYPO3 11.0.5 (TYPO3-Solr#2945)

This is a bugfix-only release that contains only a bugfixes

## New in this release:

* [BUGFIX] Delete documents for valid connections only [b99d7ad](TYPO3-Solr@b99d7ad) (TYPO3-Solr#2940)
* [TASK] Make Apache Solr v8.6+ compatible [12b9483](TYPO3-Solr@12b9483) (TYPO3-Solr#2938)
* [TASK] Bump Chart.js to v2.9.4 [4eacf89](TYPO3-Solr@4eacf89) (TYPO3-Solr#2946)
* [BUGFIX] use pages configuration as default #issue-2742 [d05f77e](TYPO3-Solr@d05f77e) (TYPO3-Solr#2742)
* [BUGFIX] ENV vars not handled correctly in site management module [d83c7d1](TYPO3-Solr@d83c7d1) (TYPO3-Solr#2576)
* [BUGFIX] Delete synonyms with URL special chars [5905fdb](TYPO3-Solr@5905fdb) (TYPO3-Solr#2336)
* [BUGFIX] Fix typo in CoreOptimizationModule/Index.html [3163d25](TYPO3-Solr@3163d25) (TYPO3-Solr#2965)
* [BUGFIX] Use correct html tags in templates [31e2d2c](TYPO3-Solr@31e2d2c) (TYPO3-Solr#2970)
* [BUGFIX] Add missing applicationType to faked request [19baedc](TYPO3-Solr@19baedc) (TYPO3-Solr#2932)
* [TASK] Add language cache to SiteUtility [6f7e4d1](TYPO3-Solr@6f7e4d1) (TYPO3-Solr#2908)
* [BUGFIX] writing errorHandling of site configuration [1ff6ca3](TYPO3-Solr@1ff6ca3) (TYPO3-Solr#2913)
* [TASK] Make language cache work with multi site setups  [b7a39c1](TYPO3-Solr@b7a39c1) (TYPO3-Solr#2986)
* [BUGFIX] set base uri to face frontend request [2c34ae9](TYPO3-Solr@2c34ae9) (TYPO3-Solr#2914)
* [BUGFIX] getRangeString(): check type before format() - call [a99275a](TYPO3-Solr@a99275a) (TYPO3-Solr#2942)
* [BUGFIX] Fix type error in UrlHelper [17f1653](TYPO3-Solr@17f1653) (TYPO3-Solr#2756)

Alternatively check following [link with all changes from 11.0.4 to 11.0.5](TYPO3-Solr/ext-solr@11.0.4...11.0.5).

# Contributors

* Achim Fritz
* Christoph Lehmann
* Daniel Koether
* Dmitry Dulepov
* Georg Ringer
* Markus Friedrich
* Markus Kobligk
* Peter, CyberForum e.V
* Rafael Kähm
* Sascha Egerer
* Sebastian Hofer
* Stefano Kowalke

---

How to Get Involved
===================

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on [GitHub](https://github.com/TYPO3-Solr/ext-solr)
* Ask or help or answer questions in our [Slack channel](https://typo3.slack.com/messages/ext-solr/)
* Provide patches through Pull Request or review and comment on existing [Pull Requests](https://github.com/TYPO3-Solr/ext-solr/pulls)
* Go to [www.typo3-solr.com](http://www.typo3-solr.com) or call [dkd](http://www.dkd.de) to sponsor the ongoing development of Apache Solr for TYPO3

Support us by becoming an EB partner:

https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:

+49 (0)69 - 2475218 0
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Aug 20, 2021
@dkd-kaehm
# Apache Solr for TYPO3 11.0.5 (TYPO3-Solr#2945)
d01f531 
This is a bugfix-only release that contains only a bugfixes

## New in this release:

* [BUGFIX] Delete documents for valid connections only [b99d7ad](TYPO3-Solr@b99d7ad) (TYPO3-Solr#2940)
* [TASK] Make Apache Solr v8.6+ compatible [12b9483](TYPO3-Solr@12b9483) (TYPO3-Solr#2938)
* [TASK] Bump Chart.js to v2.9.4 [4eacf89](TYPO3-Solr@4eacf89) (TYPO3-Solr#2946)
* [BUGFIX] use pages configuration as default #issue-2742 [d05f77e](TYPO3-Solr@d05f77e) (TYPO3-Solr#2742)
* [BUGFIX] ENV vars not handled correctly in site management module [d83c7d1](TYPO3-Solr@d83c7d1) (TYPO3-Solr#2576)
* [BUGFIX] Delete synonyms with URL special chars [5905fdb](TYPO3-Solr@5905fdb) (TYPO3-Solr#2336)
* [BUGFIX] Fix typo in CoreOptimizationModule/Index.html [3163d25](TYPO3-Solr@3163d25)
* [BUGFIX] Use correct html tags in templates [31e2d2c](TYPO3-Solr@31e2d2c) (TYPO3-Solr#2970)
* [BUGFIX] Add missing applicationType to faked request [19baedc](TYPO3-Solr@19baedc) (TYPO3-Solr#2932)
* [TASK] Add language cache to SiteUtility [6f7e4d1](TYPO3-Solr@6f7e4d1) (TYPO3-Solr#2908)
* [BUGFIX] writing errorHandling of site configuration [1ff6ca3](TYPO3-Solr@1ff6ca3) (TYPO3-Solr#2913)
* [TASK] Make language cache work with multi site setups  [b7a39c1](TYPO3-Solr@b7a39c1) (TYPO3-Solr#2986)
* [BUGFIX] set base uri to face frontend request [2c34ae9](TYPO3-Solr@2c34ae9) (TYPO3-Solr#2914)
* [BUGFIX] getRangeString(): check type before format() - call [a99275a](TYPO3-Solr@a99275a) (TYPO3-Solr#2942)
* [BUGFIX] Fix type error in UrlHelper [17f1653](TYPO3-Solr@17f1653) (TYPO3-Solr#2756)

Alternatively check following [link with all changes from 11.0.4 to 11.0.5](TYPO3-Solr/ext-solr@11.0.4...11.0.5).

# Contributors

* Achim Fritz
* Christoph Lehmann
* Daniel Koether
* Dmitry Dulepov
* Georg Ringer
* Markus Friedrich
* Markus Kobligk
* Peter, CyberForum e.V
* Rafael Kähm
* Sascha Egerer
* Sebastian Hofer
* Stefano Kowalke

---

How to Get Involved
===================

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on [GitHub](https://github.com/TYPO3-Solr/ext-solr)
* Ask or help or answer questions in our [Slack channel](https://typo3.slack.com/messages/ext-solr/)
* Provide patches through Pull Request or review and comment on existing [Pull Requests](https://github.com/TYPO3-Solr/ext-solr/pulls)
* Go to [www.typo3-solr.com](http://www.typo3-solr.com) or call [dkd](http://www.dkd.de) to sponsor the ongoing development of Apache Solr for TYPO3

Support us by becoming an EB partner:

https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:

+49 (0)69 - 2475218 0
dkd-kaehm added a commit that referenced this issue Aug 20, 2021
@dkd-kaehm
# Apache Solr for TYPO3 11.0.5 (#2945)
181948e 
This is a bugfix-only release that contains only a bugfixes

## New in this release:

* [BUGFIX] Delete documents for valid connections only [b99d7ad](b99d7ad) (#2940)
* [TASK] Make Apache Solr v8.6+ compatible [12b9483](12b9483) (#2938)
* [TASK] Bump Chart.js to v2.9.4 [4eacf89](4eacf89) (#2946)
* [BUGFIX] use pages configuration as default #issue-2742 [d05f77e](d05f77e) (#2742)
* [BUGFIX] ENV vars not handled correctly in site management module [d83c7d1](d83c7d1) (#2576)
* [BUGFIX] Delete synonyms with URL special chars [5905fdb](5905fdb) (#2336)
* [BUGFIX] Fix typo in CoreOptimizationModule/Index.html [3163d25](3163d25)
* [BUGFIX] Use correct html tags in templates [31e2d2c](31e2d2c) (#2970)
* [BUGFIX] Add missing applicationType to faked request [19baedc](19baedc) (#2932)
* [TASK] Add language cache to SiteUtility [6f7e4d1](6f7e4d1) (#2908)
* [BUGFIX] writing errorHandling of site configuration [1ff6ca3](1ff6ca3) (#2913)
* [TASK] Make language cache work with multi site setups  [b7a39c1](b7a39c1) (#2986)
* [BUGFIX] set base uri to face frontend request [2c34ae9](2c34ae9) (#2914)
* [BUGFIX] getRangeString(): check type before format() - call [a99275a](a99275a) (#2942)
* [BUGFIX] Fix type error in UrlHelper [17f1653](17f1653) (#2756)

Alternatively check following [link with all changes from 11.0.4 to 11.0.5](11.0.4...11.0.5).

# Contributors

* Achim Fritz
* Christoph Lehmann
* Daniel Koether
* Dmitry Dulepov
* Georg Ringer
* Markus Friedrich
* Markus Kobligk
* Peter, CyberForum e.V
* Rafael Kähm
* Sascha Egerer
* Sebastian Hofer
* Stefano Kowalke

---

How to Get Involved
===================

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on [GitHub](https://github.com/TYPO3-Solr/ext-solr)
* Ask or help or answer questions in our [Slack channel](https://typo3.slack.com/messages/ext-solr/)
* Provide patches through Pull Request or review and comment on existing [Pull Requests](https://github.com/TYPO3-Solr/ext-solr/pulls)
* Go to [www.typo3-solr.com](http://www.typo3-solr.com) or call [dkd](http://www.dkd.de) to sponsor the ongoing development of Apache Solr for TYPO3

Support us by becoming an EB partner:

https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:

+49 (0)69 - 2475218 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BACKPORTABLE The changes SHOULD be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Add missing applicationType to faked request sascha-egerer/ext-solr
2 participants
@sascha-egerer @dkd-kaehm