Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Extract access to sys_template to SystemTemplateRepository #1259

Merged
merged 1 commit into from Apr 10, 2017
Merged

[TASK] Extract access to sys_template to SystemTemplateRepository #1259

merged 1 commit into from Apr 10, 2017

Conversation

dkd-kaehm
Copy link
Collaborator

  • Added an integration test
  • Use it in ConfigurationPageResolver
  • Use doctrine to execute queries

resolves #1202

@dkd-kaehm dkd-kaehm force-pushed the TASK/Extract_sys_template_to_Repository branch 3 times, most recently from 4a653d2 to 5b26812 Compare April 7, 2017 21:56
@dkd-kaehm
Copy link
Collaborator Author

All Tests for CMS <8 are failed.

@dkd-kaehm dkd-kaehm force-pushed the TASK/Extract_sys_template_to_Repository branch from 5b26812 to 4a3500d Compare April 10, 2017 07:50
@timohund
Copy link
Contributor

@dkd-kaehm the tests with 7.6 fail, but thats ok, since we can drop the 7 support in dev-master. I'll remove TYPO3 7.x from the build matrix in another commit and then we can rerun the build and merge it.

@dkd-kaehm dkd-kaehm force-pushed the TASK/Extract_sys_template_to_Repository branch from 4a3500d to 735543b Compare April 10, 2017 10:57
@dkd-kaehm
[TASK] Extract access to sys_template to SystemTemplateRepository
102730c 
- Added an integration test
- Use it in ConfigurationPageResolver
- Use doctrine to execute queries

Fixes: TYPO3-Solr#1202
@dkd-kaehm dkd-kaehm force-pushed the TASK/Extract_sys_template_to_Repository branch from 735543b to 102730c Compare April 10, 2017 12:00
@timohund timohund self-requested a review April 10, 2017 13:44
@timohund timohund merged commit 86ebabd into TYPO3-Solr:master Apr 10, 2017
@dkd-kaehm dkd-kaehm deleted the TASK/Extract_sys_template_to_Repository branch June 8, 2017 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timohund timohund timohund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0 - Integrate Fluid Templating - Dr...
Development

Successfully merging this pull request may close these issues.

Extract access to sys_template to SystemTemplateRepository
2 participants
@dkd-kaehm @timohund