New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Flow/Neos specific classes to Neos namespace #49

Closed
Sebobo opened this Issue Sep 14, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@Sebobo
Collaborator

Sebobo commented Sep 14, 2016

  • Move classes to new namespace
  • Adapt cli commands to work with older Flow versions and new ones

@Sebobo Sebobo added the easy pick label Sep 14, 2016

@Sebobo Sebobo added this to the 2.0.0 stable release milestone Sep 14, 2016

@Sebobo Sebobo self-assigned this Sep 14, 2016

@Sebobo

This comment has been minimized.

Collaborator

Sebobo commented Jan 13, 2017

With the release of Neos 3 and Flow 4 this change is getting bigger.

@Sebobo Sebobo removed the easy pick label Jan 13, 2017

Sebobo added a commit to Sebobo/Surf that referenced this issue Jan 20, 2017

!!! TASK: Change namespace for Flow and Neos
Neos and Flow are not in the TYPO3 namespace
anymore.

This change is breaking as surf configurations
might override tasks which have moved to the
new namespace.

Related: TYPO3#49

Sebobo added a commit to Sebobo/Surf that referenced this issue Jan 20, 2017

!!! TASK: Make commands compatible with Flow 4.0
Flow 4.0 has now the Neos namespace and needs
a different fully qualified name for the commands.

This change is breaking as the default Flow version
is now set to 4.0 and configurations might need to
be adapted.

Resolves: TYPO3#49

Sebobo added a commit to Sebobo/Surf that referenced this issue Jan 20, 2017

[!!!][TASK] Change namespace for Flow and Neos
Neos and Flow are not in the TYPO3 namespace
anymore.

This change is breaking as surf configurations
might override tasks which have moved to the
new namespace.

Related: TYPO3#49

Sebobo added a commit to Sebobo/Surf that referenced this issue Jan 20, 2017

[!!!][TASK] Make commands compatible with Flow 4.0
Flow 4.0 has now the Neos namespace and needs
a different fully qualified name for the commands.

This change is breaking as the default Flow version
is now set to 4.0 and configurations might need to
be adapted.

Resolves: TYPO3#49

Sebobo added a commit to Sebobo/Surf that referenced this issue Jan 31, 2017

[!!!][TASK] Make commands compatible with Flow 4.0
Flow 4.0 has now the Neos namespace and needs
a different fully qualified name for the commands.

This change is breaking as the default Flow version
is now set to 4.0 and configurations might need to
be adapted.

Resolves: TYPO3#49

Sebobo added a commit to Sebobo/Surf that referenced this issue Jan 31, 2017

[!!!][TASK] Change namespace for Flow and Neos
Neos and Flow are not in the TYPO3 namespace
anymore.

This change is breaking as surf configurations
might override tasks which have moved to the
new namespace.

Related: TYPO3#49

Sebobo added a commit to Sebobo/Surf that referenced this issue Jan 31, 2017

[!!!][TASK] Make commands compatible with Flow 4.0
Flow 4.0 has now the Neos namespace and needs
a different fully qualified name for the commands.

This change is breaking as the default Flow version
is now set to 4.0 and configurations might need to
be adapted.

Resolves: TYPO3#49

Sebobo added a commit to Sebobo/Surf that referenced this issue Jan 31, 2017

[!!!][TASK] Change namespace for Flow and Neos
Neos and Flow are not in the TYPO3 namespace
anymore.

This change is breaking as surf configurations
might override tasks which have moved to the
new namespace.

Related: TYPO3#49

Sebobo added a commit to Sebobo/Surf that referenced this issue Jan 31, 2017

[!!!][TASK] Make commands compatible with Flow 4.0
Flow 4.0 has now the Neos namespace and needs
a different fully qualified name for the commands.

This change is breaking as the default Flow version
is now set to 4.0 and configurations might need to
be adapted.

Resolves: TYPO3#49

Sebobo added a commit to Sebobo/Surf that referenced this issue Jan 31, 2017

[!!!][TASK] Change namespace for Flow and Neos
Neos and Flow are not in the TYPO3 namespace
anymore.

This change is breaking as surf configurations
might override tasks which have moved to the
new namespace.

Related: TYPO3#49

Sebobo added a commit to Sebobo/Surf that referenced this issue Jan 31, 2017

[!!!][TASK] Make commands compatible with Flow 4.0
Flow 4.0 has now the Neos namespace and needs
a different fully qualified name for the commands.

This change is breaking as the default Flow version
is now set to 4.0 and configurations might need to
be adapted.

Resolves: TYPO3#49
@P34CH

This comment has been minimized.

P34CH commented Feb 10, 2017

Are there any plans yet when the new version of Surf shall be released to support deployment of Flow 4.0 applications?

How is deployment of these updated (Flow 4.0) applications possible in the meantime?

@Sebobo

This comment has been minimized.

Collaborator

Sebobo commented Feb 10, 2017

@P34CH I'm a bit busy right now to finalize the change but I hope to get it done soon.
But of course help is welcome!

For now you just need to replace two tasks to deploy Flow 4.0 right now:

// Surf doesn't support the new namespace yet so we have to do it by hand for now
$workflow
    ->removeTask('TYPO3\\Surf\\Task\\TYPO3\\Flow\\MigrateTask')
    ->removeTask('TYPO3\\Surf\\Task\\TYPO3\\Flow\\PublishResourcesTask');

$workflow->defineTask(
    'Xyz:Migrate',
    'TYPO3\\Surf\\Task\\TYPO3\\Flow\\RunCommandTask',
    [
        'command' => 'doctrine:migrate'
    ]
)->forStage('migrate', 'Xyz:Migrate');

$workflow->defineTask(
    'Xyz:PublishResources',
    'TYPO3\\Surf\\Task\\TYPO3\\Flow\\RunCommandTask',
    [
        'command' => 'resource:publish'
    ]
)->forStage('finalize', 'Xyz:PublishResources');
@P34CH

This comment has been minimized.

P34CH commented Feb 27, 2017

@Sebobo Thanks very much for your reply!

I'm still getting an error, after I added your snippet to my deployment script configuration:

Stage migrate
remotehost (Neos Flow) Xyz:Migrate
Warning: require(/home/httpd/vhosts/[...]/httpdocs/releases/20170227120113/Packages/Framework/TYPO3.Flow/Scripts/flow.php): failed to open stream: No such file or directory in /home/httpd/vhosts/[...]/httpdocs/releases/20170227120113/flow on line 18 Warning: require(/home/httpd/vhosts/[...]/httpdocs/releases/20170227120113/Packages/Framework/TYPO3.Flow/Scripts/flow.php): failed to open stream: No such file or directory in /home/httpd/vhosts/[...]/httpdocs/releases/20170227120113/flow on line 18 Fatal error: require(): Failed opening required '/home/httpd/vhosts/[...]/httpdocs/releases/20170227120113/Packages/Framework/TYPO3.Flow/Scripts/flow.php' (include_path='.:/usr/share/pear:/usr/share/php') in /home/httpd/vhosts/[...]/httpdocs/releases/20170227120113/flow on line 18

At first a create a new SimpleWorkflow. Afterwards I add your snipped, then I link this workflow to my deployment. Next I create a node, add this node to a new application and assign this application to the deployment as well.

Do you have any hints where/how I might fix this issue for deploying my Flow 4.0 application with surf?

@Sebobo

This comment has been minimized.

Collaborator

Sebobo commented Feb 27, 2017

@P34CH you should one time delete your surf cache on the target system.
composer install doesn't update the flow binary if you reuse the checked out project and don't recreate it for every build.
That should help I guess.

@Sebobo Sebobo closed this in #71 Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment