Skip to content

Commit

Permalink
[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Domain
Browse files Browse the repository at this point in the history
This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Releases: master, 10.4
Resolves: #92260
Change-Id: I9d0a9e546f0de5d12cf5dfdc4fe4c64550407e4f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65717
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
  • Loading branch information
alexanderschnitzler authored and bmack committed Sep 11, 2020
1 parent 1a9d117 commit 0725bfb
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -193,7 +193,7 @@ protected function init($show_hidden)
// versioning preview (that means we are online!)
$this->where_hid_del = ' AND ' . (string)$expressionBuilder->andX(
QueryHelper::stripLogicalOperatorPrefix(
$this->enableFields('pages', $show_hidden, ['fe_group' => true])
$this->enableFields('pages', (int)$show_hidden, ['fe_group' => true])
),
$expressionBuilder->neq('pages.doktype', self::DOKTYPE_RECYCLER)
);
Expand Down Expand Up @@ -938,7 +938,7 @@ protected function checkValidShortcutOfPage(array $page, $additionalWhereClause)
/**
* Get page shortcut; Finds the records pointed to by input value $SC (the shortcut value)
*
* @param int $shortcutFieldValue The value of the "shortcut" field from the pages record
* @param string $shortcutFieldValue The value of the "shortcut" field from the pages record
* @param int $shortcutMode The shortcut mode: 1 will select first subpage, 2 a random subpage, 3 the parent page; default is the page pointed to by $SC
* @param int $thisUid The current page UID of the page which is a shortcut
* @param int $iteration Safety feature which makes sure that the function is calling itself recursively max 20 times (since this function can find shortcuts to other shortcuts to other shortcuts...)
Expand Down

0 comments on commit 0725bfb

Please sign in to comment.