Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[!!!][TASK] Streamline TimeTracker global information
This patch removes unused variables: $GLOBALS['TYPO3_MISC']['microtime_BE_USER_start'] $GLOBALS['TYPO3_MISC']['microtime_BE_USER_end'] $GLOBALS['TYPO3_MISC']['microtime_end'] $GLOBALS['TYPO3_MISC']['microtime_start'] are replaced by properly using - TimeTracker->start() - TimeTracker->finish() (new method) to encapsulate the logic into the main method. Resolves: #88498 Releases: master Change-Id: I158e4b3aed002f688f117488cb0300c6523e791f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60769 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
- Loading branch information
1 parent
a6c60ad
commit 15e264d
Showing
9 changed files
with
139 additions
and
99 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
...n/Changelog/master/Breaking-88498-GlobalDataForTimeTrackerStatisticsRemoved.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
.. include:: ../../Includes.txt | ||
|
||
================================================================= | ||
Breaking: #88498 - Global data for TimeTracker statistics removed | ||
================================================================= | ||
|
||
See :issue:`88498` | ||
|
||
Description | ||
=========== | ||
|
||
The TimeTracker used some global variables to store :php:`microtime()` when a Frontend request was started | ||
and ended, as information for the Admin Panel and as HTTP Header, if debug mode is enabled for Frontend. | ||
|
||
This information is now encapsulated within the TimeTracker object, making the following global variables | ||
obsolete: | ||
|
||
* :php:`$GLOBALS['TYPO3_MISC']['microtime_start']` | ||
* :php:`$GLOBALS['TYPO3_MISC']['microtime_end']` | ||
* :php:`$GLOBALS['TYPO3_MISC']['microtime_BE_USER_start']` | ||
* :php:`$GLOBALS['TYPO3_MISC']['microtime_BE_USER_end']` | ||
|
||
This also results in having :php:`$GLOBALS['TYPO3_MISC']` to not be set anymore. | ||
|
||
|
||
Impact | ||
====== | ||
|
||
Accessing the global variables will trigger a PHP warning, as they do not exist anymore. | ||
|
||
|
||
Affected Installations | ||
====================== | ||
|
||
Any TYPO3 installation with an extension working with any of the global variables. | ||
|
||
|
||
Migration | ||
========= | ||
|
||
Remove the usages and either use the newly introduced `TimeTracker->finish()` to calculate data, or set | ||
your own variables, if microtime is needed. | ||
|
||
.. index:: PHP-API, FullyScanned |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters