diff --git a/typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php b/typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php index 349b3564d3ab..a51b3ad1e4d0 100644 --- a/typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php +++ b/typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php @@ -140,13 +140,13 @@ public function initializeArguments() public function render() { $this->setFormActionUri(); - if (strtolower($this->arguments['method']) === 'get') { + if (isset($this->arguments['method']) && strtolower($this->arguments['method']) === 'get') { $this->tag->addAttribute('method', 'get'); } else { $this->tag->addAttribute('method', 'post'); } - if ($this->arguments['novalidate'] === true) { + if (isset($this->arguments['novalidate']) && $this->arguments['novalidate'] === true) { $this->tag->addAttribute('novalidate', 'novalidate'); } @@ -156,13 +156,13 @@ public function render() $this->addFormFieldNamesToViewHelperVariableContainer(); $formContent = $this->renderChildren(); - if ($this->arguments['hiddenFieldClassName'] !== null) { + if (isset($this->arguments['hiddenFieldClassName']) && $this->arguments['hiddenFieldClassName'] !== null) { $content = LF . '
'; } else { $content = LF . '
'; } - $content .= $this->renderHiddenIdentityField($this->arguments['object'], $this->getFormObjectName()); + $content .= $this->renderHiddenIdentityField($this->arguments['object'] ?? null, $this->getFormObjectName()); $content .= $this->renderAdditionalIdentityFields(); $content .= $this->renderHiddenReferrerFields(); @@ -188,27 +188,27 @@ protected function setFormActionUri() if ($this->hasArgument('actionUri')) { $formActionUri = $this->arguments['actionUri']; } else { - $pageUid = (int)$this->arguments['pageUid'] > 0 ? (int)$this->arguments['pageUid'] : null; + $pageUid = (isset($this->arguments['pageUid']) && (int)$this->arguments['pageUid'] > 0) ? (int)$this->arguments['pageUid'] : null; $uriBuilder = $this->renderingContext->getControllerContext()->getUriBuilder(); $formActionUri = $uriBuilder ->reset() ->setTargetPageUid($pageUid) - ->setTargetPageType($this->arguments['pageType']) - ->setNoCache($this->arguments['noCache']) - ->setUseCacheHash(!$this->arguments['noCacheHash']) - ->setSection($this->arguments['section']) - ->setCreateAbsoluteUri($this->arguments['absolute']) - ->setArguments((array)$this->arguments['additionalParams']) - ->setAddQueryString($this->arguments['addQueryString']) - ->setAddQueryStringMethod($this->arguments['addQueryStringMethod']) - ->setArgumentsToBeExcludedFromQueryString((array)$this->arguments['argumentsToBeExcludedFromQueryString']) - ->setFormat($this->arguments['format']) + ->setTargetPageType($this->arguments['pageType'] ?? 0) + ->setNoCache($this->arguments['noCache'] ?? false) + ->setUseCacheHash(isset($this->arguments['noCacheHash']) ? !$this->arguments['noCacheHash'] : true) + ->setSection($this->arguments['section'] ?? '') + ->setCreateAbsoluteUri($this->arguments['absolute'] ?? false) + ->setArguments(isset($this->arguments['additionalParams']) ? (array)$this->arguments['additionalParams'] : []) + ->setAddQueryString($this->arguments['addQueryString'] ?? false) + ->setAddQueryStringMethod($this->arguments['addQueryStringMethod'] ?? null) + ->setArgumentsToBeExcludedFromQueryString(isset($this->arguments['argumentsToBeExcludedFromQueryString']) ? (array)$this->arguments['argumentsToBeExcludedFromQueryString'] : []) + ->setFormat($this->arguments['format'] ?? '') ->uriFor( - $this->arguments['action'], - $this->arguments['arguments'], - $this->arguments['controller'], - $this->arguments['extensionName'], - $this->arguments['pluginName'] + $this->arguments['action'] ?? null, + $this->arguments['arguments'] ?? [], + $this->arguments['controller'] ?? null, + $this->arguments['extensionName'] ?? null, + $this->arguments['pluginName'] ?? null ); $this->formActionUriArguments = $uriBuilder->getArguments(); } diff --git a/typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php b/typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php index 623fe0fff849..6478fb791fcc 100644 --- a/typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php +++ b/typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php @@ -1,4 +1,5 @@ mockExtensionService = $this->createMock(\TYPO3\CMS\Extbase\Service\ExtensionService::class); - $this->mockConfigurationManager = $this->createMock(\TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface::class); - $this->tagBuilder = $this->createMock(\TYPO3Fluid\Fluid\Core\ViewHelper\TagBuilder::class); + $this->mockExtensionService = $this->createMock(ExtensionService::class); + $this->mockConfigurationManager = $this->createMock(ConfigurationManagerInterface::class); + $this->tagBuilder = $this->createMock(TagBuilder::class); } /** @@ -87,7 +87,7 @@ protected function injectDependenciesIntoViewHelper(ViewHelperInterface $viewHel { $viewHelper->_set('configurationManager', $this->mockConfigurationManager); parent::injectDependenciesIntoViewHelper($viewHelper); - $hashService = $this->getMockBuilder(\TYPO3\CMS\Extbase\Security\Cryptography\HashService::class) + $hashService = $this->getMockBuilder(HashService::class) ->setMethods(['appendHmac']) ->getMock(); $hashService->expects($this->any())->method('appendHmac')->will($this->returnValue('')); @@ -102,13 +102,13 @@ protected function injectDependenciesIntoViewHelper(ViewHelperInterface $viewHel public function renderAddsObjectToViewHelperVariableContainer() { $formObject = new \stdClass(); - $viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, ['renderChildren', 'renderHiddenIdentityField', 'renderAdditionalIdentityFields', 'renderHiddenReferrerFields', 'renderHiddenSecuredReferrerField', 'renderRequestHashField', 'addFormObjectNameToViewHelperVariableContainer', 'addFieldNamePrefixToViewHelperVariableContainer', 'removeFormObjectNameFromViewHelperVariableContainer', 'removeFieldNamePrefixFromViewHelperVariableContainer', 'addFormFieldNamesToViewHelperVariableContainer', 'removeFormFieldNamesFromViewHelperVariableContainer', 'renderTrustedPropertiesField'], [], '', false); + $viewHelper = $this->getAccessibleMock(FormViewHelper::class, ['renderChildren', 'renderHiddenIdentityField', 'renderAdditionalIdentityFields', 'renderHiddenReferrerFields', 'renderHiddenSecuredReferrerField', 'renderRequestHashField', 'addFormObjectNameToViewHelperVariableContainer', 'addFieldNamePrefixToViewHelperVariableContainer', 'removeFormObjectNameFromViewHelperVariableContainer', 'removeFieldNamePrefixFromViewHelperVariableContainer', 'addFormFieldNamesToViewHelperVariableContainer', 'removeFormFieldNamesFromViewHelperVariableContainer', 'renderTrustedPropertiesField'], [], '', false); $this->injectDependenciesIntoViewHelper($viewHelper); $viewHelper->setArguments(['object' => $formObject]); - $this->viewHelperVariableContainer->add(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObject', $formObject); - $this->viewHelperVariableContainer->add(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'additionalIdentityProperties', []); - $this->viewHelperVariableContainer->remove(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObject'); - $this->viewHelperVariableContainer->remove(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'additionalIdentityProperties'); + $this->viewHelperVariableContainer->add(FormViewHelper::class, 'formObject', $formObject); + $this->viewHelperVariableContainer->add(FormViewHelper::class, 'additionalIdentityProperties', []); + $this->viewHelperVariableContainer->remove(FormViewHelper::class, 'formObject'); + $this->viewHelperVariableContainer->remove(FormViewHelper::class, 'additionalIdentityProperties'); $viewHelper->_set('tag', $this->tagBuilder); $viewHelper->render(); } @@ -119,11 +119,11 @@ public function renderAddsObjectToViewHelperVariableContainer() public function renderAddsObjectNameToTemplateVariableContainer() { $objectName = 'someObjectName'; - $viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, ['renderChildren', 'renderHiddenIdentityField', 'renderHiddenReferrerFields', 'renderHiddenSecuredReferrerField', 'renderRequestHashField', 'addFormObjectToViewHelperVariableContainer', 'addFieldNamePrefixToViewHelperVariableContainer', 'removeFormObjectFromViewHelperVariableContainer', 'removeFieldNamePrefixFromViewHelperVariableContainer', 'addFormFieldNamesToViewHelperVariableContainer', 'removeFormFieldNamesFromViewHelperVariableContainer', 'renderTrustedPropertiesField'], [], '', false); + $viewHelper = $this->getAccessibleMock(FormViewHelper::class, ['renderChildren', 'renderHiddenIdentityField', 'renderHiddenReferrerFields', 'renderHiddenSecuredReferrerField', 'renderRequestHashField', 'addFormObjectToViewHelperVariableContainer', 'addFieldNamePrefixToViewHelperVariableContainer', 'removeFormObjectFromViewHelperVariableContainer', 'removeFieldNamePrefixFromViewHelperVariableContainer', 'addFormFieldNamesToViewHelperVariableContainer', 'removeFormFieldNamesFromViewHelperVariableContainer', 'renderTrustedPropertiesField'], [], '', false); $this->injectDependenciesIntoViewHelper($viewHelper); $viewHelper->setArguments(['name' => $objectName]); - $this->viewHelperVariableContainer->add(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObjectName', $objectName); - $this->viewHelperVariableContainer->remove(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObjectName'); + $this->viewHelperVariableContainer->add(FormViewHelper::class, 'formObjectName', $objectName); + $this->viewHelperVariableContainer->remove(FormViewHelper::class, 'formObjectName'); $viewHelper->_set('tag', $this->tagBuilder); $viewHelper->render(); } @@ -134,11 +134,11 @@ public function renderAddsObjectNameToTemplateVariableContainer() public function formObjectNameArgumentOverrulesNameArgument() { $objectName = 'someObjectName'; - $viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, ['renderChildren', 'renderHiddenIdentityField', 'renderHiddenReferrerFields', 'renderRequestHashField', 'addFormObjectToViewHelperVariableContainer', 'addFieldNamePrefixToViewHelperVariableContainer', 'removeFormObjectFromViewHelperVariableContainer', 'removeFieldNamePrefixFromViewHelperVariableContainer', 'addFormFieldNamesToViewHelperVariableContainer', 'removeFormFieldNamesFromViewHelperVariableContainer', 'renderTrustedPropertiesField'], [], '', false); + $viewHelper = $this->getAccessibleMock(FormViewHelper::class, ['renderChildren', 'renderHiddenIdentityField', 'renderHiddenReferrerFields', 'renderRequestHashField', 'addFormObjectToViewHelperVariableContainer', 'addFieldNamePrefixToViewHelperVariableContainer', 'removeFormObjectFromViewHelperVariableContainer', 'removeFieldNamePrefixFromViewHelperVariableContainer', 'addFormFieldNamesToViewHelperVariableContainer', 'removeFormFieldNamesFromViewHelperVariableContainer', 'renderTrustedPropertiesField'], [], '', false); $this->injectDependenciesIntoViewHelper($viewHelper); $viewHelper->setArguments(['name' => 'formName', 'objectName' => $objectName]); - $this->viewHelperVariableContainer->add(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObjectName', $objectName); - $this->viewHelperVariableContainer->remove(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'formObjectName'); + $this->viewHelperVariableContainer->add(FormViewHelper::class, 'formObjectName', $objectName); + $this->viewHelperVariableContainer->remove(FormViewHelper::class, 'formObjectName'); $viewHelper->_set('tag', $this->tagBuilder); $viewHelper->render(); } @@ -148,7 +148,7 @@ public function formObjectNameArgumentOverrulesNameArgument() */ public function renderCallsRenderHiddenReferrerFields() { - $viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, ['renderChildren', 'renderRequestHashField', 'renderHiddenReferrerFields', 'renderTrustedPropertiesField'], [], '', false); + $viewHelper = $this->getAccessibleMock(FormViewHelper::class, ['renderChildren', 'renderRequestHashField', 'renderHiddenReferrerFields', 'renderTrustedPropertiesField'], [], '', false); $viewHelper->expects($this->once())->method('renderHiddenReferrerFields'); $this->injectDependenciesIntoViewHelper($viewHelper); $viewHelper->_set('tag', $this->tagBuilder); @@ -161,7 +161,7 @@ public function renderCallsRenderHiddenReferrerFields() public function renderCallsRenderHiddenIdentityField() { $object = new \stdClass(); - $viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, ['renderChildren', 'renderRequestHashField', 'renderHiddenReferrerFields', 'renderHiddenIdentityField', 'getFormObjectName', 'renderTrustedPropertiesField'], [], '', false); + $viewHelper = $this->getAccessibleMock(FormViewHelper::class, ['renderChildren', 'renderRequestHashField', 'renderHiddenReferrerFields', 'renderHiddenIdentityField', 'getFormObjectName', 'renderTrustedPropertiesField'], [], '', false); $this->injectDependenciesIntoViewHelper($viewHelper); $viewHelper->setArguments(['object' => $object]); $viewHelper->expects($this->atLeastOnce())->method('getFormObjectName')->will($this->returnValue('MyName')); @@ -175,7 +175,7 @@ public function renderCallsRenderHiddenIdentityField() */ public function renderCallsRenderAdditionalIdentityFields() { - $viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, ['renderChildren', 'renderRequestHashField', 'renderHiddenReferrerFields', 'renderAdditionalIdentityFields', 'renderTrustedPropertiesField'], [], '', false); + $viewHelper = $this->getAccessibleMock(FormViewHelper::class, ['renderChildren', 'renderRequestHashField', 'renderHiddenReferrerFields', 'renderAdditionalIdentityFields', 'renderTrustedPropertiesField'], [], '', false); $viewHelper->expects($this->once())->method('renderAdditionalIdentityFields'); $this->injectDependenciesIntoViewHelper($viewHelper); $viewHelper->_set('tag', $this->tagBuilder); @@ -187,15 +187,15 @@ public function renderCallsRenderAdditionalIdentityFields() */ public function renderWrapsHiddenFieldsWithDivForXhtmlCompatibilityWithRewrittenPropertyMapper() { - $viewHelper = $this->getAccessibleMock($this->buildAccessibleProxy(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class), ['renderChildren', 'renderHiddenIdentityField', 'renderAdditionalIdentityFields', 'renderHiddenReferrerFields', 'renderHiddenSecuredReferrerField', 'renderTrustedPropertiesField'], [], '', false); - $this->mvcPropertyMapperConfigurationService->_set('hashService', new \TYPO3\CMS\Extbase\Security\Cryptography\HashService()); + $viewHelper = $this->getAccessibleMock($this->buildAccessibleProxy(FormViewHelper::class), ['renderChildren', 'renderHiddenIdentityField', 'renderAdditionalIdentityFields', 'renderHiddenReferrerFields', 'renderHiddenSecuredReferrerField', 'renderTrustedPropertiesField'], [], '', false); + $this->mvcPropertyMapperConfigurationService->_set('hashService', new HashService()); $viewHelper->_set('mvcPropertyMapperConfigurationService', $this->mvcPropertyMapperConfigurationService); parent::injectDependenciesIntoViewHelper($viewHelper); $viewHelper->expects($this->once())->method('renderHiddenIdentityField')->will($this->returnValue('hiddenIdentityField')); $viewHelper->expects($this->once())->method('renderAdditionalIdentityFields')->will($this->returnValue('additionalIdentityFields')); $viewHelper->expects($this->once())->method('renderHiddenReferrerFields')->will($this->returnValue('hiddenReferrerFields')); $viewHelper->expects($this->once())->method('renderChildren')->will($this->returnValue('formContent')); - $expectedResult = chr(10) . '
' . 'hiddenIdentityFieldadditionalIdentityFieldshiddenReferrerFields' . chr(10) . '
' . chr(10) . 'formContent'; + $expectedResult = \chr(10) . '
' . 'hiddenIdentityFieldadditionalIdentityFieldshiddenReferrerFields' . \chr(10) . '
' . \chr(10) . 'formContent'; $this->tagBuilder->expects($this->once())->method('setContent')->with($expectedResult); $viewHelper->_set('tag', $this->tagBuilder); $viewHelper->render(); @@ -206,18 +206,18 @@ public function renderWrapsHiddenFieldsWithDivForXhtmlCompatibilityWithRewritten */ public function renderWrapsHiddenFieldsWithDivAndAnAdditionalClassForXhtmlCompatibilityWithRewrittenPropertyMapper() { - $viewHelper = $this->getMockBuilder($this->buildAccessibleProxy(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class)) + $viewHelper = $this->getMockBuilder($this->buildAccessibleProxy(FormViewHelper::class)) ->setMethods(['renderChildren', 'renderHiddenIdentityField', 'renderAdditionalIdentityFields', 'renderHiddenReferrerFields', 'renderHiddenSecuredReferrerField', 'renderTrustedPropertiesField']) ->disableOriginalConstructor() ->getMock(); - $this->mvcPropertyMapperConfigurationService->_set('hashService', new \TYPO3\CMS\Extbase\Security\Cryptography\HashService()); + $this->mvcPropertyMapperConfigurationService->_set('hashService', new HashService()); $viewHelper->_set('mvcPropertyMapperConfigurationService', $this->mvcPropertyMapperConfigurationService); parent::injectDependenciesIntoViewHelper($viewHelper); $viewHelper->expects($this->once())->method('renderHiddenIdentityField')->will($this->returnValue('hiddenIdentityField')); $viewHelper->expects($this->once())->method('renderAdditionalIdentityFields')->will($this->returnValue('additionalIdentityFields')); $viewHelper->expects($this->once())->method('renderHiddenReferrerFields')->will($this->returnValue('hiddenReferrerFields')); $viewHelper->expects($this->once())->method('renderChildren')->will($this->returnValue('formContent')); - $expectedResult = chr(10) . '' . chr(10) . 'formContent'; + $expectedResult = \chr(10) . '' . \chr(10) . 'formContent'; $this->tagBuilder->expects($this->once())->method('setContent')->with($expectedResult); $viewHelper->setArguments(['hiddenFieldClassName' => 'hidden']); $viewHelper->_set('tag', $this->tagBuilder); @@ -233,11 +233,11 @@ public function renderAdditionalIdentityFieldsFetchesTheFieldsFromViewHelperVari 'object1[object2]' => '', 'object1[object2][subobject]' => '' ]; - $this->viewHelperVariableContainer->exists(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'additionalIdentityProperties')->willReturn(true); - $this->viewHelperVariableContainer->get(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'additionalIdentityProperties')->willReturn($identityProperties); - $viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, ['renderChildren'], [], '', false); + $this->viewHelperVariableContainer->exists(FormViewHelper::class, 'additionalIdentityProperties')->willReturn(true); + $this->viewHelperVariableContainer->get(FormViewHelper::class, 'additionalIdentityProperties')->willReturn($identityProperties); + $viewHelper = $this->getAccessibleMock(FormViewHelper::class, ['renderChildren'], [], '', false); $this->injectDependenciesIntoViewHelper($viewHelper); - $expected = chr(10) . '' . chr(10) . ''; + $expected = \chr(10) . '' . \chr(10) . ''; $actual = $viewHelper->_call('renderAdditionalIdentityFields'); $viewHelper->_set('tag', $this->tagBuilder); $this->assertEquals($expected, $actual); @@ -248,7 +248,7 @@ public function renderAdditionalIdentityFieldsFetchesTheFieldsFromViewHelperVari */ public function renderHiddenReferrerFieldsAddCurrentControllerAndActionAsHiddenFields() { - $viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, ['dummy'], [], '', false); + $viewHelper = $this->getAccessibleMock(FormViewHelper::class, ['dummy'], [], '', false); $this->injectDependenciesIntoViewHelper($viewHelper); $this->request->getControllerExtensionName()->willReturn('extensionName'); $this->request->getControllerName()->willReturn('controllerName'); @@ -256,12 +256,12 @@ public function renderHiddenReferrerFieldsAddCurrentControllerAndActionAsHiddenF $this->request->getControllerVendorName()->willReturn('controllerVendorName'); $this->request->getArguments()->willReturn([]); $hiddenFields = $viewHelper->_call('renderHiddenReferrerFields'); - $expectedResult = chr(10) . '' - . chr(10) . '' - . chr(10) . '' - . chr(10) . '' - . chr(10) . '' - . chr(10) . '' . chr(10); + $expectedResult = \chr(10) . '' + . \chr(10) . '' + . \chr(10) . '' + . \chr(10) . '' + . \chr(10) . '' + . \chr(10) . '' . \chr(10); $viewHelper->_set('tag', $this->tagBuilder); $this->assertEquals($expectedResult, $hiddenFields); } @@ -272,11 +272,11 @@ public function renderHiddenReferrerFieldsAddCurrentControllerAndActionAsHiddenF public function renderAddsSpecifiedPrefixToTemplateVariableContainer() { $prefix = 'somePrefix'; - $viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, ['renderChildren', 'renderHiddenIdentityField', 'renderHiddenReferrerFields', 'renderRequestHashField', 'addFormFieldNamesToViewHelperVariableContainer', 'removeFormFieldNamesFromViewHelperVariableContainer', 'renderTrustedPropertiesField'], [], '', false); + $viewHelper = $this->getAccessibleMock(FormViewHelper::class, ['renderChildren', 'renderHiddenIdentityField', 'renderHiddenReferrerFields', 'renderRequestHashField', 'addFormFieldNamesToViewHelperVariableContainer', 'removeFormFieldNamesFromViewHelperVariableContainer', 'renderTrustedPropertiesField'], [], '', false); $this->injectDependenciesIntoViewHelper($viewHelper); $viewHelper->setArguments(['fieldNamePrefix' => $prefix]); - $this->viewHelperVariableContainer->add(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'fieldNamePrefix', $prefix); - $this->viewHelperVariableContainer->remove(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'fieldNamePrefix'); + $this->viewHelperVariableContainer->add(FormViewHelper::class, 'fieldNamePrefix', $prefix); + $this->viewHelperVariableContainer->remove(FormViewHelper::class, 'fieldNamePrefix'); $viewHelper->_set('tag', $this->tagBuilder); $viewHelper->render(); } @@ -287,13 +287,13 @@ public function renderAddsSpecifiedPrefixToTemplateVariableContainer() public function renderAddsDefaultFieldNamePrefixToTemplateVariableContainerIfNoPrefixIsSpecified() { $expectedPrefix = 'tx_someextension_someplugin'; - $viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, ['renderChildren', 'renderHiddenIdentityField', 'renderHiddenReferrerFields', 'renderRequestHashField', 'addFormFieldNamesToViewHelperVariableContainer', 'removeFormFieldNamesFromViewHelperVariableContainer', 'renderTrustedPropertiesField'], [], '', false); + $viewHelper = $this->getAccessibleMock(FormViewHelper::class, ['renderChildren', 'renderHiddenIdentityField', 'renderHiddenReferrerFields', 'renderRequestHashField', 'addFormFieldNamesToViewHelperVariableContainer', 'removeFormFieldNamesFromViewHelperVariableContainer', 'renderTrustedPropertiesField'], [], '', false); $this->mockExtensionService->expects($this->once())->method('getPluginNamespace')->with('SomeExtension', 'SomePlugin')->will($this->returnValue('tx_someextension_someplugin')); $viewHelper->_set('extensionService', $this->mockExtensionService); $this->injectDependenciesIntoViewHelper($viewHelper); $viewHelper->setArguments(['extensionName' => 'SomeExtension', 'pluginName' => 'SomePlugin']); - $this->viewHelperVariableContainer->add(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'fieldNamePrefix', $expectedPrefix); - $this->viewHelperVariableContainer->remove(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, 'fieldNamePrefix'); + $this->viewHelperVariableContainer->add(FormViewHelper::class, 'fieldNamePrefix', $expectedPrefix); + $this->viewHelperVariableContainer->remove(FormViewHelper::class, 'fieldNamePrefix'); $viewHelper->_set('tag', $this->tagBuilder); $viewHelper->render(); } @@ -301,7 +301,7 @@ public function renderAddsDefaultFieldNamePrefixToTemplateVariableContainerIfNoP /** * Data Provider for postProcessUriArgumentsForRequestHashWorks */ - public function argumentsForPostProcessUriArgumentsForRequestHash() + public function argumentsForPostProcessUriArgumentsForRequestHash(): array { return [ // simple values @@ -336,10 +336,12 @@ public function argumentsForPostProcessUriArgumentsForRequestHash() /** * @test * @dataProvider argumentsForPostProcessUriArgumentsForRequestHash + * @param $arguments + * @param $expectedResults */ public function postProcessUriArgumentsForRequestHashWorks($arguments, $expectedResults) { - $viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\FormViewHelper::class, ['dummy'], [], '', false); + $viewHelper = $this->getAccessibleMock(FormViewHelper::class, ['dummy'], [], '', false); $results = []; $viewHelper->_callRef('postProcessUriArgumentsForRequestHash', $arguments, $results); $this->assertEquals($expectedResults, $results);