From 1d71cf7342aabf2e0f70fa4ba616922a4674c611 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Uzna=C5=84ski?= Date: Sat, 17 Mar 2018 15:09:27 +0100 Subject: [PATCH] [TASK] Make AreaTest notice free Resolves: 84436 Releases: master Change-Id: Ie882198724aaa3d77f695e036599dee3a1211938 Reviewed-on: https://review.typo3.org/56308 Tested-by: TYPO3com Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn --- .../Unit/Imaging/ImageManipulation/AreaTest.php | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/AreaTest.php b/typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/AreaTest.php index d9fb5d2121f1..ff0a56dd1b70 100644 --- a/typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/AreaTest.php +++ b/typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/AreaTest.php @@ -23,15 +23,10 @@ class AreaTest extends UnitTestCase { - /** - * Subject is not notice free, disable E_NOTICES - */ - protected static $suppressNotices = true; - /** * @test */ - public function makeRelativeToFileReducesSizes() + public function makeRelativeToFileReducesSizes(): void { $imageArea = new Area(50.0, 50.0, 100.0, 100.0); $imageFixture = new File( @@ -49,7 +44,7 @@ public function makeRelativeToFileReducesSizes() $this->assertSame($expectedResult, $relativeArea->asArray()); } - public function applyRatioRestrictsAreaToRespectRatioDataProvider() + public function applyRatioRestrictsAreaToRespectRatioDataProvider(): array { return [ [ @@ -77,7 +72,7 @@ public function applyRatioRestrictsAreaToRespectRatioDataProvider() * @test * @dataProvider applyRatioRestrictsAreaToRespectRatioDataProvider */ - public function applyRatioRestrictsAreaToRespectRatio(array $areaSize, $ratio) + public function applyRatioRestrictsAreaToRespectRatio(array $areaSize, $ratio): void { $area = new Area(...$areaSize); $ratioFixture = new Ratio('dummy', 'dummy', $ratio); @@ -88,7 +83,7 @@ public function applyRatioRestrictsAreaToRespectRatio(array $areaSize, $ratio) /** * @test */ - public function applyRatioDoesNothingForFreeRatio() + public function applyRatioDoesNothingForFreeRatio(): void { $area = new Area(0.1, 0.1, 0.2, 0.4); $ratioFixture = new Ratio('dummy', 'dummy', 0.0);