From 33ed62bfb030e549e29a058a2f96cf1c50549b09 Mon Sep 17 00:00:00 2001 From: Christian Kuhn Date: Thu, 20 Dec 2018 23:07:25 +0100 Subject: [PATCH] [!!!][TASK] Remove deprecated code from various controllers Drop deprecated properties and methods from various backend controllers. Resolves: #87253 Releases: master Change-Id: I7a4bf179bffbdce4843cabf0efaa08a7a813808b Reviewed-on: https://review.typo3.org/59252 Tested-by: TYPO3com Reviewed-by: Benni Mack Tested-by: Benni Mack Reviewed-by: Georg Ringer Tested-by: Georg Ringer --- .../Classes/Controller/BackendController.php | 10 -- .../FileSystemNavigationFrameController.php | 60 +------- .../Classes/Controller/LoginController.php | 25 ---- .../Classes/Controller/LogoutController.php | 11 -- .../Controller/NewRecordController.php | 135 +----------------- .../Controller/UserSettingsController.php | 70 ++------- ...g-87193-DeprecatedFunctionalityRemoved.rst | 36 +++++ .../Php/MethodCallMatcher.php | 3 + .../Php/PropertyProtectedMatcher.php | 18 +++ .../Classes/RecordList/DatabaseRecordList.php | 1 - 10 files changed, 74 insertions(+), 295 deletions(-) diff --git a/typo3/sysext/backend/Classes/Controller/BackendController.php b/typo3/sysext/backend/Classes/Controller/BackendController.php index 1ff6aaeb31cc..c82ab8ba33e4 100644 --- a/typo3/sysext/backend/Classes/Controller/BackendController.php +++ b/typo3/sysext/backend/Classes/Controller/BackendController.php @@ -20,7 +20,6 @@ use TYPO3\CMS\Backend\Routing\UriBuilder; use TYPO3\CMS\Backend\Toolbar\ToolbarItemInterface; use TYPO3\CMS\Backend\Utility\BackendUtility; -use TYPO3\CMS\Core\Compatibility\PublicMethodDeprecationTrait; use TYPO3\CMS\Core\Configuration\ExtensionConfiguration; use TYPO3\CMS\Core\Database\ConnectionPool; use TYPO3\CMS\Core\Database\Query\Restriction\BackendWorkspaceRestriction; @@ -41,15 +40,6 @@ */ class BackendController { - use PublicMethodDeprecationTrait; - - /** - * @var array - */ - private $deprecatedPublicMethods = [ - 'render' => 'Using BackendController::render() is deprecated and will not be possible anymore in TYPO3 v10.0.', - ]; - /** * @var string */ diff --git a/typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php b/typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php index a21dea3c3c9e..608e441500cb 100644 --- a/typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php +++ b/typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php @@ -22,7 +22,6 @@ use TYPO3\CMS\Backend\Template\ModuleTemplate; use TYPO3\CMS\Backend\Tree\View\ElementBrowserFolderTreeView; use TYPO3\CMS\Core\Authentication\BackendUserAuthentication; -use TYPO3\CMS\Core\Compatibility\PublicPropertyDeprecationTrait; use TYPO3\CMS\Core\Http\HtmlResponse; use TYPO3\CMS\Core\Http\JsonResponse; use TYPO3\CMS\Core\Imaging\Icon; @@ -38,20 +37,6 @@ */ class FileSystemNavigationFrameController { - use PublicPropertyDeprecationTrait; - - /** - * Properties which have been moved to protected status from public - * - * @var array - */ - protected $deprecatedPublicProperties = [ - 'content' => 'Using $content of class FileSystemNavigationFrameController from the outside is discouraged, as this variable is only used for internal storage.', - 'foldertree' => 'Using $foldertree of class FileSystemNavigationFrameController from the outside is discouraged, as this variable is only used for internal storage.', - 'currentSubScript' => 'Using $currentSubScript of class FileSystemNavigationFrameController from the outside is discouraged, as this variable is only used for internal storage.', - 'cMR' => 'Using $cMR of class FileSystemNavigationFrameController from the outside is discouraged, as this variable is only used for internal storage.', - ]; - /** * Content accumulates in this variable. * @@ -86,24 +71,13 @@ class FileSystemNavigationFrameController */ protected $moduleTemplate; - /** - * Constructor - */ - public function __construct() - { - // @deprecated since TYPO3 v9, will be obsolete in TYPO3 v10.0 with removal of init() - $request = $GLOBALS['TYPO3_REQUEST']; - $GLOBALS['SOBE'] = $this; - // @deprecated since TYPO3 v9, will be moved out of __construct() in TYPO3 v10.0 - $this->init($request); - } - /** * @param ServerRequestInterface $request the current request * @return ResponseInterface the response with the content */ public function mainAction(ServerRequestInterface $request): ResponseInterface { + $this->init($request); $this->initializePageTemplate(); $this->renderFolderTree($request); return new HtmlResponse($this->content); @@ -118,6 +92,7 @@ public function mainAction(ServerRequestInterface $request): ResponseInterface */ public function ajaxExpandCollapse(ServerRequestInterface $request): ResponseInterface { + $this->init($request); $tree = $this->foldertree->getBrowsableTree(); if ($this->foldertree->getAjaxStatus() === false) { return new JsonResponse(null, 500); @@ -130,14 +105,8 @@ public function ajaxExpandCollapse(ServerRequestInterface $request): ResponseInt * * @param ServerRequestInterface $request the current request */ - protected function init(ServerRequestInterface $request = null) + protected function init(ServerRequestInterface $request) { - if ($request === null) { - // Method signature in TYPO3 v10.0: protected function init(ServerRequestInterface $request) - trigger_error('FileSystemNavigationFrameController->init() will be set to protected in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - $request = $GLOBALS['TYPO3_REQUEST']; - } - $this->moduleTemplate = GeneralUtility::makeInstance(ModuleTemplate::class); $parsedBody = $request->getParsedBody(); @@ -172,18 +141,6 @@ protected function init(ServerRequestInterface $request = null) } } - /** - * initialization for the visual parts of the class - * Use template rendering only if this is a non-AJAX call - * - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function initPage() - { - trigger_error('FileSystemNavigationFrameController->initPage() will be replaced by protected method initializePageTemplate() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - $this->initializePageTemplate(); - } - /** * Initialization for the visual parts of the class * Use template rendering only if this is a non-AJAX call @@ -233,17 +190,6 @@ function jumpTo(id, linkObj, highlightID, bank) { ); } - /** - * Main function, rendering the folder tree - * - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function main() - { - trigger_error('FileSystemNavigationFrameController->main() will be replaced by protected method renderFolderTree() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - $this->renderFolderTree($GLOBALS['TYPO3_REQUEST']); - } - /** * Main function, rendering the folder tree * diff --git a/typo3/sysext/backend/Classes/Controller/LoginController.php b/typo3/sysext/backend/Classes/Controller/LoginController.php index 821fa86eae0c..d17ff286a3ec 100644 --- a/typo3/sysext/backend/Classes/Controller/LoginController.php +++ b/typo3/sysext/backend/Classes/Controller/LoginController.php @@ -171,19 +171,6 @@ public function refreshAction(ServerRequestInterface $request): ResponseInterfac return new HtmlResponse($this->createLoginLogoutForm($request)); } - /** - * Main function - creating the login/logout form - * - * @throws Exception - * @return string The content to output - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function main(): string - { - trigger_error('LoginController->main() will be replaced by protected method createLoginLogoutForm() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - return $this->createLoginLogoutForm($GLOBALS['TYPO3_REQUEST']); - } - /** * Main function - creating the login/logout form * @@ -193,7 +180,6 @@ public function main(): string */ protected function createLoginLogoutForm(ServerRequestInterface $request): string { - /** @var PageRenderer $pageRenderer */ $pageRenderer = GeneralUtility::makeInstance(PageRenderer::class); $pageRenderer->loadRequireJsModule('TYPO3/CMS/Backend/Login'); @@ -375,17 +361,6 @@ protected function checkRedirect(ServerRequestInterface $request): void } } - /** - * Making interface selector - * - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function makeInterfaceSelectorBox(): void - { - trigger_error('LoginController->makeInterfaceSelectorBox() will be replaced by protected method makeInterfaceSelector() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - $this->makeInterfaceSelector($GLOBALS['TYPO3_REQUEST']); - } - /** * Making interface selector * @param ServerRequestInterface $request diff --git a/typo3/sysext/backend/Classes/Controller/LogoutController.php b/typo3/sysext/backend/Classes/Controller/LogoutController.php index c5b0f37787da..d5bd1ac7eaae 100644 --- a/typo3/sysext/backend/Classes/Controller/LogoutController.php +++ b/typo3/sysext/backend/Classes/Controller/LogoutController.php @@ -50,17 +50,6 @@ public function logoutAction(ServerRequestInterface $request): ResponseInterface return new RedirectResponse(GeneralUtility::locationHeaderUrl($redirectUrl), 303); } - /** - * Performs the logout processing - * - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function logout() - { - trigger_error('LogoutController->logout() will be replaced by protected method processLogout() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - $this->processLogout(); - } - /** * Performs the logout processing */ diff --git a/typo3/sysext/backend/Classes/Controller/NewRecordController.php b/typo3/sysext/backend/Classes/Controller/NewRecordController.php index 89fb110b4dcb..d6b8be16a0cf 100644 --- a/typo3/sysext/backend/Classes/Controller/NewRecordController.php +++ b/typo3/sysext/backend/Classes/Controller/NewRecordController.php @@ -24,7 +24,6 @@ use TYPO3\CMS\Backend\Tree\View\PagePositionMap; use TYPO3\CMS\Backend\Utility\BackendUtility; use TYPO3\CMS\Core\Authentication\BackendUserAuthentication; -use TYPO3\CMS\Core\Compatibility\PublicPropertyDeprecationTrait; use TYPO3\CMS\Core\Database\ConnectionPool; use TYPO3\CMS\Core\Database\Query\Restriction\DeletedRestriction; use TYPO3\CMS\Core\Http\HtmlResponse; @@ -34,7 +33,6 @@ use TYPO3\CMS\Core\Type\Bitmask\Permission; use TYPO3\CMS\Core\Utility\ExtensionManagementUtility; use TYPO3\CMS\Core\Utility\GeneralUtility; -use TYPO3\CMS\Core\Utility\HttpUtility; use TYPO3\CMS\Core\Utility\PathUtility; use TYPO3\CMS\Frontend\Page\PageRepository; @@ -44,32 +42,6 @@ */ class NewRecordController { - use PublicPropertyDeprecationTrait; - - /** - * @var array - */ - protected $deprecatedPublicProperties = [ - 'pageinfo' => 'Using $pageinfo of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'pidInfo' => 'Using $pidInfo of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'newPagesInto' => 'Using $newPagesInto of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'newContentInto' => 'Using $newContentInto of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'newPagesAfter' => 'Using $newPagesAfter of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'web_list_modTSconfig' => 'Using $web_list_modTSconfig of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'allowedNewTables' => 'Using $allowedNewTables of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'deniedNewTables' => 'Using $deniedNewTables of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'web_list_modTSconfig_pid' => 'Using $web_list_modTSconfig_pid of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'allowedNewTables_pid' => 'Using $allowedNewTables_pid of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'deniedNewTables_pid' => 'Using $deniedNewTables_pid of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'code' => 'Using $code of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'R_URI' => 'Using $R_URI of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'returnUrl' => 'Using $returnUrl of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'pagesOnly' => 'Using $pagesOnly of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'perms_clause' => 'Using $perms_clause of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'content' => 'Using $content of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - 'tRows' => 'Using $tRows of class NewRecordController from outside is discouraged as this variable is only used for internal storage.', - ]; - /** * @var array */ @@ -201,9 +173,6 @@ public function __construct() // @see \TYPO3\CMS\Backend\Tree\View\NewRecordPageTreeView::expandNext() $GLOBALS['SOBE'] = $this; - - // @deprecated since TYPO3 v9, will be moved out of __construct() in TYPO3 v10.0 - $this->init($GLOBALS['TYPO3_REQUEST']); } /** @@ -215,6 +184,7 @@ public function __construct() */ public function mainAction(ServerRequestInterface $request): ResponseInterface { + $this->init($request); $response = $this->renderContent($request); if (empty($response)) { @@ -224,109 +194,6 @@ public function mainAction(ServerRequestInterface $request): ResponseInterface return $response; } - /** - * Main processing, creating the list of new record tables to select from - * - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function main() - { - trigger_error('NewRecordController->main() will be replaced by protected method renderContent() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - - $response = $this->renderContent($GLOBALS['TYPO3_REQUEST']); - - if ($response instanceof RedirectResponse) { - HttpUtility::redirect($response->getHeaders()['location'][0]); - } - } - - /** - * Creates the position map for pages wizard - * - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function pagesOnly() - { - trigger_error('NewRecordController->pagesOnly() will be replaced by protected method renderPositionTree() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - $this->renderPositionTree(); - } - - /** - * Create a regular new element (pages and records) - * - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function regularNew() - { - trigger_error('NewRecordController->regularNew() will be replaced by protected method renderNewRecordControls() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - $this->renderNewRecordControls($GLOBALS['TYPO3_REQUEST']); - } - - /** - * User array sort function used by renderNewRecordControls - * - * @param string $a First array element for compare - * @param string $b First array element for compare - * @return int -1 for lower, 0 for equal, 1 for greater - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function sortNewRecordsByConfig($a, $b) - { - trigger_error('NewRecordController->sortNewRecordsByConfig() will be replaced by protected method sortTableRows() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - return $this->sortTableRows($a, $b); - } - - /** - * Links the string $code to a create-new form for a record in $table created on page $pid - * - * @param string $linkText Link text - * @param string $table Table name (in which to create new record) - * @param int $pid PID value for the "&edit['.$table.']['.$pid.']=new" command (positive/negative) - * @param bool $addContentTable If $addContentTable is set, then a new tt_content record is created together with pages - * @return string The link. - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function linkWrap($linkText, $table, $pid, $addContentTable = false) - { - trigger_error('NewRecordController->linkWrap() will be replaced by protected method renderLink() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - return $this->renderLink($linkText, $table, $pid, $addContentTable); - } - - /** - * Returns TRUE if the tablename $checkTable is allowed to be created on the page with record $pid_row - * - * @param array $pid_row Record for parent page. - * @param string $checkTable Table name to check - * @return bool Returns TRUE if the tablename $checkTable is allowed to be created on the page with record $pid_row - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function isTableAllowedForThisPage($pid_row, $checkTable) - { - trigger_error('NewRecordController->isTableAllowedForThisPage() will be replaced by protected method isTableAllowedOnPage() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - return $this->isTableAllowedOnPage($checkTable, $pid_row); - } - - /** - * Returns TRUE if: - * - $allowedNewTables and $deniedNewTables are empty - * - the table is not found in $deniedNewTables and $allowedNewTables is not set or the $table tablename is found in - * $allowedNewTables - * - * If $table tablename is found in $allowedNewTables and $deniedNewTables, $deniedNewTables - * has priority over $allowedNewTables. - * - * @param string $table Table name to test if in allowedTables - * @param array $allowedNewTables Array of new tables that are allowed. - * @param array $deniedNewTables Array of new tables that are not allowed. - * @return bool Returns TRUE if a link for creating new records should be displayed for $table - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function showNewRecLink($table, array $allowedNewTables = [], array $deniedNewTables = []) - { - trigger_error('NewRecordController->showNewRecLink() will be replaced by protected method isRecordCreationAllowedForTable() in TYPO3 v10.0. Do not call from other extension.', E_USER_DEPRECATED); - return $this->isRecordCreationAllowedForTable($table, $allowedNewTables, $deniedNewTables); - } - /** * Constructor function for the class * diff --git a/typo3/sysext/backend/Classes/Controller/UserSettingsController.php b/typo3/sysext/backend/Classes/Controller/UserSettingsController.php index bfc8542d243e..63e0b2750735 100644 --- a/typo3/sysext/backend/Classes/Controller/UserSettingsController.php +++ b/typo3/sysext/backend/Classes/Controller/UserSettingsController.php @@ -28,19 +28,6 @@ */ class UserSettingsController { - /** - * @var BackendUserConfiguration - */ - protected $backendUserConfiguration; - - /** - * Initializes the backendUserConfiguration - */ - public function __construct() - { - $this->backendUserConfiguration = GeneralUtility::makeInstance(BackendUserConfiguration::class); - } - /** * Processes all AJAX calls and returns a JSON for the data * @@ -53,68 +40,37 @@ public function processAjaxRequest(ServerRequestInterface $request): ResponseInt $action = $request->getParsedBody()['action'] ?? $request->getQueryParams()['action'] ?? ''; $key = $request->getParsedBody()['key'] ?? $request->getQueryParams()['key'] ?? ''; $value = $request->getParsedBody()['value'] ?? $request->getQueryParams()['value'] ?? ''; - $data = $this->processRequest($action, $key, $value); - - return (new JsonResponse())->setPayload($data); - } - - /** - * Process data - * - * @param string $action - * @param string $key - * @param string $value - * @return mixed - * - * @deprecated since TYPO3 v9, will be removed in TYPO3 v10.0 - */ - public function process($action, $key = '', $value = '') - { - trigger_error('UserSettingsController->process() will be replaced by protected method processRequest() in TYPO3 v10.0. Do not call from other extensions.', E_USER_DEPRECATED); - return $this->processRequest($action, $key, $value); - } - - /** - * Process data - * - * @param string $action - * @param string $key - * @param mixed $value - * @return mixed - */ - protected function processRequest(string $action, string $key = '', $value = '') - { + $backendUserConfiguration = GeneralUtility::makeInstance(BackendUserConfiguration::class); switch ($action) { case 'get': - $content = $this->backendUserConfiguration->get($key); + $content = $backendUserConfiguration->get($key); break; case 'getAll': - $content = $this->backendUserConfiguration->getAll(); + $content = $backendUserConfiguration->getAll(); break; case 'set': - $this->backendUserConfiguration->set($key, $value); - $content = $this->backendUserConfiguration->getAll(); + $backendUserConfiguration->set($key, $value); + $content = $backendUserConfiguration->getAll(); break; case 'addToList': - $this->backendUserConfiguration->addToList($key, $value); - $content = $this->backendUserConfiguration->getAll(); + $backendUserConfiguration->addToList($key, $value); + $content = $backendUserConfiguration->getAll(); break; case 'removeFromList': - $this->backendUserConfiguration->removeFromList($key, $value); - $content = $this->backendUserConfiguration->getAll(); + $backendUserConfiguration->removeFromList($key, $value); + $content = $backendUserConfiguration->getAll(); break; case 'unset': - $this->backendUserConfiguration->unsetOption($key); - $content = $this->backendUserConfiguration->getAll(); + $backendUserConfiguration->unsetOption($key); + $content = $backendUserConfiguration->getAll(); break; case 'clear': - $this->backendUserConfiguration->clear(); + $backendUserConfiguration->clear(); $content = ['result' => true]; break; default: $content = ['result' => false]; } - - return $content; + return (new JsonResponse())->setPayload($content); } } diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-87193-DeprecatedFunctionalityRemoved.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-87193-DeprecatedFunctionalityRemoved.rst index 8936f353e869..028a376c0bf2 100644 --- a/typo3/sysext/core/Documentation/Changelog/master/Breaking-87193-DeprecatedFunctionalityRemoved.rst +++ b/typo3/sysext/core/Documentation/Changelog/master/Breaking-87193-DeprecatedFunctionalityRemoved.rst @@ -191,6 +191,19 @@ The following PHP class methods that have been previously deprecated for v9 have * :php:`TYPO3\CMS\Backend\Controller\EditDocumentController->openInNewWindowLink()` * :php:`TYPO3\CMS\Backend\Controller\EditDocumentController->setDocument()` * :php:`TYPO3\CMS\Backend\Controller\EditDocumentController->shortCutLink()` +* :php:`TYPO3\CMS\Backend\Controller\FileSystemNavigationFrameController->initPage()` +* :php:`TYPO3\CMS\Backend\Controller\FileSystemNavigationFrameController->main()` +* :php:`TYPO3\CMS\Backend\Controller\LoginController->main()` +* :php:`TYPO3\CMS\Backend\Controller\LoginController->makeInterfaceSelectorBox()` +* :php:`TYPO3\CMS\Backend\Controller\LogoutController->logout()` +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->isTableAllowedForThisPage()` +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->linkWrap()` +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->main()` +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->pagesonly()` +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->regularNew()` +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->showNewRecLink()` +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->sortNewRecordsByConfig()` +* :php:`TYPO3\CMS\Backend\Controller\UserSettingsController->process()` * :php:`TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeAdminPanel()` * :php:`TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeFrontendEdit()` * :php:`TYPO3\CMS\Backend\FrontendBackendUserAuthentication->isFrontendEditingActive()` @@ -483,6 +496,7 @@ The following public class properties have been dropped: The following class methods have changed visibility: +* :php:`TYPO3\CMS\Backend\Controller\BackendController->render()` changed from public to protected * :php:`TYPO3\CMS\Backend\Controller\EditDocumentController->closeDocument()` changed from public to protected * :php:`TYPO3\CMS\Backend\Controller\EditDocumentController->compileForm()` changed from public to protected * :php:`TYPO3\CMS\Backend\Controller\EditDocumentController->fixWSversioningInEditConf()` changed from public to protected @@ -591,6 +605,28 @@ The following class properties have changed visibility: * :php:`TYPO3\CMS\Backend\Controller\EditDocumentController->viewId` changed from public to protected * :php:`TYPO3\CMS\Backend\Controller\EditDocumentController->viewId_addParams` changed from public to protected * :php:`TYPO3\CMS\Backend\Controller\EditDocumentController->viewUrl` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\FileSystemNavigationFrameController->content` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\FileSystemNavigationFrameController->foldertree` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\FileSystemNavigationFrameController->currentSubScript` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\FileSystemNavigationFrameController->cMR` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->allowedNewTables` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->allowedNewTables_pid` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->code` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->content` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->deniedNewTables` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->deniedNewTables_pid` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->newContentInto` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->newPagesAfter` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->newPagesInto` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->pageinfo` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->pagesOnly` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->perms_clause` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->pidInfo` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->R_URI` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->returnUrl` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->tRows` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->web_list_modTSconfig` changed from public to protected +* :php:`TYPO3\CMS\Backend\Controller\NewRecordController->web_list_modTSconfig_pid` changed from public to protected * :php:`TYPO3\CMS\Core\Authentication\BackendUserAuthentication->checkWorkspaceCurrent_cache` changed from public to protected * :php:`TYPO3\CMS\Core\Authentication\BackendUserAuthentication->TSdataArray` changed from public to protected * :php:`TYPO3\CMS\Core\Authentication\BackendUserAuthentication->userTS` changed from public to protected diff --git a/typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php b/typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php index f9534b55f540..4961c0524892 100644 --- a/typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php +++ b/typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php @@ -2166,6 +2166,7 @@ 'maximumNumberOfArguments' => 0, 'restFiles' => [ 'Deprecation-84273-ProtectedMethodsAndPropertiesInFileSystemNavigationFrameController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\LogoutController->logout' => [ @@ -2173,6 +2174,7 @@ 'maximumNumberOfArguments' => 0, 'restFiles' => [ 'Deprecation-84275-ProtectedMethodInLogoutController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\ContentElement\ElementInformationController->getLabelForTableColumn' => [ @@ -2194,6 +2196,7 @@ 'maximumNumberOfArguments' => 0, 'restFiles' => [ 'Deprecation-84274-ProtectedMethodsAndPropertiesInLoginController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\File\FileUploadController->renderUploadForm' => [ diff --git a/typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php b/typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php index 43f9a2ecbdae..0961dea193b5 100644 --- a/typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php +++ b/typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php @@ -297,16 +297,19 @@ 'TYPO3\CMS\Backend\Controller\FileSystemNavigationFrameController->foldertree' => [ 'restFiles' => [ 'Deprecation-84273-ProtectedMethodsAndPropertiesInFileSystemNavigationFrameController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\FileSystemNavigationFrameController->currentSubScript' => [ 'restFiles' => [ 'Deprecation-84273-ProtectedMethodsAndPropertiesInFileSystemNavigationFrameController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\FileSystemNavigationFrameController->cMR' => [ 'restFiles' => [ 'Deprecation-84273-ProtectedMethodsAndPropertiesInFileSystemNavigationFrameController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\ContentElement\MoveElementController->sys_language' => [ @@ -447,76 +450,91 @@ 'TYPO3\CMS\Backend\Controller\NewRecordController->pidInfo' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->newPagesInto' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->newContentInto' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->newPagesAfter' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->web_list_modTSconfig' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->allowedNewTables' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->deniedNewTables' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->web_list_modTSconfig_pid' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->allowedNewTables_pid' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->deniedNewTables_pid' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->code' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->R_URI' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->returnUrl' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->pagesOnly' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\NewRecordController->tRows' => [ 'restFiles' => [ 'Deprecation-84341-ProtectedMethodsAndPropertiesInNewRecordController.rst', + 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], 'TYPO3\CMS\Backend\Controller\Wizard\EditController->doClose' => [ diff --git a/typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php b/typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php index b4923012c707..1ad5312e5f40 100644 --- a/typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php +++ b/typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php @@ -2666,7 +2666,6 @@ public function recPath($pid) * * @param string $table Table name * @return bool Returns TRUE if a link for creating new records should be displayed for $table - * @see \TYPO3\CMS\Backend\Controller\NewRecordController::showNewRecLink */ public function showNewRecLink($table) {