From 4853855619f2b526d5ae281d758dd524244837d4 Mon Sep 17 00:00:00 2001 From: Christian Kuhn Date: Sat, 5 Mar 2022 19:06:32 +0100 Subject: [PATCH] [TASK] Remove a useless WorkspaceService test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test does not make sense and is skipped for a while already. Remove it. Resolves: #97112 Releases: main, 11.5 Change-Id: If00b0b607263531359393cff7793624a12b878bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76743 Tested-by: core-ci Tested-by: Stefan Bürk Reviewed-by: Stefan Bürk Reviewed-by: Oliver Klee --- Build/phpstan/phpstan-baseline.neon | 5 ---- .../Service/WorkspaceServiceTest.php | 25 ------------------- 2 files changed, 30 deletions(-) diff --git a/Build/phpstan/phpstan-baseline.neon b/Build/phpstan/phpstan-baseline.neon index 14264b6bfe4c..637b6d95734f 100644 --- a/Build/phpstan/phpstan-baseline.neon +++ b/Build/phpstan/phpstan-baseline.neon @@ -5230,8 +5230,3 @@ parameters: count: 1 path: ../../typo3/sysext/workspaces/Classes/Service/GridDataService.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: ../../typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php - diff --git a/typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php b/typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php index 74671fc91c76..6d6a2b1d5766 100644 --- a/typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php +++ b/typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php @@ -113,31 +113,6 @@ public function versionsCanBeFilteredToSpecificStage(): void self::assertEquals(106, $result['pages'][1]['uid'], 'First records is supposed to have the uid 106'); } - /** - * The only change which we could find here actually moved away from this - * branch of the tree - therefore we're not supposed to find anything here - * - * @test - */ - public function movedElementsCanNotBeFoundAtTheirOrigin(): void - { - self::markTestSkipped('This test need a review. It is green even if all fixtures are commented out'); - $this->importCSVDataSet(__DIR__ . '/Fixtures/WorkspaceServiceTestMovedContent.csv'); - // Test if the placeholder can be found when we ask using recursion (same result) - $service = new WorkspaceService(); - $result = $service->selectVersionsInWorkspace(91, -99, 2, 99); - self::assertCount( - 0, - $result['pages'], - 'Changes should not show up in this branch of the tree within workspace 91' - ); - self::assertCount( - 0, - $result['tt_content'], - 'Changes should not show up in this branch of the tree within workspace 91' - ); - } - /** * @test */