From 5b4a097933c6862b3abb45f4fa76905140347807 Mon Sep 17 00:00:00 2001
From: Georg Ringer <georg.ringer@gmail.com>
Date: Wed, 21 Oct 2020 13:48:58 +0200
Subject: [PATCH] [BUGFIX] Remove invalid alt attribute from span elements

Attribute alt is not allowed on span elements.

See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/span#Attributes

Resolves: #92632
Releases: master, 10.4
Change-Id: If4e5762cf95535130b373d4e297a28b547686702
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66223
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Haupt <mail@danielhaupt.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Daniel Haupt <mail@danielhaupt.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
---
 .../backend/Classes/Form/NodeExpansion/FieldControl.php       | 2 +-
 .../core/Classes/TypoScript/ExtendedTemplateService.php       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/typo3/sysext/backend/Classes/Form/NodeExpansion/FieldControl.php b/typo3/sysext/backend/Classes/Form/NodeExpansion/FieldControl.php
index 931fc077f502..9902b8baf336 100644
--- a/typo3/sysext/backend/Classes/Form/NodeExpansion/FieldControl.php
+++ b/typo3/sysext/backend/Classes/Form/NodeExpansion/FieldControl.php
@@ -128,7 +128,7 @@ public function render(): array
 
             $html = [];
             $html[] = '<a ' . GeneralUtility::implodeAttributes($linkAttributes, true) . '>';
-            $html[] =   '<span alt="' . htmlspecialchars($title) . '" title="' . htmlspecialchars($title) . '">';
+            $html[] =   '<span title="' . htmlspecialchars($title) . '">';
             $html[] =       $iconFactory->getIcon($icon, Icon::SIZE_SMALL)->render();
             $html[] =   '</span>';
             $html[] = '</a>';
diff --git a/typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php b/typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php
index e003a41fdcdc..3c5ccb27b209 100644
--- a/typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php
+++ b/typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php
@@ -1128,7 +1128,7 @@ public function ext_printFields($theConstants, $category)
                         $deleteIcon = $iconFactory->getIcon('actions-edit-undo', Icon::SIZE_SMALL)->render();
                         $deleteIconHTML =
                             '<button type="button" class="btn btn-default t3js-toggle" data-toggle="undo" rel="' . $idName . '">'
-                                . '<span title="' . $deleteTitle . '" alt="' . $deleteTitle . '">'
+                                . '<span title="' . $deleteTitle . '">'
                                     . $deleteIcon
                                 . '</span>'
                             . '</button>';
@@ -1136,7 +1136,7 @@ public function ext_printFields($theConstants, $category)
                         $editIcon = $iconFactory->getIcon('actions-open', Icon::SIZE_SMALL)->render();
                         $editIconHTML =
                             '<button type="button" class="btn btn-default t3js-toggle" data-toggle="edit"  rel="' . $idName . '">'
-                                . '<span title="' . $editTitle . '" alt="' . $editTitle . '">'
+                                . '<span title="' . $editTitle . '">'
                                     . $editIcon
                                 . '</span>'
                             . '</button>';