From 88706b75c4638db0ffc754684a91afa481537c6a Mon Sep 17 00:00:00 2001 From: Tymoteusz Motylewski Date: Sat, 17 Mar 2018 12:20:44 +0100 Subject: [PATCH] [TASK] Correct QuerySettingsInterface RespectSysLanguage comments The setRespectSysLanguage and getRespectSysLanguage methods are not ifluencing the overlay process, just whether to take record language into account in db query. Releases: master, 8.7 Resolves: #84419 Change-Id: I976210663b24ad99080daedea300c4e42ff59224 Reviewed-on: https://review.typo3.org/56290 Reviewed-by: Markus Klein Tested-by: Markus Klein Tested-by: TYPO3com Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn --- .../Persistence/Generic/QuerySettingsInterface.php | 9 +++++---- .../Classes/Persistence/Generic/Typo3QuerySettings.php | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/typo3/sysext/extbase/Classes/Persistence/Generic/QuerySettingsInterface.php b/typo3/sysext/extbase/Classes/Persistence/Generic/QuerySettingsInterface.php index 641abb777f05..4d938a4590a6 100644 --- a/typo3/sysext/extbase/Classes/Persistence/Generic/QuerySettingsInterface.php +++ b/typo3/sysext/extbase/Classes/Persistence/Generic/QuerySettingsInterface.php @@ -52,18 +52,19 @@ public function setStoragePageIds(array $storagePageIds); public function getStoragePageIds(); /** - * Sets the flag if a translation is chosen and language overlay should be performed. + * Sets the flag if record language should be respected when querying. + * Other settings defines whether overlay should happen or not. * - * @param bool $respectSysLanguage TRUE if a translation is chosen and language overlay should be performed. + * @param bool $respectSysLanguage TRUE if only record language should be respected when querying * @return \TYPO3\CMS\Extbase\Persistence\Generic\QuerySettingsInterface instance of $this to allow method chaining * @api */ public function setRespectSysLanguage($respectSysLanguage); /** - * Returns the state, if a language overlay should be performed when a translation is active. + * Returns the state, if record language should be checked when querying * - * @return bool TRUE, if a language overlay should be performed when a translation is active; otherwise FALSE. + * @return bool if TRUE record language is checked. */ public function getRespectSysLanguage(); diff --git a/typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php b/typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php index bce03c19dc61..e4b3d69267c3 100644 --- a/typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php +++ b/typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php @@ -86,7 +86,7 @@ class Typo3QuerySettings implements QuerySettingsInterface protected $languageMode = null; /** - * Represensting sys_language_uid only valid for current context + * Representing sys_language_uid only valid for current context * * @var int */