From c9dc2b5765dffee77847090c8df780f67b51db06 Mon Sep 17 00:00:00 2001 From: Georg Ringer Date: Fri, 22 Sep 2023 12:54:24 +0200 Subject: [PATCH] [BUGFIX] Return redirect instead of a ForwardResponse After deleting a log entry, the user must be properly redirected to the list action. Resolves: #102003 Releases: main, 12.4 Change-Id: I6caf8fb958acc92823d83fcacac6276ec7ab1d25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81195 Reviewed-by: Benjamin Franzke Tested-by: Benjamin Franzke Tested-by: core-ci --- .../sysext/belog/Classes/Controller/BackendLogController.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/typo3/sysext/belog/Classes/Controller/BackendLogController.php b/typo3/sysext/belog/Classes/Controller/BackendLogController.php index da33effc26fd..1c019f3147f3 100644 --- a/typo3/sysext/belog/Classes/Controller/BackendLogController.php +++ b/typo3/sysext/belog/Classes/Controller/BackendLogController.php @@ -29,7 +29,6 @@ use TYPO3\CMS\Core\Type\ContextualFeedbackSeverity; use TYPO3\CMS\Core\Utility\ExtensionManagementUtility; use TYPO3\CMS\Core\Utility\GeneralUtility; -use TYPO3\CMS\Extbase\Http\ForwardResponse; use TYPO3\CMS\Extbase\Mvc\Controller\ActionController; use TYPO3\CMS\Extbase\Persistence\QueryResultInterface; use TYPO3\CMS\Extbase\Utility\LocalizationUtility; @@ -137,11 +136,11 @@ public function deleteMessageAction(int $errorUid): ResponseInterface $logEntry = $this->logEntryRepository->findByUid($errorUid); if (!$logEntry) { $this->addFlashMessage(LocalizationUtility::translate('actions.delete.noRowFound', 'belog') ?? '', '', ContextualFeedbackSeverity::WARNING); - return new ForwardResponse('list'); + return $this->redirect('list'); } $numberOfDeletedRows = $this->logEntryRepository->deleteByMessageDetails($logEntry); $this->addFlashMessage(sprintf(LocalizationUtility::translate('actions.delete.message', 'belog') ?? '', $numberOfDeletedRows)); - return new ForwardResponse('list'); + return $this->redirect('list'); } /**