From d4b4fc43e566992c3a8e66bb5c80acd5fd090272 Mon Sep 17 00:00:00 2001 From: Christian Kuhn Date: Sun, 30 Jul 2023 13:37:04 +0200 Subject: [PATCH] [TASK] Stabilize FileClipboardCest (again) This one was still flaky. Properly waiting for the element should finally fix this, this patch now had a huge number of successful runs locally, while it failed repeatedly without. Resolves: #101487 Related: #101440 Releases: main, 12.4, 11.5 Change-Id: I2cf4b3e878caf430ead27340694a169f98e710e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80242 Reviewed-by: Christian Kuhn Tested-by: core-ci Tested-by: Christian Kuhn --- .../Acceptance/Application/FileList/FileClipboardCest.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php b/typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php index 48e6373551eb..8e97bf759658 100644 --- a/typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php +++ b/typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php @@ -39,11 +39,14 @@ public function _before(ApplicationTester $I, FileTree $tree): void public function seeSwitchModes(ApplicationTester $I): void { + $I->waitForElementVisible($this->copyModeMove); $I->seeCheckboxIsChecked($this->copyModeMove); + $I->waitForElementVisible($this->copyModeCopy); $I->dontSeeCheckboxIsChecked($this->copyModeCopy); $I->click('//*/label[@for="clipboard-copymode-copy"]'); - $I->waitForElement($this->copyModeMove, 5); + $I->waitForElementVisible($this->copyModeMove); $I->dontSeeCheckboxIsChecked($this->copyModeMove); + $I->waitForElementVisible($this->copyModeCopy); $I->seeCheckboxIsChecked($this->copyModeCopy); }