From ebad91ff0ace9a9c9b32657898425b2a7c370515 Mon Sep 17 00:00:00 2001
From: Guido Schmechel <guido.schmechel@brandung.de>
Date: Sat, 20 Jul 2019 12:54:13 +0200
Subject: [PATCH] [TASK] Disable autocompletion in Install Tool settings

To prevent unwanted entries, the autocomplete attribute
in the Install tool is added with the `off` property.

Resolves: #88709
Releases: master, 9.5
Change-Id: I3c0a343fd76170f6cc37e5e87ad9a5d5d9a52fb9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61331
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
---
 .../Settings/ExtensionConfiguration/ExtensionForm.html         | 2 +-
 .../Partials/Settings/LocalConfiguration/SubSection.html       | 3 +++
 .../Templates/Settings/LocalConfigurationGetContent.html       | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/typo3/sysext/install/Resources/Private/Partials/Settings/ExtensionConfiguration/ExtensionForm.html b/typo3/sysext/install/Resources/Private/Partials/Settings/ExtensionConfiguration/ExtensionForm.html
index 2777d3fa40b6..45fab8c26f6d 100644
--- a/typo3/sysext/install/Resources/Private/Partials/Settings/ExtensionConfiguration/ExtensionForm.html
+++ b/typo3/sysext/install/Resources/Private/Partials/Settings/ExtensionConfiguration/ExtensionForm.html
@@ -22,7 +22,7 @@ <h3 class="panel-title">
                     </f:for>
                 </ul>
 
-                <form action="#" name="configurationform" class="t3js-extensionConfiguration-form extensionConfiguration-form" data-extensionKey="{extensionKey}">
+                <form action="#" name="configurationform" autocomplete="off" class="t3js-extensionConfiguration-form extensionConfiguration-form" data-extensionKey="{extensionKey}">
                     <div class="tab-content">
                         <f:for each="{extensionData.configuration}" as="subcategories" key="categoryName" iteration="iteration">
                             <f:if condition="{categoryName}">
diff --git a/typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html b/typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html
index b97de074caf4..d94ed8986ef2 100644
--- a/typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html
+++ b/typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html
@@ -73,6 +73,7 @@ <h3 class="panel-title">
                                         value="{item.value}"
                                         data-path="{sectionName}/{item.key}"
                                         class="t3-install-form-input-text form-control t3js-localConfiguration-pathValue"
+                                        autocomplete="off"
                                     />
                                 </div>
                             </f:if>
@@ -85,6 +86,7 @@ <h3 class="panel-title">
                                         value="{item.value}"
                                         data-path="{sectionName}/{item.key}"
                                         class="t3-install-form-input-text form-control t3js-localConfiguration-pathValue"
+                                        autocomplete="off"
                                     />
                                 </div>
                             </f:if>
@@ -97,6 +99,7 @@ <h3 class="panel-title">
                                         value="{item.value}"
                                         data-path="{sectionName}/{item.key}"
                                         class="t3-install-form-input-text form-control t3js-localConfiguration-pathValue"
+                                        autocomplete="off"
                                     />
                                 </div>
                             </f:if>
diff --git a/typo3/sysext/install/Resources/Private/Templates/Settings/LocalConfigurationGetContent.html b/typo3/sysext/install/Resources/Private/Templates/Settings/LocalConfigurationGetContent.html
index 1c762c4f84f7..6476d24fea0d 100644
--- a/typo3/sysext/install/Resources/Private/Templates/Settings/LocalConfigurationGetContent.html
+++ b/typo3/sysext/install/Resources/Private/Templates/Settings/LocalConfigurationGetContent.html
@@ -10,7 +10,7 @@
     <div class="form-group">
         <div class="input-group">
             <span class="input-group-addon">Filter by:</span>
-            <input type="text" class="form-control t3js-localConfiguration-search" placeholder="search setting">
+            <input type="text" autocomplete="off" class="form-control t3js-localConfiguration-search" placeholder="search setting">
         </div>
     </div>