Respect TCA overrides for CE localization #438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to TYPO3. We are using Gerrit Code Review for our contributions and took the liberty to convert your pull request to a review in our review system. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a few general purpose columns, that are shared between CTypes. The implementation differs between them, and is setup via overrides for the specific CType.
DataHandler->localize doesn't seem to respect column overrides for CTypes, resulting in settings like
l10n_modebeing ignored, if they are set via CType specific override.The scenario where I ran into this, was trying to translate one of the general purpose columns via https://github.com/web-vision/wv_deepltranslate/. The columns were ignored, because it didn't detect the
'l10n_mode' => 'prefixLangTitle', which had to be set via overrides in my case.This pull request adds the handling of CType specific overrides in DataHandler->localize.