feat(cli): add upgrade information on startup - #294
Merged
Conversation
wsxiaoys
reviewed
Sep 14, 2025
DESU-CLUB
marked this pull request as ready for review
September 15, 2025 06:18
DESU-CLUB
force-pushed
the
feat/upgrade-on-startup
branch
2 times, most recently
from
September 15, 2025 06:58
234c633 to
d64718d
Compare
zwpaper
requested changes
Sep 15, 2025
zwpaper
left a comment
Member
There was a problem hiding this comment.
Hi @DESU-CLUB , there are some UX comments and nits, please have a look and ping me if you have any questions
Collaborator
Author
|
@zwpaper Thank you for the feedback! Have resolved the nits, and left comments for clarifications on one of the comments! |
zwpaper
requested changes
Sep 16, 2025
zwpaper
left a comment
Member
There was a problem hiding this comment.
Hi @DESU-CLUB, one last nit, otherwise LGTM
zwpaper
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #277
Summary
checkForUpdates(packages/cli/upgrade/version-check.ts) andregisterUpgradeCommand(packages/cli/upgrade/cmd.ts) now internally usereturnVersionInfo, to de-duplicate potentially redundant codeHow to run
Building from source (Github)
bun installin the root folderbun run buildin packages/cli./dist/pochi -<command>: The upgrade information should be shown on displayRunning using bun
bun installin the root folderbun run pochi -<command>: The upgrade information should be shownKnown Issues
TODO
Update documentation with note that now upgrade is displayed on startup(Doesn't seem like it belongs in docs, which talks about core features rather than UI changes)Display Preview
Display Preview with
promptcommandDisplay Preview with
upgradecommand