chore: update rusqlite, rusqlite_migration and tokio-rusqlite #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’ve released a new beta version of rusqlite_migration today and I’ve renamed the `async-tokio-rusqlite` feature that you use to `alpha-async-tokio-rusqlite`. I suggest updating dependencies as done in this PR. By the way, if you would like to share feedback on the async APIs, feel free to use this conversation: cljoly/rusqlite_migration#127 Reading the release notes from [tokio-rusqlite][1], the main breaking change is to the method `Connection::call`: > - **breaking:** `Connection::call` now takes `tokio_rusqlite::Result` instead > of `rusqlite::Result`. My understanding is that we can either deal with a `Result<Result<…>>` or call `Connection::call_unwrap`, which could panic if the connection is closed. I’ve opted for using only `Connection::call` and, effectively, flattening the `Result<Result<…>>`, to limit the potential for panics. [1]: https://github.com/programatik29/tokio-rusqlite/blob/master/CHANGELOG.md#050-25-nov-2023
Member
|
Thanks for the PR, LGTM |
wsxiaoys
pushed a commit
that referenced
this pull request
Dec 11, 2023
I’ve released a new beta version of rusqlite_migration today and I’ve renamed the `async-tokio-rusqlite` feature that you use to `alpha-async-tokio-rusqlite`. I suggest updating dependencies as done in this PR. By the way, if you would like to share feedback on the async APIs, feel free to use this conversation: cljoly/rusqlite_migration#127 Reading the release notes from [tokio-rusqlite][1], the main breaking change is to the method `Connection::call`: > - **breaking:** `Connection::call` now takes `tokio_rusqlite::Result` instead > of `rusqlite::Result`. My understanding is that we can either deal with a `Result<Result<…>>` or call `Connection::call_unwrap`, which could panic if the connection is closed. I’ve opted for using only `Connection::call` and, effectively, flattening the `Result<Result<…>>`, to limit the potential for panics. [1]: https://github.com/programatik29/tokio-rusqlite/blob/master/CHANGELOG.md#050-25-nov-2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve released a new beta version of rusqlite_migration today and I’ve
renamed the
async-tokio-rusqlitefeature that you use toalpha-async-tokio-rusqlite. I suggest updating dependencies as done inthis PR. By the way, if you would like to share feedback on the async
APIs, feel free to use this conversation:
cljoly/rusqlite_migration#127
Reading the release notes from tokio-rusqlite, the main breaking
change is to the method
Connection::call:My understanding is that we can either deal with a
Result<Result<…>>or call
Connection::call_unwrap, which could panic if the connectionis closed. I’ve opted for using only
Connection::calland,effectively, flattening the
Result<Result<…>>, to limit the potentialfor panics.