Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit row after running SELECT query #120

Closed
gokninski opened this issue Nov 23, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@gokninski
Copy link

commented Nov 23, 2017

I'm pretty sure this worked before but not 100%.

If you select a record using a select statement from the SQL query window and then try and edit a field for that record in the results panel then it will allow you to click into the field but not commit the actual change.

Running latest version Version 1.0 (72) with PostgreSQL 9.6.1.

Many thanks,

G :)

@huyphams

This comment has been minimized.

Copy link
Contributor

commented Nov 23, 2017

Hi @gokninski
We do not allow to edit value in the query result window. Because in this case, we didn't know the table contains that row.

For example:

SELECT
    kc.ordinal_position AS ordinal_position,
    tc.table_schema AS table_schema,
    tc.table_name AS table_name,
    tc.constraint_name AS constraint_name,
    kc.column_name AS column_name
FROM
    information_schema.table_constraints tc,
    information_schema.key_column_usage kc
WHERE
    tc.constraint_type = 'PRIMARY KEY'
    AND kc.table_name = tc.table_name
    AND kc.table_schema = tc.table_schema
    AND kc.constraint_name = tc.constraint_name
ORDER BY
    kc.ordinal_position ASC;

The result are:
screen shot 2017-11-23 at 6 47 26 pm
In this case, we can't edit value of rows.

But you're right, it would be great if we can edit value from there. I'm thinking about it and let this issue open.
Thanks,

Huy.

@gokninski

This comment has been minimized.

Copy link
Author

commented Nov 23, 2017

Thanks for your reply Huy. This is how I personally use database browsers for making quick edits - in other browsers I have used they must perform a check to see whether that row is still correct as I have seen a message come up and say something along the lines of 'this row has changed, please refresh'.

Many thanks,

Greg :)

@PVGrad

This comment has been minimized.

Copy link

commented Nov 24, 2017

As I noticed in other apps - they allow to edit row after select if select has primary key in it, so in this case it is safe to perform edit

@huyphams

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

Hi @gokninski @PVGrad

This feature will be included in next #build74
Thank you guys 🙈

  • Huy.
@huyphams

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

💃🏻🎉
screen shot 2017-11-30 at 4 41 31 pm

@huyphams huyphams closed this Dec 5, 2017

@taylorotwell

This comment has been minimized.

Copy link

commented Dec 14, 2017

I still can't get this to work on latest build (downloaded today). Is there some special process to get this to work?

@huyphams

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2017

Hi @taylorotwell

Currently, we only support this feature on PostgreSQL, other drivers will come later. Because this feature depend on official support from database driver. Which driver are you on?

Huy.

@taylorotwell

This comment has been minimized.

Copy link

commented Dec 16, 2017

I use MySQL and SQLite typically. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.