feat(plugin-oracle): support Oracle Database 11g#1429
Merged
Conversation
Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1425. Related: #483.
Oracle 11g (11.1 and 11.2) servers now connect. Previously the pure-Swift driver rejected anything below 12.1, so 11g failed with a raw
OracleSQLError(code: serverVersionNotSupported). Validated against a live Oracle 11.2.0.2 XE instance: connect, authenticate, and fetch multiple rows with VARCHAR2, NUMBER, and DATE columns.What's here
Oracle 11g support (driver work merged in TableProApp/oracle-nio#1):
tablepro-maincommit, which lowers the protocol floor to 11.1 and implements the legacy O5LOGON auth, Accept-packet, execute, and OER-status wire formats that pre-12.1 servers use. 10g and earlier stay unsupported (they use the O3LOGON handshake).Clearer connection errors:
Docs:
docs/databases/oracle.mdxcorrected to 11.1+, pure-Swift, no Instant Client (the page previously claimed OCI, contradicting itself).Notes