Skip to content

Conversation

@louisl4696
Copy link

@louisl4696 louisl4696 commented Nov 11, 2025

Summary

Closes #1197

Tags and fields are now correctly mirrored across Entries when clicking the Mirror Entries button in the Fix Duplicate Files menu

  • Updated DupeFilesRegistry method refresh_dupe_files() to use library.get_entry_full() in dupe_files_registry.py
    entries previously returned with get_entries() were incomplete and causing errors later down the line
  • Created mirror_entry_tags() in library.py
  • fixed mirror_entry_fields() in library.py
    field mirroring was inconsistent, skipping all fields present on the reference Entry. Now, already present fields are skipped on a per-Entry basis.
  • updated mirror_entries_runnable() to also call lib.mirror_entry_tags() in mirror_entries_modal.py

NOTE: this will be difficult to test until #1196 is fixed. See my thread in discord for a quick hack to get around that bug and be able to test the functionality of the changes in this PR.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested for the reasons mentioned, but the code looks quite good to me and the changes are relatively small and localised so I don't think it's strictly necessary here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Mirror Entries loads infinitely

2 participants