From edbe607cec57795ee125bbc5e08bf2cd14c5d1d8 Mon Sep 17 00:00:00 2001 From: Jann Stute Date: Wed, 26 Nov 2025 13:12:37 +0100 Subject: [PATCH 1/9] ci: initial version of pyright workflow --- .github/workflows/pyright.yaml | 35 ++++++++++++++++++++++++++++++++++ pyproject.toml | 1 + 2 files changed, 36 insertions(+) create mode 100644 .github/workflows/pyright.yaml diff --git a/.github/workflows/pyright.yaml b/.github/workflows/pyright.yaml new file mode 100644 index 000000000..c187a3219 --- /dev/null +++ b/.github/workflows/pyright.yaml @@ -0,0 +1,35 @@ +--- +name: Pyright + +on: [push, pull_request] + +jobs: + pyright: + name: Run Pyright + runs-on: ubuntu-latest + steps: + - name: Checkout repo + uses: actions/checkout@v4 + + - name: Setup reviewdog + uses: reviewdog/action-setup@v1 + with: + reviewdog_version: latest + + - name: Setup Python + uses: actions/setup-python@v5 + with: + python-version: "3.12" + cache: pip + + - name: Install Python dependencies + run: | + python -m pip install --upgrade uv + uv pip install --system .[pyright] + + - name: Execute Pyright + uses: jordemort/action-pyright@v1 + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + reporter: github-pr-review + lib: true diff --git a/pyproject.toml b/pyproject.toml index cb095d849..cd5ca40cc 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -39,6 +39,7 @@ dependencies = [ dev = ["tagstudio[mkdocs,mypy,pre-commit,pyinstaller,pytest,ruff]"] mkdocs = ["mkdocs-material[imaging]>=9.6.14", "mkdocs-redirects~=1.2"] mypy = ["mypy==1.15.0", "mypy-extensions==1.*", "types-ujson~=5.10"] +pyright = ["pyright~=1.1.405"] pre-commit = ["pre-commit~=4.2"] pyinstaller = ["Pyinstaller~=6.13"] pytest = [ From 99f0fb33334b4a08b790f54f7b7a85365eb56298 Mon Sep 17 00:00:00 2001 From: Jann Stute Date: Wed, 26 Nov 2025 13:16:38 +0100 Subject: [PATCH 2/9] ci: remove invalid pyright settings --- pyproject.toml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index cd5ca40cc..23a7c03bf 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -93,13 +93,11 @@ ignore = [ "src/tagstudio/qt/previews/vendored/pydub/", ] include = ["src/tagstudio", "tests"] -reportAny = false -reportIgnoreCommentWithoutRule = false +# reference for the settings here: https://github.com/microsoft/pyright/blob/main/docs/configuration.md reportImplicitStringConcatenation = false reportMissingTypeArgument = false reportMissingTypeStubs = false # reportOptionalMemberAccess = false -reportUnannotatedClassAttribute = false reportUnknownArgumentType = false reportUnknownLambdaType = false reportUnknownMemberType = false From 471e39d29f09c59ef1f773bc087d3fe4f91bc4b3 Mon Sep 17 00:00:00 2001 From: Jann Stute Date: Wed, 26 Nov 2025 13:20:22 +0100 Subject: [PATCH 3/9] debug: return ALL results from pyright --- .github/workflows/pyright.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pyright.yaml b/.github/workflows/pyright.yaml index c187a3219..16dfd16df 100644 --- a/.github/workflows/pyright.yaml +++ b/.github/workflows/pyright.yaml @@ -33,3 +33,4 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review lib: true + filter_mode: nofilter From 593da9937587d256678b829ca55bf606fde85354 Mon Sep 17 00:00:00 2001 From: Jann Stute Date: Wed, 26 Nov 2025 13:20:55 +0100 Subject: [PATCH 4/9] ci: remove unnecessary reviewdog install --- .github/workflows/pyright.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pyright.yaml b/.github/workflows/pyright.yaml index 16dfd16df..e2bf6c063 100644 --- a/.github/workflows/pyright.yaml +++ b/.github/workflows/pyright.yaml @@ -11,10 +11,10 @@ jobs: - name: Checkout repo uses: actions/checkout@v4 - - name: Setup reviewdog - uses: reviewdog/action-setup@v1 - with: - reviewdog_version: latest + # - name: Setup reviewdog + # uses: reviewdog/action-setup@v1 + # with: + # reviewdog_version: latest - name: Setup Python uses: actions/setup-python@v5 From 8bded89fba6618fc23ba17e4677d2d175bc22a9c Mon Sep 17 00:00:00 2001 From: Jann Stute Date: Wed, 26 Nov 2025 13:24:36 +0100 Subject: [PATCH 5/9] Revert "debug: return ALL results from pyright" This reverts commit 471e39d29f09c59ef1f773bc087d3fe4f91bc4b3. --- .github/workflows/pyright.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/pyright.yaml b/.github/workflows/pyright.yaml index e2bf6c063..dd2a9ac78 100644 --- a/.github/workflows/pyright.yaml +++ b/.github/workflows/pyright.yaml @@ -33,4 +33,3 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review lib: true - filter_mode: nofilter From 2b99dc7ee7e347ac0543d70022135ffd66a658b1 Mon Sep 17 00:00:00 2001 From: Jann Stute Date: Wed, 26 Nov 2025 13:24:59 +0100 Subject: [PATCH 6/9] ci: choose reporter based on event type --- .github/workflows/pyright.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pyright.yaml b/.github/workflows/pyright.yaml index dd2a9ac78..be07d2ef2 100644 --- a/.github/workflows/pyright.yaml +++ b/.github/workflows/pyright.yaml @@ -31,5 +31,5 @@ jobs: uses: jordemort/action-pyright@v1 with: github_token: ${{ secrets.GITHUB_TOKEN }} - reporter: github-pr-review + reporter: ${{ github.event_name == 'pull_request' && 'github-pr-review' || 'github-pr-check' }} lib: true From f34e1fe5048c7d0f398a2208a2a96d04a515c869 Mon Sep 17 00:00:00 2001 From: Jann Stute Date: Wed, 26 Nov 2025 13:26:53 +0100 Subject: [PATCH 7/9] ci: choose correct reporter for non-pr event --- .github/workflows/pyright.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pyright.yaml b/.github/workflows/pyright.yaml index be07d2ef2..c7430f55c 100644 --- a/.github/workflows/pyright.yaml +++ b/.github/workflows/pyright.yaml @@ -31,5 +31,5 @@ jobs: uses: jordemort/action-pyright@v1 with: github_token: ${{ secrets.GITHUB_TOKEN }} - reporter: ${{ github.event_name == 'pull_request' && 'github-pr-review' || 'github-pr-check' }} + reporter: ${{ github.event_name == 'pull_request' && 'github-pr-review' || 'github-check' }} lib: true From 018e01c084f6cd163a9d3b286e37ee922c6d8984 Mon Sep 17 00:00:00 2001 From: Jann Stute Date: Wed, 26 Nov 2025 13:28:26 +0100 Subject: [PATCH 8/9] ci: small cleanup --- .github/workflows/pyright.yaml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/pyright.yaml b/.github/workflows/pyright.yaml index c7430f55c..356ae90f4 100644 --- a/.github/workflows/pyright.yaml +++ b/.github/workflows/pyright.yaml @@ -11,11 +11,6 @@ jobs: - name: Checkout repo uses: actions/checkout@v4 - # - name: Setup reviewdog - # uses: reviewdog/action-setup@v1 - # with: - # reviewdog_version: latest - - name: Setup Python uses: actions/setup-python@v5 with: @@ -32,4 +27,3 @@ jobs: with: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: ${{ github.event_name == 'pull_request' && 'github-pr-review' || 'github-check' }} - lib: true From 704d1c5c6831520c73f5982e09c4094581539589 Mon Sep 17 00:00:00 2001 From: Jann Stute Date: Wed, 26 Nov 2025 14:43:55 +0100 Subject: [PATCH 9/9] ci: also install pytest deps --- .github/workflows/pyright.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pyright.yaml b/.github/workflows/pyright.yaml index 356ae90f4..0c57315ef 100644 --- a/.github/workflows/pyright.yaml +++ b/.github/workflows/pyright.yaml @@ -20,7 +20,7 @@ jobs: - name: Install Python dependencies run: | python -m pip install --upgrade uv - uv pip install --system .[pyright] + uv pip install --system .[pyright,pytest] - name: Execute Pyright uses: jordemort/action-pyright@v1