hotfix: document.querySelector returns null if there are no nodes are… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey dude! First of all, i'd like to say I really like the library. Thanks for sharing it with the community.
Context
With version
0.0.5, TypeScript currently complains that thedocument.querySelectormethod inside thecreateSwapydoes not always necessarily return an element: if there are no nodes found whatsoever, it will returnnull.This PR fixes the type definition so that we don't need to
@ts-ignoreany of our uses of this library. Ideally it should probably be a patch0.0.6release.Screenshots
GIF
Here's a GIF for good luck with the project 💟