New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TMDM-15182 Improper Restriction of XML External Entity Reference #1420
Conversation
ad6038d
to
a7e8f59
Compare
a7e8f59
to
1c89dff
Compare
| saxonTransformerFactory.setAttribute("http://saxon.sf.net/feature/version-warning", Boolean.FALSE); | ||
| saxonTransformerFactory.setAttribute("http://saxon.sf.net/feature/allow-external-functions", Boolean.FALSE); | ||
| saxonTransformerFactory.setAttribute("http://saxon.sf.net/feature/trace-external-functions", Boolean.FALSE); | ||
| // saxonTransformerFactory.setAttribute(XMLConstants.ACCESS_EXTERNAL_DTD, ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the commented code
| DocumentBuilder documentBuilder = factory.newDocumentBuilder(); | ||
| // DocumentBuilder documentBuilder = MDMXMLUtils.getDocumentBuilder().get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could remove
| DocumentBuilder documentBuilder = factory.newDocumentBuilder(); | ||
| // DocumentBuilder documentBuilder = MDMXMLUtils.getDocumentBuilder().get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could remove
| @@ -339,7 +340,8 @@ public long putDocumentFromString(String xmlString, String uniqueID, String clus | |||
| throws XmlServerException { | |||
| try { | |||
| InputSource source = new InputSource(new StringReader(xmlString)); | |||
| Document document = DOCUMENT_BUILDER_FACTORY.newDocumentBuilder().parse(source); | |||
| //Document document = DOCUMENT_BUILDER_FACTORY.newDocumentBuilder().parse(source); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could remove
| DocumentBuilder documentBuilder = factory.newDocumentBuilder(); | ||
| // DocumentBuilder documentBuilder = MDMXMLUtils.getDocumentBuilder().get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could remove
1c89dff
to
9c45ede
Compare
* TMDM-15182 Improper Restriction of XML External Entity Reference
* TMDM-15182 Improper Restriction of XML External Entity Reference
* TMDM-15182 Improper Restriction of XML External Entity Reference
* TMDM-15182 Improper Restriction of XML External Entity Reference
* TMDM-15182 Improper Restriction of XML External Entity Reference
…) (#1433) * TMDM-15182 Improper Restriction of XML External Entity Reference
…) (#1451) * TMDM-15182 Improper Restriction of XML External Entity Reference
https://jira.talendforge.org/browse/TMDM-15182
What is the current behavior? (You should also link to an open issue here)
Improper Restriction of XML External Entity Reference in kind of project
What is the new behavior?
Improper Restriction of XML External Entity Reference in kind of project
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: