Reduce DB calls and serialisation overheads for socket messages

[tudddorrr]

No description provided.

[claude]

PR Review: Reduce DB calls and serialisation overheads for socket messages

After reviewing the changes in this PR, the implementation looks solid. The performance optimizations are well-executed and the code changes are safe.

---

🟢 Code Quality and Best Practices

No issues found - the refactoring follows good practices by eliminating unnecessary async operations and reducing populate depth where appropriate.

---

🟢 Potential Bugs or Issues

No issues found - all changes are safe:

• conn.game is reliably set in the SocketConnection constructor
• The hasMember() method only uses getIdentifiers(), so populate: ['members:ref'] is sufficient
• Removing findConnectionsAsync is safe as there are no other usages

---

🟢 Performance Considerations

No issues found - the PR delivers excellent performance improvements:

• Eliminated async DB calls in findConnections filter
• Reduced JSON serialization overhead by serializing once per broadcast
• Changed populate strategy from members to members:ref (appropriate for the usage)

---

🟢 Security Concerns

No issues found.

---

🟢 Test Coverage

The changes don't introduce new functionality, so existing test coverage should be sufficient. Consider running the full test suite to verify no regressions.

---

Overall: This is a clean performance optimization PR with no issues identified. Good work! ✅

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.21%. Comparing base (3d7734c) to head (8be90f3).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #704      +/-   ##
===========================================
- Coverage    99.21%   99.21%   -0.01%     
===========================================
  Files          225      225              
  Lines        16617    16608       -9     
  Branches      1540     1538       -2     
===========================================
- Hits         16486    16477       -9     
  Misses         128      128              
  Partials         3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.