Reduce DB calls and serialisation overheads for socket messages

src/entities/player.ts

@@ -156,11 +156,11 @@ export default class Player {
 
     await em.flush()
 
-    const conns = await socket.findConnectionsAsync(async (conn) => {
+    const conns = socket.findConnections((conn) => {
       return (
         conn.hasScope(APIKeyScope.READ_PLAYER_PRESENCE) &&
         !!conn.playerAliasId &&
-        this.game.id === (await conn.getPlayerAlias())?.player.game.id
+        this.game.id === conn.game.id
       )
     })
     await sendMessages(conns, 'v1.players.presence.updated', {

src/socket/index.ts

@@ -182,17 +182,6 @@ export default class Socket {
     return Array.from(this.connections.values()).filter(filter)
   }
 
-  async findConnectionsAsync(filter: (conn: SocketConnection) => Promise<boolean>): Promise<SocketConnection[]> {
-    const connections = Array.from(this.connections.values())
-    const results = await Promise.all(
-      connections.map(async (conn) => ({
-        conn,
-        matches: await filter(conn)
-      }))
-    )
-    return results.filter((r) => r.matches).map((r) => r.conn)
-  }
-
   async trackEvent(data: Omit<SocketEventData, 'id'>): Promise<void> {
     if (process.env.DISABLE_SOCKET_EVENTS === '1') {
       return

src/socket/listeners/gameChannelListeners.ts

@@ -23,7 +23,7 @@ const gameChannelListeners = [
           id: data.channel.id,
           game: conn.game
         }, {
-          populate: ['members']
+          populate: ['members:ref']
         })
 
       if (!channel) {

src/socket/messages/socketMessage.ts

@@ -31,7 +31,11 @@ export async function sendMessage<T extends object>(conn: SocketConnection, res:
 
 export async function sendMessages<T extends object>(conns: SocketConnection[], type: SocketMessageResponse, data: T) {
   await getSocketTracer().startActiveSpan('socket.send_many_messages', async (span) => {
-    await Promise.all(conns.map((conn) => conn.sendMessage(type, data)))
-    span.end()
+    try {
+      const message = JSON.stringify({ res: type, data })
+      await Promise.all(conns.map((conn) => conn.sendMessage(type, data, message)))
+    } finally {
+      span.end()
+    }
   })
 }

src/socket/socketConnection.ts

@@ -81,14 +81,11 @@ export default class SocketConnection {
     return this.ticket.devBuild
   }
 
-  async sendMessage<T extends object>(res: SocketMessageResponse, data: T): Promise<void> {
+  async sendMessage<T extends object>(res: SocketMessageResponse, data: T, serialisedMessage?: string): Promise<void> {
     await getSocketTracer().startActiveSpan('socket.send_message', async (span) => {
       if (this.ws.readyState === this.ws.OPEN) {
         const devBuild = this.isDevBuild()
-        const message = JSON.stringify({
-          res,
-          data
-        })
+        const message = serialisedMessage ?? JSON.stringify({ res, data })
 
         setTraceAttributes({
           'socket.message_receiver.alias_id': this.playerAliasId,