refactor: upgrade starters to nitro v3 #231
Merged
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think you need to build this and update the tests |
Contributor
Author
|
@jherr upated checksums. local try works + we have CI for each commit in nitro v3 to pass against TSS starter. (does CI run on PRs? / i can't see any affected unit test) |
Collaborator
|
Hmm... Ok. I guess we don't have a test with Nitro. Oh well, I'll add one later. This PR LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nitro v3 native vite plugin is becoming more stable and at this point we can support it better.
/cc @schiller-manuel