fix: remove trailing comma from tsconfig.json template #236
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyeonLeeLuda
force-pushed
the
fix/remove-trailing-comma-in-tsconfig-template
branch
from
e7ee595 to
b7b1bb4
Compare
jiyeonLeeLuda
deleted the
fix/remove-trailing-comma-in-tsconfig-template
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an invalid trailing comma in
tsconfig.json.ejsinside the CRA template.Details
While reviewing the template files, I found that the CRA version of
tsconfig.json.ejscontains a trailing comma inside thepathsfield,which makes the resulting JSON invalid.
Note
The CRA template is currently registered in the CLI codebase,
but it does not appear as a selectable template option
(
typescript,javascript, andfile-routerare the only active options).Because of this, the CRA template is not used during project generation,
so I wasn’t able to validate the fix through a generated project.
Still, the template file itself contains a clear JSON syntax issue,
so this PR removes the trailing comma.
Changes
pathsintsconfig.json.ejs.Thanks!