Skip to content

Returning early in a useLiveQuery should set isReady to true #883

@Makisuo

Description

@Makisuo
  • I've validated the bug against the latest version of DB packages

Describe the bug
When I return early in useLiveQuery as show in this example here, isReady is currently always false, I would expect it to be true.

const {
		data: membership,
		isLoading,
		isReady,
	} = useLiveQuery(
		(q) => {
			if (!user?.organizationId) return null
			return q
				.from({ member: organizationMemberCollection })
				.innerJoin({ org: organizationCollection }, ({ member, org }) =>
					eq(member.organizationId, org.id),
				)
				.where(({ member }) =>
					and(eq(member.userId, user?.id), eq(member.organizationId, user?.organizationId)),
				)
				.findOne()
		},
		[user?.id, user?.organizationId],
	)

To Reproduce
Steps to reproduce the behavior:

  1. Define useLiveQuery with an early return
  2. Print isReady

Expected behavior
Should return true for isReady

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions