-
-
Notifications
You must be signed in to change notification settings - Fork 547
Fix react compiler #1893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix react compiler #1893
Conversation
🦋 Changeset detectedLatest commit: a3da6ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit a3da6ef
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1893 +/- ##
==========================================
- Coverage 90.35% 90.12% -0.23%
==========================================
Files 38 41 +3
Lines 1752 1884 +132
Branches 444 473 +29
==========================================
+ Hits 1583 1698 +115
- Misses 149 166 +17
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@TkDodo ready for re-review! Thanks for your help here |
TkDodo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely 🎉
This PR fixes issues with the React compiler where there were edgecases we'd hit previously.
Closes: #1832