Skip to content

Conversation

@crutchcorn
Copy link
Member

This PR fixes issues with the React compiler where there were edgecases we'd hit previously.

Closes: #1832

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025

🦋 Changeset detected

Latest commit: a3da6ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@tanstack/react-form Patch
@tanstack/form-core Patch
@tanstack/react-form-nextjs Patch
@tanstack/react-form-remix Patch
@tanstack/react-form-start Patch
@tanstack/angular-form Patch
@tanstack/form-devtools Patch
@tanstack/lit-form Patch
@tanstack/solid-form Patch
@tanstack/svelte-form Patch
@tanstack/vue-form Patch
@tanstack/react-form-devtools Patch
@tanstack/solid-form-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2025

View your CI Pipeline Execution ↗ for commit a3da6ef

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 34s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-01 18:36:40 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 1, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1893

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1893

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1893

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1893

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1893

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1893

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@1893

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@1893

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@1893

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1893

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@1893

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1893

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1893

commit: a3da6ef

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (6892ed0) to head (a3da6ef).
⚠️ Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
packages/react-form/src/useForm.tsx 70.58% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
- Coverage   90.35%   90.12%   -0.23%     
==========================================
  Files          38       41       +3     
  Lines        1752     1884     +132     
  Branches      444      473      +29     
==========================================
+ Hits         1583     1698     +115     
- Misses        149      166      +17     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crutchcorn
Copy link
Member Author

@TkDodo ready for re-review! Thanks for your help here

Copy link

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely 🎉

@crutchcorn crutchcorn merged commit 8afbfc3 into main Dec 1, 2025
6 of 7 checks passed
@crutchcorn crutchcorn deleted the fix-react-compiler branch December 1, 2025 18:38
@github-actions github-actions bot mentioned this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useFieldContext reactivity broken by React Compiler and ternary operator

3 participants