From 2f8a7fe1ae4e0976ab7a4b36424f6daa333e29f3 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Sat, 11 Apr 2026 13:05:41 +0900 Subject: [PATCH 1/2] test(svelte-query): unify queryClient passing to 'setQueryClientContext' and rename test components --- .../svelte-query/tests/ProviderWrapper.svelte | 14 ---------- ...entComponent.svelte => BaseExample.svelte} | 4 +-- ...hildComponent.svelte => QueryChild.svelte} | 0 .../QueryClientProvider.svelte.test.ts | 4 +-- .../createInfiniteQuery/BaseExample.svelte | 17 ++++++------ ...ient.svelte => ChangeClientExample.svelte} | 18 ++++++------- .../createInfiniteQuery/SelectExample.svelte | 23 ++++++++-------- .../createInfiniteQuery.svelte.test.ts | 4 +-- .../createQueries/IsRestoringExample.svelte | 19 ++++++------- .../createQuery/IsRestoringExample.svelte | 15 +++++------ .../tests/useIsFetching/BaseExample.svelte | 27 ++++++++++++++----- .../tests/useIsFetching/FetchStatus.svelte | 6 ----- .../tests/useIsFetching/Query.svelte | 16 ----------- .../tests/useIsMutating/BaseExample.svelte | 23 +++++++++++----- .../tests/useIsMutating/MutatingStatus.svelte | 6 ----- .../tests/useIsMutating/Query.svelte | 11 -------- 16 files changed, 84 insertions(+), 123 deletions(-) delete mode 100644 packages/svelte-query/tests/ProviderWrapper.svelte rename packages/svelte-query/tests/QueryClientProvider/{ParentComponent.svelte => BaseExample.svelte} (78%) rename packages/svelte-query/tests/QueryClientProvider/{ChildComponent.svelte => QueryChild.svelte} (100%) rename packages/svelte-query/tests/createInfiniteQuery/{ChangeClient.svelte => ChangeClientExample.svelte} (62%) delete mode 100644 packages/svelte-query/tests/useIsFetching/FetchStatus.svelte delete mode 100644 packages/svelte-query/tests/useIsFetching/Query.svelte delete mode 100644 packages/svelte-query/tests/useIsMutating/MutatingStatus.svelte delete mode 100644 packages/svelte-query/tests/useIsMutating/Query.svelte diff --git a/packages/svelte-query/tests/ProviderWrapper.svelte b/packages/svelte-query/tests/ProviderWrapper.svelte deleted file mode 100644 index b61d2d99daf..00000000000 --- a/packages/svelte-query/tests/ProviderWrapper.svelte +++ /dev/null @@ -1,14 +0,0 @@ - - - - {@render children()} - diff --git a/packages/svelte-query/tests/QueryClientProvider/ParentComponent.svelte b/packages/svelte-query/tests/QueryClientProvider/BaseExample.svelte similarity index 78% rename from packages/svelte-query/tests/QueryClientProvider/ParentComponent.svelte rename to packages/svelte-query/tests/QueryClientProvider/BaseExample.svelte index c7b6fa0c5bf..847135b1a71 100644 --- a/packages/svelte-query/tests/QueryClientProvider/ParentComponent.svelte +++ b/packages/svelte-query/tests/QueryClientProvider/BaseExample.svelte @@ -1,11 +1,11 @@ - + diff --git a/packages/svelte-query/tests/QueryClientProvider/ChildComponent.svelte b/packages/svelte-query/tests/QueryClientProvider/QueryChild.svelte similarity index 100% rename from packages/svelte-query/tests/QueryClientProvider/ChildComponent.svelte rename to packages/svelte-query/tests/QueryClientProvider/QueryChild.svelte diff --git a/packages/svelte-query/tests/QueryClientProvider/QueryClientProvider.svelte.test.ts b/packages/svelte-query/tests/QueryClientProvider/QueryClientProvider.svelte.test.ts index 754e492fccd..151bc2bf921 100644 --- a/packages/svelte-query/tests/QueryClientProvider/QueryClientProvider.svelte.test.ts +++ b/packages/svelte-query/tests/QueryClientProvider/QueryClientProvider.svelte.test.ts @@ -1,7 +1,7 @@ import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest' import { render } from '@testing-library/svelte' import { QueryClient } from '@tanstack/query-core' -import ParentComponent from './ParentComponent.svelte' +import BaseExample from './BaseExample.svelte' describe('QueryClientProvider', () => { beforeEach(() => { @@ -16,7 +16,7 @@ describe('QueryClientProvider', () => { const queryClient = new QueryClient() const queryCache = queryClient.getQueryCache() - const rendered = render(ParentComponent, { + const rendered = render(BaseExample, { props: { queryClient: queryClient, }, diff --git a/packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte b/packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte index 6c64621d86b..a2c7c1aef79 100644 --- a/packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte +++ b/packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte @@ -3,21 +3,20 @@ import { QueryClient } from '@tanstack/query-core' import { queryKey, sleep } from '@tanstack/query-test-utils' import { createInfiniteQuery } from '../../src/index.js' + import { setQueryClientContext } from '../../src/context.js' import type { QueryObserverResult } from '@tanstack/query-core' let { states }: { states: { value: Array } } = $props() const queryClient = new QueryClient() + setQueryClientContext(queryClient) - const query = createInfiniteQuery( - () => ({ - queryKey: queryKey(), - queryFn: ({ pageParam }) => sleep(10).then(() => pageParam), - getNextPageParam: (lastPage) => lastPage + 1, - initialPageParam: 0, - }), - () => queryClient, - ) + const query = createInfiniteQuery(() => ({ + queryKey: queryKey(), + queryFn: ({ pageParam }) => sleep(10).then(() => pageParam), + getNextPageParam: (lastPage) => lastPage + 1, + initialPageParam: 0, + })) $effect(() => { // @ts-expect-error diff --git a/packages/svelte-query/tests/createInfiniteQuery/ChangeClient.svelte b/packages/svelte-query/tests/createInfiniteQuery/ChangeClientExample.svelte similarity index 62% rename from packages/svelte-query/tests/createInfiniteQuery/ChangeClient.svelte rename to packages/svelte-query/tests/createInfiniteQuery/ChangeClientExample.svelte index 1993dca149e..41dfd6434c4 100644 --- a/packages/svelte-query/tests/createInfiniteQuery/ChangeClient.svelte +++ b/packages/svelte-query/tests/createInfiniteQuery/ChangeClientExample.svelte @@ -1,6 +1,7 @@ - - +
isFetching: {isFetching.current}
+
Data: {query.data ?? 'undefined'}
diff --git a/packages/svelte-query/tests/useIsFetching/FetchStatus.svelte b/packages/svelte-query/tests/useIsFetching/FetchStatus.svelte deleted file mode 100644 index 5b10705709e..00000000000 --- a/packages/svelte-query/tests/useIsFetching/FetchStatus.svelte +++ /dev/null @@ -1,6 +0,0 @@ - - -
isFetching: {isFetching.current}
diff --git a/packages/svelte-query/tests/useIsFetching/Query.svelte b/packages/svelte-query/tests/useIsFetching/Query.svelte deleted file mode 100644 index 6dd05ba5250..00000000000 --- a/packages/svelte-query/tests/useIsFetching/Query.svelte +++ /dev/null @@ -1,16 +0,0 @@ - - - - -
Data: {query.data ?? 'undefined'}
diff --git a/packages/svelte-query/tests/useIsMutating/BaseExample.svelte b/packages/svelte-query/tests/useIsMutating/BaseExample.svelte index e2e46622c7e..90cfe98f8e9 100644 --- a/packages/svelte-query/tests/useIsMutating/BaseExample.svelte +++ b/packages/svelte-query/tests/useIsMutating/BaseExample.svelte @@ -1,11 +1,20 @@ - - + - - +
isMutating: {isMutating.current}
diff --git a/packages/svelte-query/tests/useIsMutating/MutatingStatus.svelte b/packages/svelte-query/tests/useIsMutating/MutatingStatus.svelte deleted file mode 100644 index a747ed83261..00000000000 --- a/packages/svelte-query/tests/useIsMutating/MutatingStatus.svelte +++ /dev/null @@ -1,6 +0,0 @@ - - -
isMutating: {isMutating.current}
diff --git a/packages/svelte-query/tests/useIsMutating/Query.svelte b/packages/svelte-query/tests/useIsMutating/Query.svelte deleted file mode 100644 index 9ac53da16e3..00000000000 --- a/packages/svelte-query/tests/useIsMutating/Query.svelte +++ /dev/null @@ -1,11 +0,0 @@ - - - From 0037749506a916807b60646c3bb8cfaa9aa0e0b6 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Sat, 11 Apr 2026 04:08:20 +0000 Subject: [PATCH 2/2] ci: apply automated fixes --- .../tests/createQueries/IsRestoringExample.svelte | 5 ++++- .../svelte-query/tests/createQuery/IsRestoringExample.svelte | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/svelte-query/tests/createQueries/IsRestoringExample.svelte b/packages/svelte-query/tests/createQueries/IsRestoringExample.svelte index 87c8fc4dd4b..5c0a4ba56e8 100644 --- a/packages/svelte-query/tests/createQueries/IsRestoringExample.svelte +++ b/packages/svelte-query/tests/createQueries/IsRestoringExample.svelte @@ -1,7 +1,10 @@