From e4254a5784c792b4b98562efbb7366f7310993ba Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Sat, 11 Apr 2026 16:36:07 +0900 Subject: [PATCH] test(svelte-query): replace inline props types with 'type Props', remove 'any', and add explicit generics --- .../tests/HydrationBoundary/BaseExample.svelte | 10 ++++------ .../tests/QueryClientProvider/BaseExample.svelte | 6 +++++- .../tests/createInfiniteQuery/BaseExample.svelte | 9 ++++----- .../ChangeClientExample.svelte | 6 +++++- .../createInfiniteQuery/SelectExample.svelte | 9 ++++----- .../tests/createMutation/FailureExample.svelte | 9 ++++----- .../tests/createMutation/OnSuccessExample.svelte | 4 ++-- .../tests/createMutation/ResetExample.svelte | 6 +++++- .../createQueries/IsRestoringExample.svelte | 10 ++++------ .../tests/createQuery/IsRestoringExample.svelte | 9 ++++----- .../tests/mutationOptions/BaseExample.svelte | 14 ++++++++------ .../tests/mutationOptions/MultiExample.svelte | 16 +++++++++------- .../tests/useIsFetching/BaseExample.svelte | 6 +++++- .../tests/useIsMutating/BaseExample.svelte | 6 +++++- .../tests/useMutationState/BaseExample.svelte | 14 ++++++++------ .../tests/useMutationState/SelectExample.svelte | 14 ++++++-------- 16 files changed, 82 insertions(+), 66 deletions(-) diff --git a/packages/svelte-query/tests/HydrationBoundary/BaseExample.svelte b/packages/svelte-query/tests/HydrationBoundary/BaseExample.svelte index 67853f1b6ed..f8f33607257 100644 --- a/packages/svelte-query/tests/HydrationBoundary/BaseExample.svelte +++ b/packages/svelte-query/tests/HydrationBoundary/BaseExample.svelte @@ -7,15 +7,13 @@ } from '../../src/index.js' import type { DehydratedState } from '@tanstack/query-core' - let { - queryClient, - dehydratedState, - queryFn, - }: { + type Props = { queryClient: QueryClient dehydratedState: DehydratedState queryFn: () => Promise - } = $props() + } + + let { queryClient, dehydratedState, queryFn }: Props = $props() setQueryClientContext(queryClient) diff --git a/packages/svelte-query/tests/QueryClientProvider/BaseExample.svelte b/packages/svelte-query/tests/QueryClientProvider/BaseExample.svelte index 847135b1a71..f7f8fe61c46 100644 --- a/packages/svelte-query/tests/QueryClientProvider/BaseExample.svelte +++ b/packages/svelte-query/tests/QueryClientProvider/BaseExample.svelte @@ -3,7 +3,11 @@ import QueryChild from './QueryChild.svelte' import type { QueryClient } from '@tanstack/query-core' - let { queryClient }: { queryClient: QueryClient } = $props() + type Props = { + queryClient: QueryClient + } + + let { queryClient }: Props = $props() diff --git a/packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte b/packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte index 0e3dde1ffb1..0c2992d2188 100644 --- a/packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte +++ b/packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte @@ -5,13 +5,12 @@ import { setQueryClientContext } from '../../src/context.js' import type { QueryClient, QueryObserverResult } from '@tanstack/query-core' - let { - queryClient, - states, - }: { + type Props = { queryClient: QueryClient states: { value: Array } - } = $props() + } + + let { queryClient, states }: Props = $props() setQueryClientContext(queryClient) diff --git a/packages/svelte-query/tests/createInfiniteQuery/ChangeClientExample.svelte b/packages/svelte-query/tests/createInfiniteQuery/ChangeClientExample.svelte index 41dfd6434c4..b126dc11b77 100644 --- a/packages/svelte-query/tests/createInfiniteQuery/ChangeClientExample.svelte +++ b/packages/svelte-query/tests/createInfiniteQuery/ChangeClientExample.svelte @@ -4,7 +4,11 @@ import { setQueryClientContext } from '../../src/context.js' import { sleep } from '@tanstack/query-test-utils' - let { queryClient }: { queryClient: QueryClient } = $props() + type Props = { + queryClient: QueryClient + } + + let { queryClient }: Props = $props() const queryKey = ['test'] diff --git a/packages/svelte-query/tests/createInfiniteQuery/SelectExample.svelte b/packages/svelte-query/tests/createInfiniteQuery/SelectExample.svelte index e62238b6595..67ed277a5bd 100644 --- a/packages/svelte-query/tests/createInfiniteQuery/SelectExample.svelte +++ b/packages/svelte-query/tests/createInfiniteQuery/SelectExample.svelte @@ -5,13 +5,12 @@ import type { QueryClient, QueryObserverResult } from '@tanstack/query-core' import { queryKey, sleep } from '@tanstack/query-test-utils' - let { - queryClient, - states, - }: { + type Props = { queryClient: QueryClient states: { value: Array } - } = $props() + } + + let { queryClient, states }: Props = $props() setQueryClientContext(queryClient) diff --git a/packages/svelte-query/tests/createMutation/FailureExample.svelte b/packages/svelte-query/tests/createMutation/FailureExample.svelte index 4de6bbefc31..4e4ee154f44 100644 --- a/packages/svelte-query/tests/createMutation/FailureExample.svelte +++ b/packages/svelte-query/tests/createMutation/FailureExample.svelte @@ -2,13 +2,12 @@ import type { QueryClient } from '@tanstack/query-core' import { createMutation, setQueryClientContext } from '../../src/index.js' - let { - queryClient, - mutationFn, - }: { + type Props = { queryClient: QueryClient mutationFn: (value: { count: number }) => Promise<{ count: number }> - } = $props() + } + + let { queryClient, mutationFn }: Props = $props() let count = $state(0) diff --git a/packages/svelte-query/tests/createMutation/OnSuccessExample.svelte b/packages/svelte-query/tests/createMutation/OnSuccessExample.svelte index b2b870a1138..20b38722390 100644 --- a/packages/svelte-query/tests/createMutation/OnSuccessExample.svelte +++ b/packages/svelte-query/tests/createMutation/OnSuccessExample.svelte @@ -5,8 +5,8 @@ type Props = { queryClient: QueryClient - onSuccessMock: any - onSettledMock: any + onSuccessMock: (data: number) => void + onSettledMock: (data: number | undefined) => void } const { queryClient, onSettledMock, onSuccessMock }: Props = $props() diff --git a/packages/svelte-query/tests/createMutation/ResetExample.svelte b/packages/svelte-query/tests/createMutation/ResetExample.svelte index 84fa09e2136..0faf9cd572a 100644 --- a/packages/svelte-query/tests/createMutation/ResetExample.svelte +++ b/packages/svelte-query/tests/createMutation/ResetExample.svelte @@ -3,7 +3,11 @@ import { createMutation, setQueryClientContext } from '../../src/index.js' import { sleep } from '@tanstack/query-test-utils' - let { queryClient }: { queryClient: QueryClient } = $props() + type Props = { + queryClient: QueryClient + } + + let { queryClient }: Props = $props() setQueryClientContext(queryClient) diff --git a/packages/svelte-query/tests/createQueries/IsRestoringExample.svelte b/packages/svelte-query/tests/createQueries/IsRestoringExample.svelte index 0e41860e698..ad179a27da1 100644 --- a/packages/svelte-query/tests/createQueries/IsRestoringExample.svelte +++ b/packages/svelte-query/tests/createQueries/IsRestoringExample.svelte @@ -7,15 +7,13 @@ } from '../../src/context.js' import { createQueries } from '../../src/index.js' - let { - queryClient, - queryFn1, - queryFn2, - }: { + type Props = { queryClient: QueryClient queryFn1: () => Promise queryFn2: () => Promise - } = $props() + } + + let { queryClient, queryFn1, queryFn2 }: Props = $props() setQueryClientContext(queryClient) setIsRestoringContext({ current: true }) diff --git a/packages/svelte-query/tests/createQuery/IsRestoringExample.svelte b/packages/svelte-query/tests/createQuery/IsRestoringExample.svelte index 5b268f56b8d..ffbde4806bc 100644 --- a/packages/svelte-query/tests/createQuery/IsRestoringExample.svelte +++ b/packages/svelte-query/tests/createQuery/IsRestoringExample.svelte @@ -7,13 +7,12 @@ } from '../../src/context.js' import { createQuery } from '../../src/index.js' - let { - queryClient, - queryFn, - }: { + type Props = { queryClient: QueryClient queryFn: () => Promise - } = $props() + } + + let { queryClient, queryFn }: Props = $props() setQueryClientContext(queryClient) setIsRestoringContext({ current: true }) diff --git a/packages/svelte-query/tests/mutationOptions/BaseExample.svelte b/packages/svelte-query/tests/mutationOptions/BaseExample.svelte index fd58a4e9b78..c1388abab0a 100644 --- a/packages/svelte-query/tests/mutationOptions/BaseExample.svelte +++ b/packages/svelte-query/tests/mutationOptions/BaseExample.svelte @@ -13,17 +13,19 @@ } from '../../src/index.js' import type { MutationFilters } from '@tanstack/query-core' + type Props = { + queryClient: QueryClient + mutationOpts: Accessor> + isMutatingFilters?: MutationFilters + mutationStateOpts?: MutationStateOptions + } + let { queryClient, mutationOpts, isMutatingFilters, mutationStateOpts, - }: { - queryClient: QueryClient - mutationOpts: Accessor> - isMutatingFilters?: MutationFilters - mutationStateOpts?: MutationStateOptions - } = $props() + }: Props = $props() setQueryClientContext(queryClient) diff --git a/packages/svelte-query/tests/mutationOptions/MultiExample.svelte b/packages/svelte-query/tests/mutationOptions/MultiExample.svelte index a924dd4c24e..ee55f81403c 100644 --- a/packages/svelte-query/tests/mutationOptions/MultiExample.svelte +++ b/packages/svelte-query/tests/mutationOptions/MultiExample.svelte @@ -13,19 +13,21 @@ } from '../../src/index.js' import type { MutationFilters } from '@tanstack/query-core' + type Props = { + queryClient: QueryClient + mutationOpts1: Accessor> + mutationOpts2: Accessor> + isMutatingFilters?: MutationFilters + mutationStateOpts?: MutationStateOptions + } + let { queryClient, mutationOpts1, mutationOpts2, isMutatingFilters, mutationStateOpts, - }: { - queryClient: QueryClient - mutationOpts1: Accessor> - mutationOpts2: Accessor> - isMutatingFilters?: MutationFilters - mutationStateOpts?: MutationStateOptions - } = $props() + }: Props = $props() setQueryClientContext(queryClient) diff --git a/packages/svelte-query/tests/useIsFetching/BaseExample.svelte b/packages/svelte-query/tests/useIsFetching/BaseExample.svelte index 6c18cd166bb..1feeace6a17 100644 --- a/packages/svelte-query/tests/useIsFetching/BaseExample.svelte +++ b/packages/svelte-query/tests/useIsFetching/BaseExample.svelte @@ -4,7 +4,11 @@ import { setQueryClientContext } from '../../src/context.js' import { createQuery, useIsFetching } from '../../src/index.js' - let { queryClient }: { queryClient: QueryClient } = $props() + type Props = { + queryClient: QueryClient + } + + let { queryClient }: Props = $props() setQueryClientContext(queryClient) diff --git a/packages/svelte-query/tests/useIsMutating/BaseExample.svelte b/packages/svelte-query/tests/useIsMutating/BaseExample.svelte index 8e02cf94569..37577820744 100644 --- a/packages/svelte-query/tests/useIsMutating/BaseExample.svelte +++ b/packages/svelte-query/tests/useIsMutating/BaseExample.svelte @@ -4,7 +4,11 @@ import { setQueryClientContext } from '../../src/context.js' import { createMutation, useIsMutating } from '../../src/index.js' - let { queryClient }: { queryClient: QueryClient } = $props() + type Props = { + queryClient: QueryClient + } + + let { queryClient }: Props = $props() setQueryClientContext(queryClient) diff --git a/packages/svelte-query/tests/useMutationState/BaseExample.svelte b/packages/svelte-query/tests/useMutationState/BaseExample.svelte index 105eced302c..b6b6b935732 100644 --- a/packages/svelte-query/tests/useMutationState/BaseExample.svelte +++ b/packages/svelte-query/tests/useMutationState/BaseExample.svelte @@ -11,17 +11,19 @@ MutationStateOptions, } from '../../src/index.js' + type Props = { + queryClient: QueryClient + successMutationOpts: Accessor> + errorMutationOpts: Accessor> + mutationStateOpts?: MutationStateOptions + } + let { queryClient, successMutationOpts, errorMutationOpts, mutationStateOpts, - }: { - queryClient: QueryClient - successMutationOpts: Accessor - errorMutationOpts: Accessor - mutationStateOpts?: MutationStateOptions | undefined - } = $props() + }: Props = $props() setQueryClientContext(queryClient) diff --git a/packages/svelte-query/tests/useMutationState/SelectExample.svelte b/packages/svelte-query/tests/useMutationState/SelectExample.svelte index e96afb1b005..80c00a05652 100644 --- a/packages/svelte-query/tests/useMutationState/SelectExample.svelte +++ b/packages/svelte-query/tests/useMutationState/SelectExample.svelte @@ -11,15 +11,13 @@ MutationStateOptions, } from '../../src/index.js' - let { - queryClient, - mutationOpts, - mutationStateOpts, - }: { + type Props = { queryClient: QueryClient - mutationOpts: Accessor - mutationStateOpts: MutationStateOptions - } = $props() + mutationOpts: Accessor> + mutationStateOpts: MutationStateOptions + } + + let { queryClient, mutationOpts, mutationStateOpts }: Props = $props() setQueryClientContext(queryClient)