From c78c224fe28ba8c9c9d5cc4d95a57f071c9706b8 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Mon, 11 May 2026 02:11:58 +0900 Subject: [PATCH 1/3] test(query-devtools/Devtools): add tests for sort dropdown, hide disabled queries, and sort order toggle --- .../src/__tests__/Devtools.test.tsx | 78 ++++++++++++++++++- 1 file changed, 77 insertions(+), 1 deletion(-) diff --git a/packages/query-devtools/src/__tests__/Devtools.test.tsx b/packages/query-devtools/src/__tests__/Devtools.test.tsx index 9164b8065c..66ae9e7ceb 100644 --- a/packages/query-devtools/src/__tests__/Devtools.test.tsx +++ b/packages/query-devtools/src/__tests__/Devtools.test.tsx @@ -1,5 +1,9 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest' -import { QueryClient, onlineManager } from '@tanstack/query-core' +import { + QueryClient, + QueryObserver, + onlineManager, +} from '@tanstack/query-core' import { fireEvent, render } from '@solidjs/testing-library' import { createLocalStorage } from '@solid-primitives/storage' import { Devtools } from '../Devtools' @@ -732,4 +736,76 @@ describe('Devtools', () => { ) }) }) + + describe('sort by', () => { + it('should change sort key when the sort dropdown is changed in queries view', () => { + const rendered = renderDevtools({ initialIsOpen: true }) + + fireEvent.change(rendered.getByLabelText('Sort queries by'), { + target: { value: 'last updated' }, + }) + + expect(localStorage.getItem('TanstackQueryDevtools.sort')).toBe( + 'last updated', + ) + }) + + it('should change sort key when the sort dropdown is changed in mutations view', () => { + const rendered = renderDevtools({ initialIsOpen: true }) + fireEvent.click(rendered.getByText('Mutations')) + + fireEvent.change(rendered.getByLabelText('Sort mutations by'), { + target: { value: 'last updated' }, + }) + + expect(localStorage.getItem('TanstackQueryDevtools.mutationSort')).toBe( + 'last updated', + ) + }) + + it('should hide disabled queries when "hideDisabledQueries" is enabled in localStorage', () => { + const disabled = new QueryObserver(queryClient, { + queryKey: ['hide-test-disabled'], + queryFn: () => 'x', + enabled: false, + }) + const unsubscribe = disabled.subscribe(() => {}) + queryClient.setQueryData(['hide-test-disabled'], 'x') + queryClient.setQueryData(['hide-test-active'], 'y') + + try { + const rendered = renderDevtools( + { initialIsOpen: true }, + { 'TanstackQueryDevtools.hideDisabledQueries': 'true' }, + ) + + expect( + rendered.queryByLabelText(/Query key \["hide-test-disabled"\]/), + ).not.toBeInTheDocument() + expect( + rendered.getByLabelText(/Query key \["hide-test-active"\]/), + ).toBeInTheDocument() + } finally { + unsubscribe() + } + }) + }) + + describe('sort order', () => { + it('should toggle the sort order when the sort order button is clicked', () => { + const rendered = renderDevtools({ initialIsOpen: true }) + + fireEvent.click(rendered.getByLabelText(/Sort order/)) + const afterFirstToggle = localStorage.getItem( + 'TanstackQueryDevtools.sortOrder', + ) + expect(afterFirstToggle).not.toBeNull() + + fireEvent.click(rendered.getByLabelText(/Sort order/)) + const afterSecondToggle = localStorage.getItem( + 'TanstackQueryDevtools.sortOrder', + ) + expect(afterSecondToggle).not.toBe(afterFirstToggle) + }) + }) }) From 4d4617c6779b07f83c0326b158b2f186d7db7ced Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Sun, 10 May 2026 17:13:36 +0000 Subject: [PATCH 2/3] ci: apply automated fixes --- packages/query-devtools/src/__tests__/Devtools.test.tsx | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/query-devtools/src/__tests__/Devtools.test.tsx b/packages/query-devtools/src/__tests__/Devtools.test.tsx index 66ae9e7ceb..8e34f5fb32 100644 --- a/packages/query-devtools/src/__tests__/Devtools.test.tsx +++ b/packages/query-devtools/src/__tests__/Devtools.test.tsx @@ -1,9 +1,5 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest' -import { - QueryClient, - QueryObserver, - onlineManager, -} from '@tanstack/query-core' +import { QueryClient, QueryObserver, onlineManager } from '@tanstack/query-core' import { fireEvent, render } from '@solidjs/testing-library' import { createLocalStorage } from '@solid-primitives/storage' import { Devtools } from '../Devtools' From a3946f74e98a1c76170d1cce43cbf9ba385e2e9f Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Mon, 11 May 2026 02:19:59 +0900 Subject: [PATCH 3/3] test(query-devtools/Devtools): assert exact 'sortOrder' values ('1' and '-1') across consecutive toggles --- packages/query-devtools/src/__tests__/Devtools.test.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/query-devtools/src/__tests__/Devtools.test.tsx b/packages/query-devtools/src/__tests__/Devtools.test.tsx index 8e34f5fb32..6517f2a013 100644 --- a/packages/query-devtools/src/__tests__/Devtools.test.tsx +++ b/packages/query-devtools/src/__tests__/Devtools.test.tsx @@ -795,13 +795,13 @@ describe('Devtools', () => { const afterFirstToggle = localStorage.getItem( 'TanstackQueryDevtools.sortOrder', ) - expect(afterFirstToggle).not.toBeNull() + expect(['1', '-1']).toContain(afterFirstToggle) fireEvent.click(rendered.getByLabelText(/Sort order/)) const afterSecondToggle = localStorage.getItem( 'TanstackQueryDevtools.sortOrder', ) - expect(afterSecondToggle).not.toBe(afterFirstToggle) + expect(afterSecondToggle).toBe(afterFirstToggle === '1' ? '-1' : '1') }) }) })