Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: react native uSES #4185

Merged
merged 1 commit into from Sep 19, 2022
Merged

Conversation

DamianOsipiuk
Copy link
Contributor

@DamianOsipiuk DamianOsipiuk commented Sep 18, 2022

@TkDodo
This is a potential fix following the same pattern as other .native files.
Unfortunately i do not have a good way to test it out. So people that have a reliable native setup should say if it works as intended.

fixes #4154

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0faab60:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2022

Codecov Report

Base: 96.36% // Head: 96.41% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (0faab60) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4185      +/-   ##
==========================================
+ Coverage   96.36%   96.41%   +0.05%     
==========================================
  Files          45       62      +17     
  Lines        2281     2734     +453     
  Branches      640      789     +149     
==========================================
+ Hits         2198     2636     +438     
- Misses         80       96      +16     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
src/react/tests/utils.tsx
src/devtools/devtools.tsx
src/react/setBatchUpdatesFn.ts
src/devtools/useMediaQuery.ts
src/react/useQueries.ts
src/react/useQuery.ts
src/devtools/useLocalStorage.ts
src/react/useBaseQuery.ts
src/core/utils.ts
src/devtools/styledComponents.ts
... and 97 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo
Copy link
Collaborator

TkDodo commented Sep 19, 2022

@TkDodo TkDodo merged commit 932dbc4 into TanStack:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@tanstack/react-query@4.3.4 react-native example does not work - queryFn not being called
3 participants