-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix(vue-query): fix bug where ref is destructured #4363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue-query): fix bug where ref is destructured #4363
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fb5c8f5:
|
|
getting a react query error on the top set of tests |
|
sorry about that, it's a flaky test. I really need to get around to remove all those weird sleep timings in most test assertions :/ |
|
all good ! |
Codecov ReportBase: 96.36% // Head: 92.27% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4363 +/- ##
==========================================
- Coverage 96.36% 92.27% -4.09%
==========================================
Files 45 87 +42
Lines 2281 3562 +1281
Branches 640 902 +262
==========================================
+ Hits 2198 3287 +1089
- Misses 80 259 +179
- Partials 3 16 +13 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
non-plain object is no longer destructured. tests added to prevent similar bugs from occuring going forward. improve parseMutationArgs function