Skip to content

Conversation

@matthewhausman
Copy link
Contributor

non-plain object is no longer destructured. tests added to prevent similar bugs from occuring going forward. improve parseMutationArgs function

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 23, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb5c8f5:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@matthewhausman
Copy link
Contributor Author

getting a react query error on the top set of tests

@TkDodo
Copy link
Collaborator

TkDodo commented Oct 23, 2022

sorry about that, it's a flaky test. I really need to get around to remove all those weird sleep timings in most test assertions :/

@matthewhausman
Copy link
Contributor Author

all good !

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Base: 96.36% // Head: 92.27% // Decreases project coverage by -4.08% ⚠️

Coverage data is based on head (fb5c8f5) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4363      +/-   ##
==========================================
- Coverage   96.36%   92.27%   -4.09%     
==========================================
  Files          45       87      +42     
  Lines        2281     3562    +1281     
  Branches      640      902     +262     
==========================================
+ Hits         2198     3287    +1089     
- Misses         80      259     +179     
- Partials        3       16      +13     
Impacted Files Coverage Δ
src/react/utils.ts
src/react/QueryErrorResetBoundary.tsx
...rc/createWebStoragePersistor-experimental/index.ts
src/devtools/Explorer.tsx
src/devtools/styledComponents.ts
src/core/queryCache.ts
src/core/logger.ts
src/react/useQueries.ts
src/core/onlineManager.ts
src/react/useInfiniteQuery.ts
... and 122 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo TkDodo requested a review from DamianOsipiuk October 23, 2022 08:54
@DamianOsipiuk DamianOsipiuk merged commit a7972eb into TanStack:main Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants