Skip to content

Conversation

@emzoumpo
Copy link
Contributor

@emzoumpo emzoumpo commented Feb 25, 2023

Sort options (asc / desc, and sort function) were hidden when filter was set.
Sort options are now shown along with the filter, even when a filter is set.

Closes #4989

@vercel
Copy link

vercel bot commented Feb 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
query ⬜️ Ignored (Inspect) Feb 25, 2023 at 10:52PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fd9feb5:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@emzoumpo
Copy link
Contributor Author

emzoumpo commented Feb 25, 2023

@TkDodo the failed action doesn't seem to be the result of my changes, locally the tests are passing.
test-fail-svelte
Edit: I just rerun the tests and now they are passing, so the failure seems random.

Sort options (asc / desc, and sort function) were hidden when filter was set.
Sort options are now shown along with the filter, even when a filter is set.

Closes TanStack#4989
@emzoumpo emzoumpo force-pushed the bugfix/always-show-all-sort-options-in-devtools branch from 240806c to fd9feb5 Compare February 25, 2023 22:52
@codecov-commenter
Copy link

Codecov Report

Base: 91.88% // Head: 91.88% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (fd9feb5) compared to base (9434a16).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5038      +/-   ##
==========================================
- Coverage   91.88%   91.88%   -0.01%     
==========================================
  Files         111      111              
  Lines        4178     4175       -3     
  Branches     1085     1082       -3     
==========================================
- Hits         3839     3836       -3     
  Misses        318      318              
  Partials       21       21              
Impacted Files Coverage Δ
packages/react-query-devtools/src/devtools.tsx 83.75% <100.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo TkDodo merged commit 86e8413 into TanStack:main Feb 26, 2023
@emzoumpo emzoumpo deleted the bugfix/always-show-all-sort-options-in-devtools branch February 27, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Devtools (React) "Filter" field, when used, makes "Sort" dropdown, "Asc / Desc" and "offline" buttons disappear

3 participants